From: Kees Cook <keescook@chromium.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>
Subject: Re: [PATCH 00/10] vdso: Misc cleanups and prevent code duplication
Date: Mon, 19 Feb 2024 16:26:59 -0800 [thread overview]
Message-ID: <202402191625.BAD1F3CE6@keescook> (raw)
In-Reply-To: <20240219153939.75719-1-anna-maria@linutronix.de>
On Mon, Feb 19, 2024 at 04:39:29PM +0100, Anna-Maria Behnsen wrote:
> Hi,
>
> the vdso related cleanup queue contains two parts:
>
> - Patch 1-3: Misc cleanups related to a comment, a superfluous header
> include and ifdeffery
>
> - Patch 4-10: The union vdso_data_store is defined in seven
> architectures. Make this union available in a generic vdso
> header file to prevent code duplication and fix the
> architectures one by one to use the generic vdso_data_store.
>
> Thanks,
>
> Anna-Maria
I do love a good clean-up! Thanks for this, I looked through all the
patches and they seem correct to me; removed definitions are all
identical, and __page_aligned_data is kept where needed.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
--
Kees Cook
next prev parent reply other threads:[~2024-02-20 0:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 15:39 [PATCH 00/10] vdso: Misc cleanups and prevent code duplication Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 01/10] vdso/helpers: Fix grammar in comments Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 02/10] s390/vdso/data: Drop unnecessary header include Anna-Maria Behnsen
2024-02-19 16:21 ` Heiko Carstens
2024-02-20 20:04 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 03/10] csky/vdso: Remove superfluous ifdeffery Anna-Maria Behnsen
2024-02-20 1:12 ` Guo Ren
2024-02-20 20:04 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 04/10] vdso/arm: make union vdso_data_store available for all Anna-Maria Behnsen
2024-02-19 15:39 ` Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] vdso/ARM: Make union vdso_data_store available for all architectures tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 05/10] arm64/vdso: Use generic union vdso_data_store Anna-Maria Behnsen
2024-02-19 15:39 ` Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] arm64: vdso: " tip-bot2 for Anna-Maria Behnsen
2024-02-22 15:41 ` [PATCH 05/10] arm64/vdso: " Will Deacon
2024-02-22 15:41 ` Will Deacon
2024-02-19 15:39 ` [PATCH 06/10] riscv/vdso: " Anna-Maria Behnsen
2024-02-19 15:39 ` Anna-Maria Behnsen
2024-02-20 6:45 ` kernel test robot
2024-02-20 6:45 ` kernel test robot
2024-02-20 8:52 ` [PATCH v1a] " Anna-Maria Behnsen
2024-02-20 8:52 ` Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] riscv: vdso: " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 07/10] s390/vdso: " Anna-Maria Behnsen
2024-02-19 16:22 ` Heiko Carstens
2024-02-20 20:04 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 08/10] loongarch/vdso: " Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] LoongArch: vdso: " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 09/10] mips/vdso: " Anna-Maria Behnsen
2024-02-20 20:04 ` [tip: timers/core] MIPS: vdso: " tip-bot2 for Anna-Maria Behnsen
2024-02-19 15:39 ` [PATCH 10/10] csky/vdso: " Anna-Maria Behnsen
2024-02-20 1:13 ` Guo Ren
2024-02-20 20:04 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-02-20 0:26 ` Kees Cook [this message]
2024-02-20 9:50 ` [PATCH 00/10] vdso: Misc cleanups and prevent code duplication Anna-Maria Behnsen
2024-02-20 14:48 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402191625.BAD1F3CE6@keescook \
--to=keescook@chromium.org \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.