From: Christoph Hellwig <hch@lst.de>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Christoph Hellwig <hch@lst.de>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Jens Axboe <axboe@kernel.dk>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX
Date: Tue, 20 Feb 2024 16:50:41 +0100 [thread overview]
Message-ID: <20240220155041.GA17393@lst.de> (raw)
In-Reply-To: <ZdSPj32Ww80nKQhM@macbook>
On Tue, Feb 20, 2024 at 12:39:59PM +0100, Roger Pau Monné wrote:
> On Tue, Feb 20, 2024 at 09:49:32AM +0100, Christoph Hellwig wrote:
> > Currently xen-blkfront set the max discard limit to the capacity of
> > the device, which is suboptimal when the capacity changes. Just set
> > it to UINT_MAX, which has the same effect except and is simpler.
>
> Extra 'except' in the line above?
Yes, thanks.
next prev parent reply other threads:[~2024-02-20 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:49 convert xen-blkfront to atomic queue limit updates Christoph Hellwig
2024-02-20 8:49 ` [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX Christoph Hellwig
2024-02-20 11:39 ` Roger Pau Monné
2024-02-20 15:50 ` Christoph Hellwig [this message]
2024-02-20 8:49 ` [PATCH 2/4] xen-blkfront: rely on the default discard granularity Christoph Hellwig
2024-02-20 11:50 ` Roger Pau Monné
2024-02-20 8:49 ` [PATCH 3/4] xen-blkfront: don't redundantly set max_sements in blkif_recover Christoph Hellwig
2024-02-20 12:16 ` Roger Pau Monné
2024-02-20 8:49 ` [PATCH 4/4] xen-blkfront: atomically update queue limits Christoph Hellwig
2024-02-20 12:35 ` Roger Pau Monné
2024-02-20 15:53 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-02-21 12:58 convert xen-blkfront to atomic queue limit updates v2 Christoph Hellwig
2024-02-21 12:58 ` [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220155041.GA17393@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.