From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [net 08/10] net/mlx5e: RSS, Unconfigure RXFH after changing channels number
Date: Tue, 20 Feb 2024 18:46:17 -0800 [thread overview]
Message-ID: <20240220184617.41b7de4f@kernel.org> (raw)
In-Reply-To: <20240220032948.35305-3-saeed@kernel.org>
On Mon, 19 Feb 2024 19:29:46 -0800 Saeed Mahameed wrote:
> + /* Changing the channels number can affect the size of the RXFH indir table.
> + * Therefore, if the RXFH was previously configured,
> + * unconfigure it to ensure that the RXFH is reverted to a uniform table.
> + */
> + rxfh_configured = netif_is_rxfh_configured(priv->netdev);
> + if (rxfh_configured)
> + priv->netdev->priv_flags &= ~IFF_RXFH_CONFIGURED;
The sole purpose of this flag is to prevent drivers from resetting
configuration set by the user. The user can:
ethtool -X $ifc default
if they no longer care.
next prev parent reply other threads:[~2024-02-21 2:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 18:23 [pull request][net 00/10] mlx5 fixes 2024-02-19 Saeed Mahameed
2024-02-19 18:23 ` [net 01/10] Revert "net/mlx5: Block entering switchdev mode with ns inconsistency" Saeed Mahameed
2024-02-19 18:23 ` [net 02/10] Revert "net/mlx5e: Check the number of elements before walk TC rhashtable" Saeed Mahameed
2024-02-19 18:23 ` [net 03/10] net/mlx5: E-switch, Change flow rule destination checking Saeed Mahameed
2024-02-19 18:23 ` [net 04/10] net/mlx5: Fix fw reporter diagnose output Saeed Mahameed
2024-02-19 18:23 ` [net 05/10] net/mlx5: Check capability for fw_reset Saeed Mahameed
2024-02-20 3:29 ` [net 06/10] net/mlx5e: Change the warning when ignore_flow_level is not supported Saeed Mahameed
2024-02-20 3:29 ` [net 07/10] net/mlx5e: Fix MACsec state loss upon state update in offload path Saeed Mahameed
2024-02-20 3:29 ` [net 08/10] net/mlx5e: RSS, Unconfigure RXFH after changing channels number Saeed Mahameed
2024-02-21 2:46 ` Jakub Kicinski [this message]
2024-02-21 19:55 ` Tariq Toukan
2024-02-20 3:29 ` [net 09/10] net/mlx5e: Use a memory barrier to enforce PTP WQ xmit submission tracking occurs after populating the metadata_map Saeed Mahameed
2024-02-20 3:29 ` [net 10/10] net/mlx5e: Switch to using _bh variant of of spinlock API in port timestamping NAPI poll context Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220184617.41b7de4f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.