From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Alex Elder <elder@linaro.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Erick Archer <erick.archer@gmx.com>,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller()
Date: Wed, 21 Feb 2024 12:37:42 +0530 [thread overview]
Message-ID: <20240221070742.GG11693@thinkpad> (raw)
In-Reply-To: <bebcd822-d465-45da-adae-5435ec93e6d4@moroto.mountain>
On Wed, Feb 21, 2024 at 09:20:19AM +0300, Dan Carpenter wrote:
> There is a copy and paste bug here so it checks "ev_ring_el_cache" instead
> of "ring_item_cache".
>
> Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/bus/mhi/ep/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 8d7a4102bdb7..f8f674adf1d4 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> sizeof(struct mhi_ep_ring_item), 0,
> 0, NULL);
> - if (!mhi_cntrl->ev_ring_el_cache) {
> + if (!mhi_cntrl->ring_item_cache) {
> ret = -ENOMEM;
> goto err_destroy_tre_buf_cache;
> }
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-02-21 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 6:20 [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Dan Carpenter
2024-02-21 7:07 ` Manivannan Sadhasivam [this message]
2024-02-21 7:16 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221070742.GG11693@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=elder@linaro.org \
--cc=erick.archer@gmx.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.