From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 2/2] statx07.c: set umask to 0022
Date: Wed, 21 Feb 2024 08:32:49 +0100 [thread overview]
Message-ID: <20240221073249.GA1213466@pevik> (raw)
In-Reply-To: <20240221071635.17239-3-wegao@suse.com>
Hi Wei,
> When system's default umask is 0077, this will trigger issues.
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/syscalls/statx/statx07.c | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/testcases/kernel/syscalls/statx/statx07.c b/testcases/kernel/syscalls/statx/statx07.c
> index 4dbf83e18..1ad02fb3e 100644
> --- a/testcases/kernel/syscalls/statx/statx07.c
> +++ b/testcases/kernel/syscalls/statx/statx07.c
> @@ -116,6 +116,8 @@ static void setup(void)
> int ret;
> char server_path[BUFF_SIZE];
> + umask(0022);
Even this works, why not completely reset umask with umask(0), as I asked
previously? That's the safest option.
Kind regards,
Petr
> +
> cwd = tst_get_tmpdir();
> SAFE_MKDIR(SERV_PATH, DEFAULT_MODE);
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-02-21 7:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 0:26 [LTP] [PATCH v1] cgroup_core01.c: Set umask before create directory Wei Gao via ltp
2024-02-12 11:54 ` Andrea Cervesato via ltp
2024-02-19 13:48 ` [LTP] [PATCH v2] tst_test.c: Set system default umaks to 0022 Wei Gao via ltp
2024-02-20 9:18 ` Petr Vorel
2024-02-21 8:33 ` Wei Gao via ltp
2024-02-21 16:19 ` Petr Vorel
2024-02-22 13:53 ` Wei Gao via ltp
2024-02-21 7:16 ` [LTP] [PATCH v3 0/2] " Wei Gao via ltp
2024-02-21 7:16 ` [LTP] [PATCH v3 1/2] cgroup_core01.c: " Wei Gao via ltp
2024-02-21 7:16 ` [LTP] [PATCH v3 2/2] statx07.c: set umask " Wei Gao via ltp
2024-02-21 7:32 ` Petr Vorel [this message]
2024-02-21 8:42 ` [LTP] [PATCH v3 0/2] Set system default umaks to 0 Wei Gao via ltp
2024-02-21 8:42 ` [LTP] [PATCH v4 1/2] cgroup_core01.c: " Wei Gao via ltp
2024-02-21 8:42 ` [LTP] [PATCH v4 2/2] statx07.c: set umask " Wei Gao via ltp
2024-02-22 3:10 ` [LTP] [PATCH v5 0/2] Set system default umaks " Wei Gao via ltp
2024-02-22 3:10 ` [LTP] [PATCH v5 1/2] cgroup_core01.c: " Wei Gao via ltp
2024-03-01 7:26 ` Li Wang
2024-03-01 8:43 ` Petr Vorel
2024-03-01 10:07 ` Li Wang
2024-02-22 3:10 ` [LTP] [PATCH v5 2/2] statx07.c: set umask " Wei Gao via ltp
2024-03-01 7:28 ` Li Wang
2024-03-01 11:52 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221073249.GA1213466@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.