All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kirjanov <kirjanov@gmail.com>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org, Denis Kirjanov <dkirjanov@suse.de>
Subject: [PATCH iproute2] ifstat: handle unlink return value
Date: Wed, 21 Feb 2024 07:04:24 -0500	[thread overview]
Message-ID: <20240221120424.3221-1-dkirjanov@suse.de> (raw)

Print an error message if we can't remove the history file

Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>
---
 misc/ifstat.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/misc/ifstat.c b/misc/ifstat.c
index 18171a2c..5dede111 100644
--- a/misc/ifstat.c
+++ b/misc/ifstat.c
@@ -938,7 +938,9 @@ int main(int argc, char *argv[])
 				 getuid());
 
 	if (reset_history)
-		unlink(hist_name);
+		if (unlink(hist_name) < 0)
+			fprintf(stderr, "Cannot remove history file \"%s\": %s\n",
+				hist_name, strerror(errno));
 
 	if (!ignore_history || !no_update) {
 		struct stat stb;
-- 
2.30.2


             reply	other threads:[~2024-02-21 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 12:04 Denis Kirjanov [this message]
2024-02-29  0:51 ` [PATCH iproute2] ifstat: handle unlink return value Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221120424.3221-1-dkirjanov@suse.de \
    --to=kirjanov@gmail.com \
    --cc=dkirjanov@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.