From: Kees Cook <keescook@chromium.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kernel test robot <lkp@intel.com>,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, Andy Shevchenko <andy@kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Puyou Lu <puyou.lu@gmail.com>, Mark Brown <broonie@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Nathan Chancellor <nathan@kernel.org>,
Alexander Potapenko <glider@google.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
Randy Dunlap <rdunlap@infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Liam R. Howlett" <liam.howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yury Norov <yury.norov@gmail.com>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Sander Vanheule <sander@svanheule.net>,
Eric Biggers <ebiggers@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer
Date: Thu, 22 Feb 2024 08:30:30 -0800 [thread overview]
Message-ID: <202402220829.10C6C7C@keescook> (raw)
In-Reply-To: <19930c5a-f1ed-4b04-b69a-d7259966f020@app.fastmail.com>
On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote:
> On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote:
>
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link:
> > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >>> ld.lld: error: undefined symbol: __fortify_panic
> > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_count)
> > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_search)
> > >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >>> arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_get)
>
> I get a related build failure from the same commit:
>
> arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for '__fortify_panic' [-Werror=missing-prototypes]
> 157 | void __fortify_panic(const u8 reason, size_t avail, size_t size)
Whoops, thank you! This series got a refresh after you did the
missing-prototypes work and I missed this one. I've fixed it and
double-checked for any others. Hopefully this will be clean in the next
-next. :)
-Kees
--
Kees Cook
next prev parent reply other threads:[~2024-02-22 16:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 0:01 [PATCH 0/9] fortify: Add KUnit tests for runtime overflows Kees Cook
2023-04-06 0:02 ` [PATCH 1/9] kunit: tool: Enable CONFIG_FORTIFY_SOURCE under UML Kees Cook
2023-04-06 3:10 ` Kees Cook
2023-04-06 0:02 ` [PATCH 2/9] fortify: Allow KUnit test to build without FORTIFY Kees Cook
2023-04-06 1:22 ` Daniel Latypov
2023-04-06 23:09 ` Kees Cook
2023-04-06 0:02 ` [PATCH 3/9] string: Add Kunit tests for strcat() family Kees Cook
2023-04-06 4:19 ` kernel test robot
2023-04-06 9:11 ` Alexander Potapenko
2023-04-06 23:07 ` Kees Cook
2023-04-12 12:34 ` Alexander Potapenko
2023-04-06 0:02 ` [PATCH 4/9] fortify: Add protection for strlcat() Kees Cook
2023-04-06 13:32 ` Miguel Ojeda
2023-04-06 22:58 ` Kees Cook
2023-04-06 0:02 ` [PATCH 5/9] fortify: strcat: Move definition to use fortified strlcat() Kees Cook
2023-04-06 0:02 ` [PATCH 6/9] fortify: Split reporting and avoid passing string pointer Kees Cook
2023-04-06 10:20 ` Andy Shevchenko
2023-04-06 22:57 ` Kees Cook
2023-04-07 8:34 ` Andy Shevchenko
2023-04-07 19:49 ` Kees Cook
2023-04-06 11:19 ` kernel test robot
2024-02-22 13:00 ` Arnd Bergmann
2024-02-22 16:30 ` Kees Cook [this message]
2024-02-22 17:11 ` Andy Shevchenko
2023-04-06 13:44 ` Miguel Ojeda
2023-04-06 22:54 ` Kees Cook
2023-04-06 15:23 ` Alexander Lobakin
2023-04-06 22:54 ` Kees Cook
2023-04-07 10:26 ` kernel test robot
2023-04-06 0:02 ` [PATCH 7/9] fortify: Provide KUnit counters for failure testing Kees Cook
2023-04-06 0:02 ` [PATCH 8/9] fortify: Add KUnit tests for runtime overflows Kees Cook
2023-04-06 0:02 ` [PATCH 9/9] fortify: Improve buffer overflow reporting Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402220829.10C6C7C@keescook \
--to=keescook@chromium.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davidgow@google.com \
--cc=ebiggers@google.com \
--cc=geert+renesas@glider.be \
--cc=glider@google.com \
--cc=jpoimboe@kernel.org \
--cc=liam.howlett@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=puyou.lu@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sander@svanheule.net \
--cc=vbabka@suse.cz \
--cc=yury.norov@gmail.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.