From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>,
syzbot <syzbot+99d15fcdb0132a1e1a82@syzkaller.appspotmail.com>,
davem@davemloft.net, dsahern@kernel.org, horms@kernel.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] WARNING in mpls_gso_segment
Date: Thu, 22 Feb 2024 13:57:38 +0100 [thread overview]
Message-ID: <20240222125738.GC28098@breakpoint.cc> (raw)
In-Reply-To: <CANn89iJ6UxRPRJeat==LXQS7B7rYpUN3BvBJv3w1_v5y53cfSg@mail.gmail.com>
Eric Dumazet <edumazet@google.com> wrote:
> I was thinking about adding a debug check in skb_inner_network_header(skb)
> if inner_network_header is zero (that would mean it is not 'set' yet),
> but this would trigger even after your patch.
What about adding:
static inline bool skb_inner_network_header_was_set(const struct sk_buff *skb)
{
return skb->inner_network_header > 0;
}
... and using that instead of checking for negative header length
post-subtraction?
next prev parent reply other threads:[~2024-02-22 12:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 12:33 [syzbot] [net?] WARNING in mpls_gso_segment syzbot
2024-02-21 13:15 ` Florian Westphal
2024-02-22 8:14 ` Eric Dumazet
2024-02-22 12:23 ` Florian Westphal
2024-02-22 12:29 ` Eric Dumazet
2024-02-22 12:57 ` Florian Westphal [this message]
2024-02-22 13:27 ` Eric Dumazet
2024-02-22 14:03 ` [PATCH net v2] net: mpls: error out if inner headers are not set Florian Westphal
2024-02-23 3:33 ` Jakub Kicinski
2024-02-23 7:08 ` Florian Westphal
2024-02-24 2:10 ` patchwork-bot+netdevbpf
2024-02-22 3:15 ` [syzbot] [net?] WARNING in mpls_gso_segment Lizhi Xu
2024-02-22 3:41 ` syzbot
2024-02-22 4:00 ` [PATCH net-next] net/mpls: fix " Lizhi Xu
2024-02-22 8:11 ` Eric Dumazet
2024-02-23 3:30 ` Lizhi Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222125738.GC28098@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+99d15fcdb0132a1e1a82@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.