From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CF08C48BF8 for ; Thu, 22 Feb 2024 16:50:56 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=nuYshMwG; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TgfKV5TKnz3dXB for ; Fri, 23 Feb 2024 03:50:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=nuYshMwG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.201; helo=relay8-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TgfJZ2bsFz3d4H for ; Fri, 23 Feb 2024 03:50:05 +1100 (AEDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id C41811BF205; Thu, 22 Feb 2024 16:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708620602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19qhGNmQmWm9BCOh8qUm/W3o9hKN/eZYOSKauiIFfoY=; b=nuYshMwGlMUB6NdNCDKR2k/WM9Ms7Q/xXxQMJvOyn6XcCUUOSkmbB7v4BphjOXQdRDq6ft 5Kk34TTJiC//w2a7g7aPDHRsI1rtsjvEap40y4W41OI+nFwV0cWOoMZpTupFan6qEpoN4d YDNERvNW5AVAsApFCmaWj6ph5QjpC1Kw6HH8GibCvreOmv66EswhaYlfXGCBqlQDVydlS4 Zou9Ox0rlcFLYDRZDNc8KA4dchaTfAQq9bvoBzRPyC2o/bCnG5fN+wg7wN293MsMvmlS4M Y4b6k6JA9ATcrLJo42BpLaQPA+KtE3Peq7SHjCvF9vf0K7rJhFvfZzLT/azi3g== Date: Thu, 22 Feb 2024 17:49:59 +0100 From: Herve Codina To: Andy Shevchenko Subject: Re: [PATCH v4 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Message-ID: <20240222174959.7097c29b@bootlin.com> In-Reply-To: References: <20240222142219.441767-1-herve.codina@bootlin.com> <20240222142219.441767-4-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Vadim Fedorenko , Yury Norov , netdev@vger.kernel.org, Rasmus Villemoes , linux-kernel@vger.kernel.org, Eric Dumazet , Mark Brown , Thomas Petazzoni , Jakub Kicinski , Paolo Abeni , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Andy, Yury, On Thu, 22 Feb 2024 17:39:27 +0200 Andy Shevchenko wrote: ... > > + * bitmap_scatter() for the bitmap scatter detailed operations). > > > + * Suppose scattered computed using bitmap_scatter(scattered, src, mask, n). > > + * The operation bitmap_gather(result, scattered, mask, n) leads to a result > > + * equal or equivalent to src. > > This paragraph... > > > + * The result can be 'equivalent' because bitmap_scatter() and bitmap_gather() > > + * are not bijective. > > > > + * The result and src values are equivalent in that sense that a call to > > + * bitmap_scatter(res, src, mask, n) and a call to bitmap_scatter(res, result, > > + * mask, n) will lead to the same res value. > > ...seems duplicating this one. > > I would drop the latter one. I would like to give details about the 'equivalent' in this scatter/gather case. If Yury is ok, I can drop this last paragraph. Thanks for the review, Regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB15B153511; Thu, 22 Feb 2024 16:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708620606; cv=none; b=mxXqYwGuGI5Nb3hE0SY9qPvGNQpYw3k4nviHHvQzbEonN1p8FxvEDqY0vLlsE+lcgrez6VYsekrWSw2w62d4+ROzgGI5TpoEpaX+4DmLvCEhKD6w7opNTnwg+aXjMg6k0bWzdA8TgX0qcUPpQfUODKyXajcFMSJunoCXq+h6+S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708620606; c=relaxed/simple; bh=WQ8J/MZsH2vzEpVzHEOKc9Ad3stIDyGyoURkyC1Y3Sk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EMgh0M052CdW5t47Q2ZcncqkHHfO25KFQ/prs0CylRrG5905ACIpuxymv/TiHY9a3KiAwoByWwR4rXbWFND5QJEpDqmgfuDn1hWskvt3WjcFCiUwyWwMzWMSlIUPUYELILjESE2aZbChsPxvoLiaAm5IhFHERJm7Y0w39qoBdO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=nuYshMwG; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="nuYshMwG" Received: by mail.gandi.net (Postfix) with ESMTPSA id C41811BF205; Thu, 22 Feb 2024 16:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708620602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19qhGNmQmWm9BCOh8qUm/W3o9hKN/eZYOSKauiIFfoY=; b=nuYshMwGlMUB6NdNCDKR2k/WM9Ms7Q/xXxQMJvOyn6XcCUUOSkmbB7v4BphjOXQdRDq6ft 5Kk34TTJiC//w2a7g7aPDHRsI1rtsjvEap40y4W41OI+nFwV0cWOoMZpTupFan6qEpoN4d YDNERvNW5AVAsApFCmaWj6ph5QjpC1Kw6HH8GibCvreOmv66EswhaYlfXGCBqlQDVydlS4 Zou9Ox0rlcFLYDRZDNc8KA4dchaTfAQq9bvoBzRPyC2o/bCnG5fN+wg7wN293MsMvmlS4M Y4b6k6JA9ATcrLJo42BpLaQPA+KtE3Peq7SHjCvF9vf0K7rJhFvfZzLT/azi3g== Date: Thu, 22 Feb 2024 17:49:59 +0100 From: Herve Codina To: Andy Shevchenko Cc: Vadim Fedorenko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn , Mark Brown , Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v4 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Message-ID: <20240222174959.7097c29b@bootlin.com> In-Reply-To: References: <20240222142219.441767-1-herve.codina@bootlin.com> <20240222142219.441767-4-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Andy, Yury, On Thu, 22 Feb 2024 17:39:27 +0200 Andy Shevchenko wrote: ... > > + * bitmap_scatter() for the bitmap scatter detailed operations). > > > + * Suppose scattered computed using bitmap_scatter(scattered, src, mask, n). > > + * The operation bitmap_gather(result, scattered, mask, n) leads to a result > > + * equal or equivalent to src. > > This paragraph... > > > + * The result can be 'equivalent' because bitmap_scatter() and bitmap_gather() > > + * are not bijective. > > > > + * The result and src values are equivalent in that sense that a call to > > + * bitmap_scatter(res, src, mask, n) and a call to bitmap_scatter(res, result, > > + * mask, n) will lead to the same res value. > > ...seems duplicating this one. > > I would drop the latter one. I would like to give details about the 'equivalent' in this scatter/gather case. If Yury is ok, I can drop this last paragraph. Thanks for the review, Regards, Hervé