From: Jakub Kicinski <kuba@kernel.org>
To: Yanteng Si <siyanteng@loongson.cn>
Cc: andrew@lunn.ch, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, horms@kernel.org,
fancer.lancer@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: fix typo in comment
Date: Thu, 22 Feb 2024 19:12:20 -0800 [thread overview]
Message-ID: <20240222191220.0507a4de@kernel.org> (raw)
In-Reply-To: <20240221103514.968815-1-siyanteng@loongson.cn>
On Wed, 21 Feb 2024 18:35:14 +0800 Yanteng Si wrote:
> This is just a trivial fix for a typo in a comment, no functional
> changes.
>
> Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx")
Fixes is reserved for functional bugs, let's leave it out
for a typo correction.
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> index 358e7dcb6a9a..9d640ba5c323 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h
> @@ -92,7 +92,7 @@
> #define DMA_TBS_FTOV BIT(0)
> #define DMA_TBS_DEF_FTOS (DMA_TBS_FTOS | DMA_TBS_FTOV)
>
> -/* Following DMA defines are chanels oriented */
> +/* Following DMA defines are channels oriented */
I'm not a native speaker but I'd spell it "... are channel-oriented"
With a hyphen, channel not channels.
> #define DMA_CHAN_BASE_ADDR 0x00001100
> #define DMA_CHAN_BASE_OFFSET 0x80
>
next prev parent reply other threads:[~2024-02-23 3:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 10:35 [PATCH net-next] net: stmmac: fix typo in comment Yanteng Si
2024-02-21 12:33 ` Serge Semin
2024-02-23 3:12 ` Jakub Kicinski [this message]
2024-02-28 10:45 ` Yanteng Si
2024-02-28 11:19 ` Yanteng Si
-- strict thread matches above, loose matches on Subject: below --
2023-10-10 17:24 Johannes Zink
2023-10-10 17:24 ` Johannes Zink
2023-10-12 15:44 ` Simon Horman
2023-10-12 15:44 ` Simon Horman
2023-10-13 10:30 ` patchwork-bot+netdevbpf
2023-10-13 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222191220.0507a4de@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fancer.lancer@gmail.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.