From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E3A5C91B; Fri, 23 Feb 2024 10:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708684544; cv=none; b=EfcXe/XUijZ9TqWCtfXE8OYyIQ/wPGtpX+X6cxqbCXobG2bklsPM5w48pAZbSuW/pf3knIhX8E7xNSXdJQqjplQjefiu3od30V11CAYoWes1ArQpRsW4yqhBB30ZzF0yanWQ/hq3kO/1Y3OW6d7g+BThSjIaCdQ5vJzHB5oHEYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708684544; c=relaxed/simple; bh=ruwnsn/gjGehFv1nBJWx1lSoMV/uko91BIOgAziMm3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rlce9eXP0g2dSXDvuwxckbzomZTKc4stdqjVLcvPgRdvQX9yz6Ia7DynPhorn4iKPm3dU385kAILYYhEmhym//8lQREplJ6EfQ3Sy4oUmAFct+NUxq8WYQpM0OZRDFseb/ZpbGKTONxaIQWKc/i+vmmliw5y2fIFw1WZCZw7DQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RWgHoCDs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RWgHoCDs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1C69C433F1; Fri, 23 Feb 2024 10:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708684543; bh=ruwnsn/gjGehFv1nBJWx1lSoMV/uko91BIOgAziMm3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RWgHoCDsVInAwCNNN7dPCmlvFap+RO20ZKOlw5tytgf/6HhxKiXjXRWImhWH4zwH4 vzTPARKaSLya1nJMxTc3NfXVRQSgkd+uWgdiSeKp+i3IEsyAWavegkD2Nn0WFtefg0 KDoZGR/8YogeLYhEEJ98ZrF//2MX+GGKZ0y6LoazZzdZX2DXWHCoIXQD92qnARlSou Hom7au3sqBTdrrTwXo30O7GOKJkb5SuteMP8x+N1GTlKwaoKpDfxcRESRuBSUtF3Ph AuVlC3rc2dVnBYZp4TFtwnXgsSd1gY/lDdCp/yAg+zEVC/T1a+HfeRW8msjSLElkrz TrAjAOo9vBIYg== Date: Fri, 23 Feb 2024 10:35:37 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Aren Moynihan Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Message-ID: <20240223103537.GA1585387@google.com> References: <20240206185400.596979-1-aren@peacevolution.org> <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> On Fri, 23 Feb 2024, Lee Jones wrote: > On Tue, 06 Feb 2024 13:13:17 -0500, Aren Moynihan wrote: > > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we > > shouldn't need to set it here. This makes it possible to use multicolor > > groups with gpio leds that enable retain-state-suspended in the device > > tree. > > > > > > Applied, thanks! > > [1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend > commit: 68552911e71d59e62dd5e50e9ac56ebfc32f0c71 Note that I changed a bunch of grammatical issues. led => LED gpio => GPIO Capitalised the first word of the comment, etc. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00372C54E4A for ; Fri, 23 Feb 2024 10:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YHCVgus38BcLW93jzCxDuKvHsJ/5JfKEECZt87KGysQ=; b=jzrD6p1xT9sing zUXFq6wsljld03xXolaIF8g5jVe77QCNgzK8aREUpg/P41ICYSrs46XkCh9AiyTrTu2sIgkMMhf+P 4RKtOO3vwwmQjS7jDvE1FjUGPgDZk4c3ixEtpw07nCzOH4fza9BSEKx21QBJAWwYdw5BbXV9rjwYx gF/vHxR2khn/KqKYElpXn5Dl/5fcZSGsKsKzLleQekOykt3w4IJ11yeNRSUZlp1a+gH5ZzR8HHqjN dnDjPvs8VpbEFdiIvG0Aq18VPJGZevy6CKgxogZ55gb6RsUIzHOCOm0Q2LNyGjCVXgsdRkPRKrM0Y 7ht/SwKzvxO+gmeUZHkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdSvh-00000008yTE-1VoD; Fri, 23 Feb 2024 10:37:22 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdSuA-00000008y9g-12Re for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 10:35:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 823E6CE225D; Fri, 23 Feb 2024 10:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1C69C433F1; Fri, 23 Feb 2024 10:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708684543; bh=ruwnsn/gjGehFv1nBJWx1lSoMV/uko91BIOgAziMm3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RWgHoCDsVInAwCNNN7dPCmlvFap+RO20ZKOlw5tytgf/6HhxKiXjXRWImhWH4zwH4 vzTPARKaSLya1nJMxTc3NfXVRQSgkd+uWgdiSeKp+i3IEsyAWavegkD2Nn0WFtefg0 KDoZGR/8YogeLYhEEJ98ZrF//2MX+GGKZ0y6LoazZzdZX2DXWHCoIXQD92qnARlSou Hom7au3sqBTdrrTwXo30O7GOKJkb5SuteMP8x+N1GTlKwaoKpDfxcRESRuBSUtF3Ph AuVlC3rc2dVnBYZp4TFtwnXgsSd1gY/lDdCp/yAg+zEVC/T1a+HfeRW8msjSLElkrz TrAjAOo9vBIYg== Date: Fri, 23 Feb 2024 10:35:37 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Aren Moynihan Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Jean-Jacques Hiblot , Chen-Yu Tsai , Ondrej Jirman , linux-sunxi@lists.linux.dev, Pavel Machek , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , linux-leds@vger.kernel.org, Conor Dooley , Miles Alan , Samuel Holland Subject: Re: (subset) [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Message-ID: <20240223103537.GA1585387@google.com> References: <20240206185400.596979-1-aren@peacevolution.org> <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <170868429025.1582603.10651778411484887304.b4-ty@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_023546_768830_CD3351B6 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMyBGZWIgMjAyNCwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBUdWUsIDA2IEZlYiAy MDI0IDEzOjEzOjE3IC0wNTAwLCBBcmVuIE1veW5paGFuIHdyb3RlOgo+ID4gSWYgbm9uZSBvZiB0 aGUgbWFuYWdlZCBsZWRzIGVuYWJsZSBMRURfQ09SRV9TVVNQRU5EUkVTVU1FLCB0aGVuIHdlCj4g PiBzaG91bGRuJ3QgbmVlZCB0byBzZXQgaXQgaGVyZS4gVGhpcyBtYWtlcyBpdCBwb3NzaWJsZSB0 byB1c2UgbXVsdGljb2xvcgo+ID4gZ3JvdXBzIHdpdGggZ3BpbyBsZWRzIHRoYXQgZW5hYmxlIHJl dGFpbi1zdGF0ZS1zdXNwZW5kZWQgaW4gdGhlIGRldmljZQo+ID4gdHJlZS4KPiA+IAo+ID4gCj4g Cj4gQXBwbGllZCwgdGhhbmtzIQo+IAo+IFsxLzRdIGxlZHM6IHJnYjogbGVkcy1ncm91cC1tdWx0 aWNvbG9yOiBhbGxvdyBsZWRzIHRvIHN0YXkgb24gaW4gc3VzcGVuZAo+ICAgICAgIGNvbW1pdDog Njg1NTI5MTFlNzFkNTllNjJkZDVlNTBlOWFjNTZlYmZjMzJmMGM3MQoKTm90ZSB0aGF0IEkgY2hh bmdlZCBhIGJ1bmNoIG9mIGdyYW1tYXRpY2FsIGlzc3Vlcy4KCmxlZCAgPT4gTEVECmdwaW8gPT4g R1BJTwoKQ2FwaXRhbGlzZWQgdGhlIGZpcnN0IHdvcmQgb2YgdGhlIGNvbW1lbnQsIGV0Yy4KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK