From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ACBBC84A50; Fri, 23 Feb 2024 16:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708704198; cv=none; b=uQyAaBSPR3Uza52jzlOWlnX6fPVd8mrDUoagyZGhrvTaE4qj6lVsTQGhwuPxTFJ9YgEVAvV7Y/nbsZsj0X9tHejuw1FygNVEPMKzu3ZYFBNE66Bslr1PGFQu/by0RF1dBKZfV1lrNmhl114aIjZoiZEwfO3ZL4sM9VF7IDgngB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708704198; c=relaxed/simple; bh=2QxYsbtNpv6jtUv2wxx1Te6piZjhjrREIDgL6Jx6xkg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Iwl48BtNYOpBHcvl5/cuhzZ5CZqsmAnoamRHJi0uRCZ8BbnxEE8OuPrQ1ec3YFHSrtlGPsyOFllfuvo3aPPKj58H8wCEhcSO/Yn/unAsGI1AauJCG6N099qgQeyYHtr/L+N763rrhMOzWU258RW+9XbuTDtm+kThYnXW8YWo8Gk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51D28DA7; Fri, 23 Feb 2024 08:03:42 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DD453F762; Fri, 23 Feb 2024 08:03:01 -0800 (PST) Date: Fri, 23 Feb 2024 16:02:58 +0000 From: Andre Przywara To: Daniel Lezcano Cc: Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Samuel Holland , "Rafael J . Wysocki" , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Botka , Maksim Kiselev , Bob McChesney , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v5 1/7] soc: sunxi: sram: export register 0 for THS on H616 Message-ID: <20240223160258.504a1577@donnerap.manchester.arm.com> In-Reply-To: References: <20240219153639.179814-1-andre.przywara@arm.com> <20240219153639.179814-2-andre.przywara@arm.com> <2717467.mvXUDI8C0e@jernej-laptop> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 22 Feb 2024 19:44:12 +0100 Daniel Lezcano wrote: Hi Daniel, > On 22/02/2024 19:26, Jernej =C5=A0krabec wrote: > > Dne ponedeljek, 19. februar 2024 ob 16:36:33 CET je Andre Przywara napi= sal(a): =20 > >> The Allwinner H616 SoC contains a mysterious bit at register offset 0x0 > >> in the SRAM control block. If bit 16 is set (the reset value), the > >> temperature readings of the THS are way off, leading to reports about > >> 200C, at normal ambient temperatures. Clearing this bits brings the > >> reported values down to the expected values. > >> The BSP code clears this bit in firmware (U-Boot), and has an explicit > >> comment about this, but offers no real explanation. > >> > >> Experiments in U-Boot show that register 0x0 has no effect on the SRAM= C > >> visibility: all tested bit settings still allow full read and write > >> access by the CPU to the whole of SRAM C. Only bit 24 of the register = at > >> offset 0x4 makes all of SRAM C inaccessible by the CPU. So modelling > >> the THS switch functionality as an SRAM region would not reflect reali= ty. > >> > >> Since we should not rely on firmware settings, allow other code (the T= HS > >> driver) to access this register, by exporting it through the already > >> existing regmap. This mimics what we already do for the LDO control and > >> the EMAC register. > >> > >> To avoid concurrent accesses to the same register at the same time, by > >> the SRAM switch code and the regmap code, use the same lock to protect > >> the access. The regmap subsystem allows to use an existing lock, so we > >> just need to hook in there. > >> > >> Signed-off-by: Andre Przywara =20 > >=20 > > Reviewed-by: Jernej Skrabec > >=20 > > I guess this one goes through sunxi tree, right? =20 >=20 > I'll pick this patch along with the patch 2-6, so through the thermal=20 > tree. The patch 7/7 will go indeed via the sunxi tree many thanks for picking those up! I see them in your bleeding-edge branch, but are they on route for 6.9, so will you put them in -next soon? Or are you waiting for more ACKs? Cheers, Andre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC280C54798 for ; Fri, 23 Feb 2024 16:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I1HiuGo+D1s27IRaEvmQNjzAVxUgPiERkcjofVhggvQ=; b=LxZm8SDUHKXT5M tZVq4gVpMSlyeyF4XGwYyOBMJ/faVSYj5+tpdeKKF34iANBYz3BsZ10cV0cY/n5BREAt5LZ/Fz67U QmqPmKBuRF92Fsb5SYzfERPmwYFbJj9okzT287vCyT4RH3oUi1vseiYXwX8sgrLKuY7mLezqfTrVQ CrwT+XMfJI0ZKdPQwyhODbmtV9QxHK4fC6EM060zps5Iz6E1kHp8feseiMUhHpEWSbuX3vbKjm4hP +A3H98yylGhpPeTzSgNSOCAVmN3C25Bxp+2+K5dXYPzrFKO4Sxos+6Z2MHTR3q+6o4ALvK7Pqqtsq 7/PyFKX+mD2VUuaUOaLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdY1M-0000000A7UP-17t8; Fri, 23 Feb 2024 16:03:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdY0x-0000000A7KN-3kVH for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 16:03:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51D28DA7; Fri, 23 Feb 2024 08:03:42 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DD453F762; Fri, 23 Feb 2024 08:03:01 -0800 (PST) Date: Fri, 23 Feb 2024 16:02:58 +0000 From: Andre Przywara To: Daniel Lezcano Cc: Jernej =?UTF-8?B?xaBrcmFiZWM=?= , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Samuel Holland , "Rafael J . Wysocki" , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Botka , Maksim Kiselev , Bob McChesney , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v5 1/7] soc: sunxi: sram: export register 0 for THS on H616 Message-ID: <20240223160258.504a1577@donnerap.manchester.arm.com> In-Reply-To: References: <20240219153639.179814-1-andre.przywara@arm.com> <20240219153639.179814-2-andre.przywara@arm.com> <2717467.mvXUDI8C0e@jernej-laptop> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_080308_091483_A93CD663 X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMiBGZWIgMjAyNCAxOTo0NDoxMiArMDEwMApEYW5pZWwgTGV6Y2FubyA8ZGFuaWVs LmxlemNhbm9AbGluYXJvLm9yZz4gd3JvdGU6CgpIaSBEYW5pZWwsCgo+IE9uIDIyLzAyLzIwMjQg MTk6MjYsIEplcm5laiDFoGtyYWJlYyB3cm90ZToKPiA+IERuZSBwb25lZGVsamVrLCAxOS4gZmVi cnVhciAyMDI0IG9iIDE2OjM2OjMzIENFVCBqZSBBbmRyZSBQcnp5d2FyYSBuYXBpc2FsKGEpOiAg Cj4gPj4gVGhlIEFsbHdpbm5lciBINjE2IFNvQyBjb250YWlucyBhIG15c3RlcmlvdXMgYml0IGF0 IHJlZ2lzdGVyIG9mZnNldCAweDAKPiA+PiBpbiB0aGUgU1JBTSBjb250cm9sIGJsb2NrLiBJZiBi aXQgMTYgaXMgc2V0ICh0aGUgcmVzZXQgdmFsdWUpLCB0aGUKPiA+PiB0ZW1wZXJhdHVyZSByZWFk aW5ncyBvZiB0aGUgVEhTIGFyZSB3YXkgb2ZmLCBsZWFkaW5nIHRvIHJlcG9ydHMgYWJvdXQKPiA+ PiAyMDBDLCBhdCBub3JtYWwgYW1iaWVudCB0ZW1wZXJhdHVyZXMuIENsZWFyaW5nIHRoaXMgYml0 cyBicmluZ3MgdGhlCj4gPj4gcmVwb3J0ZWQgdmFsdWVzIGRvd24gdG8gdGhlIGV4cGVjdGVkIHZh bHVlcy4KPiA+PiBUaGUgQlNQIGNvZGUgY2xlYXJzIHRoaXMgYml0IGluIGZpcm13YXJlIChVLUJv b3QpLCBhbmQgaGFzIGFuIGV4cGxpY2l0Cj4gPj4gY29tbWVudCBhYm91dCB0aGlzLCBidXQgb2Zm ZXJzIG5vIHJlYWwgZXhwbGFuYXRpb24uCj4gPj4KPiA+PiBFeHBlcmltZW50cyBpbiBVLUJvb3Qg c2hvdyB0aGF0IHJlZ2lzdGVyIDB4MCBoYXMgbm8gZWZmZWN0IG9uIHRoZSBTUkFNIEMKPiA+PiB2 aXNpYmlsaXR5OiBhbGwgdGVzdGVkIGJpdCBzZXR0aW5ncyBzdGlsbCBhbGxvdyBmdWxsIHJlYWQg YW5kIHdyaXRlCj4gPj4gYWNjZXNzIGJ5IHRoZSBDUFUgdG8gdGhlIHdob2xlIG9mIFNSQU0gQy4g T25seSBiaXQgMjQgb2YgdGhlIHJlZ2lzdGVyIGF0Cj4gPj4gb2Zmc2V0IDB4NCBtYWtlcyBhbGwg b2YgU1JBTSBDIGluYWNjZXNzaWJsZSBieSB0aGUgQ1BVLiBTbyBtb2RlbGxpbmcKPiA+PiB0aGUg VEhTIHN3aXRjaCBmdW5jdGlvbmFsaXR5IGFzIGFuIFNSQU0gcmVnaW9uIHdvdWxkIG5vdCByZWZs ZWN0IHJlYWxpdHkuCj4gPj4KPiA+PiBTaW5jZSB3ZSBzaG91bGQgbm90IHJlbHkgb24gZmlybXdh cmUgc2V0dGluZ3MsIGFsbG93IG90aGVyIGNvZGUgKHRoZSBUSFMKPiA+PiBkcml2ZXIpIHRvIGFj Y2VzcyB0aGlzIHJlZ2lzdGVyLCBieSBleHBvcnRpbmcgaXQgdGhyb3VnaCB0aGUgYWxyZWFkeQo+ ID4+IGV4aXN0aW5nIHJlZ21hcC4gVGhpcyBtaW1pY3Mgd2hhdCB3ZSBhbHJlYWR5IGRvIGZvciB0 aGUgTERPIGNvbnRyb2wgYW5kCj4gPj4gdGhlIEVNQUMgcmVnaXN0ZXIuCj4gPj4KPiA+PiBUbyBh dm9pZCBjb25jdXJyZW50IGFjY2Vzc2VzIHRvIHRoZSBzYW1lIHJlZ2lzdGVyIGF0IHRoZSBzYW1l IHRpbWUsIGJ5Cj4gPj4gdGhlIFNSQU0gc3dpdGNoIGNvZGUgYW5kIHRoZSByZWdtYXAgY29kZSwg dXNlIHRoZSBzYW1lIGxvY2sgdG8gcHJvdGVjdAo+ID4+IHRoZSBhY2Nlc3MuIFRoZSByZWdtYXAg c3Vic3lzdGVtIGFsbG93cyB0byB1c2UgYW4gZXhpc3RpbmcgbG9jaywgc28gd2UKPiA+PiBqdXN0 IG5lZWQgdG8gaG9vayBpbiB0aGVyZS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFuZHJlIFBy enl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPiAgCj4gPiAKPiA+IFJldmlld2VkLWJ5OiBK ZXJuZWogU2tyYWJlYyA8amVybmVqLnNrcmFiZWNAZ21haWwuY29tPgo+ID4gCj4gPiBJIGd1ZXNz IHRoaXMgb25lIGdvZXMgdGhyb3VnaCBzdW54aSB0cmVlLCByaWdodD8gIAo+IAo+IEknbGwgcGlj ayB0aGlzIHBhdGNoIGFsb25nIHdpdGggdGhlIHBhdGNoIDItNiwgc28gdGhyb3VnaCB0aGUgdGhl cm1hbCAKPiB0cmVlLiBUaGUgcGF0Y2ggNy83IHdpbGwgZ28gaW5kZWVkIHZpYSB0aGUgc3VueGkg dHJlZQoKbWFueSB0aGFua3MgZm9yIHBpY2tpbmcgdGhvc2UgdXAhIEkgc2VlIHRoZW0gaW4geW91 ciBibGVlZGluZy1lZGdlIGJyYW5jaCwKYnV0IGFyZSB0aGV5IG9uIHJvdXRlIGZvciA2LjksIHNv IHdpbGwgeW91IHB1dCB0aGVtIGluIC1uZXh0IHNvb24/IE9yIGFyZQp5b3Ugd2FpdGluZyBmb3Ig bW9yZSBBQ0tzPwoKQ2hlZXJzLApBbmRyZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=