From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wander Lairson Costa <wander@redhat.com>,
Yan Zhai <yan@cloudflare.com>
Subject: Re: [PATCH v2 net-next 3/3] net: Use backlog-NAPI to clean up the defer_list.
Date: Fri, 23 Feb 2024 18:02:57 -0800 [thread overview]
Message-ID: <20240223180257.5d828020@kernel.org> (raw)
In-Reply-To: <20240221172032.78737-4-bigeasy@linutronix.de>
On Wed, 21 Feb 2024 18:00:13 +0100 Sebastian Andrzej Siewior wrote:
> + if (use_backlog_threads()) {
> + rps_lock_irqsave(sd, &flags);
> +
> + if (!__test_and_set_bit(NAPI_STATE_SCHED, &sd->backlog.state))
> + napi_schedule_rps(sd);
Why are you calling napi_schedule_rps() here?
Just do __napi_schedule_irqoff(&sd->backlog);
Then you can move the special case inside napi_schedule_rps()
into the if (sd != mysd) block.
> + rps_unlock_irq_restore(sd, &flags);
Also not sure if the lock helpers should still be called RPS since they
also protect state on non-RPS configs now.
next prev parent reply other threads:[~2024-02-24 2:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 17:00 [PATCH v2 net-next 0/3] net: Provide SMP threads for backlog NAPI Sebastian Andrzej Siewior
2024-02-21 17:00 ` [PATCH v2 net-next 1/3] net: Remove conditional threaded-NAPI wakeup based on task state Sebastian Andrzej Siewior
2024-02-21 17:00 ` [PATCH v2 net-next 2/3] net: Allow to use SMP threads for backlog NAPI Sebastian Andrzej Siewior
2024-02-21 17:00 ` [PATCH v2 net-next 3/3] net: Use backlog-NAPI to clean up the defer_list Sebastian Andrzej Siewior
2024-02-24 2:02 ` Jakub Kicinski [this message]
2024-02-26 11:59 ` Sebastian Andrzej Siewior
2024-02-27 1:22 ` Jakub Kicinski
2024-02-27 7:27 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223180257.5d828020@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.