From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Subject: [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers
Date: Fri, 23 Feb 2024 22:30:00 +0200 [thread overview]
Message-ID: <20240223203010.881065-1-andriy.shevchenko@linux.intel.com> (raw)
Update header inclusions to follow IWYU (Include What You Use)
principle.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: added one more missing header
drivers/leds/leds-expresswire.c | 4 ++++
include/linux/leds-expresswire.h | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-expresswire.c b/drivers/leds/leds-expresswire.c
index 89e147b0e019..e4937a8e0f44 100644
--- a/drivers/leds/leds-expresswire.c
+++ b/drivers/leds/leds-expresswire.c
@@ -5,8 +5,12 @@
* ktd2692 and ktd2801 are known to use this protocol.
*/
+#include <linux/bits.h>
#include <linux/delay.h>
+#include <linux/export.h>
#include <linux/gpio/consumer.h>
+#include <linux/types.h>
+
#include <linux/leds-expresswire.h>
void expresswire_power_off(struct expresswire_common_props *props)
diff --git a/include/linux/leds-expresswire.h b/include/linux/leds-expresswire.h
index 3c61902ccac8..a422921f4159 100644
--- a/include/linux/leds-expresswire.h
+++ b/include/linux/leds-expresswire.h
@@ -8,7 +8,9 @@
#ifndef _LEDS_EXPRESSWIRE_H
#define _LEDS_EXPRESSWIRE_H
-#include <linux/gpio/consumer.h>
+#include <linux/types.h>
+
+struct gpio_desc;
struct expresswire_timing {
unsigned long poweroff_us;
--
2.43.0.rc1.1.gbec44491f096
next reply other threads:[~2024-02-23 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 20:30 Andy Shevchenko [this message]
2024-02-23 20:56 ` [PATCH v2 1/1] leds: expresswire: Don't use "proxy" headers Pavel Machek
2024-02-24 15:31 ` Duje Mihanović
2024-02-26 14:27 ` Andy Shevchenko
2024-02-26 14:34 ` Andy Shevchenko
2024-02-24 16:02 ` Duje Mihanović
2024-02-26 14:34 ` Andy Shevchenko
2024-02-29 17:22 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223203010.881065-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=duje.mihanovic@skole.hr \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.