From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8766B5B1F4 for ; Fri, 23 Feb 2024 14:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708699698; cv=none; b=J5PGWu6mXUdnG//xEJrvIcz64E+FU9xE/Uoj5PFcijIjFOxaGrGJ2XLtEtIGbQ5d3QrJj794qaYvLitxhFWOO3DL/DhfpYt4NLDIi6+0Ba+sUa7t1DUORdvoJx5USOfu/hpvVCUe+Lw19W776vnsbSesd875VcsvzyQM1mZSlOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708699698; c=relaxed/simple; bh=dl1DLEmN0pwvH2jtL7aaVhn59/ShMiGczluxdPUvrP4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DSHJCnj7C3P5Ar+w7Y5ieYkks9HtIfapPEd6FQmjjMou7P4gG9ebsILitdjBSRmXdUlEjApbwpVNRsXHe0Mjx6i10W4LLYw+JOkfBkBcyaA8bPvySkLwiU7ttQWyXUYfOHil4YCV53g0Rohl2D3ycQRTxtPqS9SqnACtjQMLs9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=viZJt5kb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="viZJt5kb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEC1DC43399; Fri, 23 Feb 2024 14:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708699698; bh=dl1DLEmN0pwvH2jtL7aaVhn59/ShMiGczluxdPUvrP4=; h=From:To:Cc:Subject:Date:Reply-to:From; b=viZJt5kbgK1ncXjyR556xJTMjr2AzfKzC7NCkO+zu0jqqZnyXNEEZXp6sEOftGgB7 upi96JQ0gMxBlBNp022ReR7TM/GAEvfWx5OInnVsz3S23NXKF2sIm8K3p8DAdgvLEW BDvmRrGN9R4vPoxvWWZsjWt1p+Dp6z6nePHKNurU= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-26597: net: qualcomm: rmnet: fix global oob in rmnet_policy Date: Fri, 23 Feb 2024 15:47:38 +0100 Message-ID: <2024022337-CVE-2024-26597-be75@gregkh> X-Mailer: git-send-email 2.43.2 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=6292; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=dl1DLEmN0pwvH2jtL7aaVhn59/ShMiGczluxdPUvrP4=; b=owGbwMvMwCRo6H6F97bub03G02pJDKk3NnAe8lwywc/rPvPjf8nnzryamTZldktoWWLe+0dV/ qXFVgffdMSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBEHmxmmJ9k2Zt6Y2Xdtz1Z Vp9Z0nsUGS/XTWBY0LmLTaTab0qynbXqTi9zBe9HX682AQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: net: qualcomm: rmnet: fix global oob in rmnet_policy The variable rmnet_link_ops assign a *bigger* maxtype which leads to a global out-of-bounds read when parsing the netlink attributes. See bug trace below: ================================================================== BUG: KASAN: global-out-of-bounds in validate_nla lib/nlattr.c:386 [inline] BUG: KASAN: global-out-of-bounds in __nla_validate_parse+0x24af/0x2750 lib/nlattr.c:600 Read of size 1 at addr ffffffff92c438d0 by task syz-executor.6/84207 CPU: 0 PID: 84207 Comm: syz-executor.6 Tainted: G N 6.1.0 #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x8b/0xb3 lib/dump_stack.c:106 print_address_description mm/kasan/report.c:284 [inline] print_report+0x172/0x475 mm/kasan/report.c:395 kasan_report+0xbb/0x1c0 mm/kasan/report.c:495 validate_nla lib/nlattr.c:386 [inline] __nla_validate_parse+0x24af/0x2750 lib/nlattr.c:600 __nla_parse+0x3e/0x50 lib/nlattr.c:697 nla_parse_nested_deprecated include/net/netlink.h:1248 [inline] __rtnl_newlink+0x50a/0x1880 net/core/rtnetlink.c:3485 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3594 rtnetlink_rcv_msg+0x43c/0xd70 net/core/rtnetlink.c:6091 netlink_rcv_skb+0x14f/0x410 net/netlink/af_netlink.c:2540 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x54e/0x800 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x930/0xe50 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0x154/0x190 net/socket.c:734 ____sys_sendmsg+0x6df/0x840 net/socket.c:2482 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2536 __sys_sendmsg+0xf3/0x1c0 net/socket.c:2565 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0x90 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fdcf2072359 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdcf13e3168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fdcf219ff80 RCX: 00007fdcf2072359 RDX: 0000000000000000 RSI: 0000000020000200 RDI: 0000000000000003 RBP: 00007fdcf20bd493 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fffbb8d7bdf R14: 00007fdcf13e3300 R15: 0000000000022000 The buggy address belongs to the variable: rmnet_policy+0x30/0xe0 The buggy address belongs to the physical page: page:0000000065bdeb3c refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x155243 flags: 0x200000000001000(reserved|node=0|zone=2) raw: 0200000000001000 ffffea00055490c8 ffffea00055490c8 0000000000000000 raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 page dumped because: kasan: bad access detected Memory state around the buggy address: ffffffff92c43780: f9 f9 f9 f9 00 00 00 02 f9 f9 f9 f9 00 00 00 07 ffffffff92c43800: f9 f9 f9 f9 00 00 00 05 f9 f9 f9 f9 06 f9 f9 f9 >ffffffff92c43880: f9 f9 f9 f9 00 00 00 00 00 00 f9 f9 f9 f9 f9 f9 ^ ffffffff92c43900: 00 00 00 00 00 00 00 00 07 f9 f9 f9 f9 f9 f9 f9 ffffffff92c43980: 00 00 00 07 f9 f9 f9 f9 00 00 00 05 f9 f9 f9 f9 According to the comment of `nla_parse_nested_deprecated`, the maxtype should be len(destination array) - 1. Hence use `IFLA_RMNET_MAX` here. The Linux kernel CVE team has assigned CVE-2024-26597 to this issue. Affected and fixed versions =========================== Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 4.19.306 with commit 093dab655808 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 5.4.268 with commit 02467ab8b404 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 5.10.209 with commit 2295c22348fa Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 5.15.148 with commit 3b5254862258 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 6.1.75 with commit ee1dc3bf86f2 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 6.6.14 with commit c47345350346 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 6.7.2 with commit 17d06a5c44d8 Issue introduced in 4.17 with commit 14452ca3b5ce and fixed in 6.8-rc1 with commit b33fb5b801c6 Please see https://www.kernel.org or a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-26597 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/093dab655808207f7a9f54cf156240aeafc70590 https://git.kernel.org/stable/c/02467ab8b404d80429107588e0f3425cf5fcd2e5 https://git.kernel.org/stable/c/2295c22348faf795e1ccdf618f6eb7afdb2f7447 https://git.kernel.org/stable/c/3b5254862258b595662a0ccca6e9eeb88d6e7468 https://git.kernel.org/stable/c/ee1dc3bf86f2df777038506b139371a9add02534 https://git.kernel.org/stable/c/c4734535034672f59f2652e1e0058c490da62a5c https://git.kernel.org/stable/c/17d06a5c44d8fd2e8e61bac295b09153496f87e1 https://git.kernel.org/stable/c/b33fb5b801c6db408b774a68e7c8722796b59ecc