All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
	luiz.dentz@gmail.com, johan@kernel.org, jirislaby@kernel.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	tomi.valkeinen@ideasonboard.com,
	"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
	robh@kernel.org, hns@goldelico.com
Subject: Re: [RFC PATCH v2 3/3] gnss: Add driver for AI2 protocol
Date: Sun, 25 Feb 2024 23:16:47 +0100	[thread overview]
Message-ID: <20240225231647.3abdf378@aktux> (raw)
In-Reply-To: <1cc869a6-8547-4c5b-b39d-10f4a3e11dff@molgen.mpg.de>

Hi Paul,

I have left out one thing to answer.

On Mon, 29 Jan 2024 08:53:27 +0100
Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> > +	ret = ai2_send_frame(ai2dev, skb);
> > +	if (ret)
> > +		return ret;
> > +
> > +	msleep(200);  
> 
> I’d be great if you added a comment, why this long delay is needed.

Well, I am just a bit paranoid, s/msleep/wait_for_completion_timeout/ and
complete() on some ack would probably improve this. I just hesitated to add
something like this until I have the feeling that I do not need to turn the
driver upside-down.

Regards,
Andreas

  parent reply	other threads:[~2024-02-25 22:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 17:33 [RFC PATCH v2 0/3] bluetooth/gnss: GNSS support for TiWi chips Andreas Kemnade
2024-01-28 17:33 ` [RFC PATCH v2 1/3] gnss: Add AI2 protocol used by some TI combo chips Andreas Kemnade
2024-01-28 18:33   ` bluetooth/gnss: GNSS support for TiWi chips bluez.test.bot
2024-01-29  7:40   ` [RFC PATCH v2 1/3] gnss: Add AI2 protocol used by some TI combo chips Paul Menzel
2024-01-29 20:34     ` Andreas Kemnade
2024-01-28 17:33 ` [RFC PATCH v2 2/3] bluetooth: ti-st: Add GNSS subdevice for TI Wilink chips Andreas Kemnade
2024-01-29  7:40   ` Paul Menzel
2024-01-28 17:33 ` [RFC PATCH v2 3/3] gnss: Add driver for AI2 protocol Andreas Kemnade
2024-01-29  7:53   ` Paul Menzel
2024-01-29 20:53     ` Andreas Kemnade
2024-02-25 22:16     ` Andreas Kemnade [this message]
2024-02-13 13:57   ` Adam Ford
2024-02-13 19:20     ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240225231647.3abdf378@aktux \
    --to=andreas@kemnade.info \
    --cc=aford173@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hns@goldelico.com \
    --cc=jirislaby@kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=robh@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.