From: Christian Brauner <brauner@kernel.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Arnd Bergmann <arnd@arndb.de>, Icenowy Zheng <uwu@icenowy.me>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Rich Felker <dalias@aerifal.cx>,
linux-api@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Xuefeng Li <lixuefeng@loongson.cn>,
Jianmin Lv <lvjianmin@loongson.cn>,
Xiaotian Wu <wuxiaotian@loongson.cn>,
WANG Rui <wangrui@loongson.cn>,
Miao Wang <shankerwangmiao@gmail.com>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Chromium sandbox on LoongArch and statx -- seccomp deep argument inspection again?
Date: Mon, 26 Feb 2024 13:57:55 +0100 [thread overview]
Message-ID: <20240226-siegen-desolat-49d1e20ba2cd@brauner> (raw)
In-Reply-To: <6bf460d17b9f44326497ffb41e03363b112d6927.camel@xry111.site>
On Mon, Feb 26, 2024 at 07:57:56PM +0800, Xi Ruoyao wrote:
> On Mon, 2024-02-26 at 10:20 +0100, Arnd Bergmann wrote:
>
> /* snip */
>
> >
> > > Or maybe we can just introduce a new AT_something to make statx
> > > completely ignore pathname but behave like AT_EMPTY_PATH + "".
I'm not at all convinced about doing custom semantics for this.
> > I think this is better than going back to fstat64_time64(), but
> > it's still not great because
> >
> > - all the reserved flags on statx() are by definition incompatible
> > with existing kernels that return -EINVAL for any flag they do
> > not recognize.
>
> Oops, we are deeming passing undefined flags in "mask" undefined
> behavior but not "flags", thus "wild software" may be relying on EINVAL
> for invalid flags... We *might* make this new AT_xxx a bit in mask
> instead of flags but it would be very dirty IMO.
Uhm, no. AT_* flags have nothing to do in statx()'s mask argument at all.
next prev parent reply other threads:[~2024-02-26 12:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 6:09 Chromium sandbox on LoongArch and statx -- seccomp deep argument inspection again? WANG Xuerui
2024-02-21 6:31 ` Xi Ruoyao
2024-02-21 10:31 ` Xi Ruoyao
2024-02-21 10:49 ` WANG Xuerui
2024-02-21 12:03 ` Xi Ruoyao
2024-02-24 11:51 ` Huacai Chen
2024-02-25 6:51 ` Icenowy Zheng
2024-02-25 7:32 ` Xi Ruoyao
2024-02-26 6:03 ` Icenowy Zheng
2024-02-26 6:56 ` Arnd Bergmann
2024-02-26 7:09 ` Xi Ruoyao
2024-02-26 9:20 ` Arnd Bergmann
2024-02-26 11:57 ` Xi Ruoyao
2024-02-26 12:57 ` Christian Brauner [this message]
2024-02-26 14:33 ` Rich Felker
2024-02-26 13:32 ` Christian Brauner
2024-02-26 13:46 ` Arnd Bergmann
2024-02-26 15:40 ` Christian Brauner
2024-02-26 16:49 ` Xi Ruoyao
2024-02-26 13:46 ` Christian Brauner
2024-02-26 14:00 ` WANG Xuerui
2024-02-26 15:35 ` Christian Brauner
2024-02-26 17:38 ` WANG Xuerui
2024-02-26 8:26 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226-siegen-desolat-49d1e20ba2cd@brauner \
--to=brauner@kernel.org \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=dalias@aerifal.cx \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=shankerwangmiao@gmail.com \
--cc=uwu@icenowy.me \
--cc=wangrui@loongson.cn \
--cc=wuxiaotian@loongson.cn \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.