From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH] nvme: add 'static' suffix for user-specified TLS keys
Date: Mon, 26 Feb 2024 13:24:49 +0100 [thread overview]
Message-ID: <20240226122449.46976-1-hare@kernel.org> (raw)
From: Hannes Reinecke <hare@suse.de>
If the user specifies a specific TLS key via the '--tls_key'
option to nvme-cli we should be adding a ';static' suffix
to the 'tls_key' sysfs attribute to signal that this is a
user-specific key, and not one auto-selected during TLS
protocol negotiation.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/sysfs.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index d099218e494a..79f25029c2fb 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -674,10 +674,14 @@ static ssize_t tls_key_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
+ char *suffix = "";
if (!ctrl->tls_key)
return 0;
- return sysfs_emit(buf, "%08x", key_serial(ctrl->tls_key));
+ if (ctrl->opts->tls_key)
+ suffix = ";static";
+ return sysfs_emit(buf, "%08x%s",
+ key_serial(ctrl->tls_key), suffix);
}
static DEVICE_ATTR_RO(tls_key);
#endif
--
2.35.3
next reply other threads:[~2024-02-26 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 12:24 Hannes Reinecke [this message]
2024-02-26 16:35 ` [PATCH] nvme: add 'static' suffix for user-specified TLS keys Daniel Wagner
2024-02-27 7:09 ` Hannes Reinecke
2024-03-07 9:45 ` Sagi Grimberg
2024-03-07 10:47 ` Hannes Reinecke
2024-03-08 10:42 ` Sagi Grimberg
2024-03-08 12:11 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226122449.46976-1-hare@kernel.org \
--to=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.