All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Oded Gabbay" <ogabbay@kernel.org>
Subject: [PATCH 2/3] drm/xe/bo: Allow eviction of unbound local bos
Date: Mon, 26 Feb 2024 17:44:54 +0100	[thread overview]
Message-ID: <20240226164455.10179-3-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240226164455.10179-1-thomas.hellstrom@linux.intel.com>

Local bos that don't have any gpu_vmas set up are allowed
to be evicted. Support that.

Fixes: 24f947d58fe5 ("drm/xe: Use DRM GPUVM helpers for external- and evicted objects")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 143d93632253..2931b9030503 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1057,10 +1057,15 @@ static bool xe_bo_eviction_valuable(struct ttm_buffer_object *ttm_bo,
 		struct xe_vm *vm = xe_bo->vm;
 
 		if (vm && !drm_gpuvm_is_extobj(&vm->gpuvm, &ttm_bo->base) &&
-		    vm->is_validating)
+		    vm->is_validating) {
+			/* Not bound to the vm? */
+			if (list_empty(&ttm_bo->base.gpuva.list))
+				goto allow;
 			return false;
+		}
 	}
 
+allow:
 	return ttm_bo_eviction_valuable(ttm_bo, place);
 }
 
-- 
2.43.0


  parent reply	other threads:[~2024-02-26 16:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 16:44 [PATCH 0/3] drm/xe: VM Overcommit handling fixes Thomas Hellström
2024-02-26 16:44 ` [PATCH 1/3] drm/xe/bo: Forward the decision to evict local objects during validation Thomas Hellström
2024-02-26 21:36   ` Matthew Brost
2024-02-27 11:52     ` Thomas Hellström
2024-02-27 17:35       ` Matthew Brost
2024-02-26 16:44 ` Thomas Hellström [this message]
2024-02-26 21:42   ` [PATCH 2/3] drm/xe/bo: Allow eviction of unbound local bos Matthew Brost
2024-02-27 11:54     ` Thomas Hellström
2024-02-27 17:36       ` Matthew Brost
2024-02-26 16:44 ` [PATCH 3/3] drm/xe/bo: Allow migrating local bos to TT to make room in VRAM Thomas Hellström
2024-02-26 21:45   ` Matthew Brost
2024-02-26 18:18 ` ✓ CI.Patch_applied: success for drm/xe: VM Overcommit handling fixes Patchwork
2024-02-26 18:18 ` ✓ CI.checkpatch: " Patchwork
2024-02-26 18:19 ` ✓ CI.KUnit: " Patchwork
2024-02-26 18:30 ` ✓ CI.Build: " Patchwork
2024-02-26 18:31 ` ✓ CI.Hooks: " Patchwork
2024-02-26 18:32 ` ✓ CI.checksparse: " Patchwork
2024-02-26 19:10 ` ✓ CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226164455.10179-3-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=ogabbay@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.