From: Jakub Kicinski <kuba@kernel.org>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<pabeni@redhat.com>, <edumazet@google.com>, <davem@davemloft.net>,
<sbhatta@marvell.com>, <gakula@marvell.com>,
<sgoutham@marvell.com>
Subject: Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom information
Date: Mon, 26 Feb 2024 17:00:27 -0800 [thread overview]
Message-ID: <20240226170027.6a43f196@kernel.org> (raw)
In-Reply-To: <20240222171542.12995-1-hkelam@marvell.com>
On Thu, 22 Feb 2024 22:45:42 +0530 Hariprasad Kelam wrote:
> + if (!ee->len || ((ee->len + ee->offset) > SFP_EEPROM_SIZE))
> + return -EINVAL;
Are you sure there's a path thru the core to the driver which would
allow len == 0 or the size being larger than when info put in
eeprom_len?
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-27 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 17:15 [net-next PatchV2] octeontx2-pf: Add support to read eeprom information Hariprasad Kelam
2024-02-27 1:00 ` Jakub Kicinski [this message]
2024-02-27 7:36 ` Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226170027.6a43f196@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.