All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Richard Weinberger <richard@nod.at>,
	Zhang Yi <yi.zhang@huawei.com>
Subject: [linux-next:master 10011/10236] fs/ubifs/journal.c:369: warning: expecting prototype for wake_up_reservation(). Prototype was for add_or_start_queue() instead
Date: Mon, 26 Feb 2024 19:37:53 +0800	[thread overview]
Message-ID: <202402261912.yAxZePRG-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   8552c902efe7ef670b6961fb8885b67961aeb629
commit: 556c19f563b64dd5463b0030d19c8681f4f7446e [10011/10236] ubifs: Queue up space reservation tasks if retrying many times
config: i386-buildonly-randconfig-001-20240226 (https://download.01.org/0day-ci/archive/20240226/202402261912.yAxZePRG-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240226/202402261912.yAxZePRG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402261912.yAxZePRG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/ubifs/journal.c:369: warning: expecting prototype for wake_up_reservation(). Prototype was for add_or_start_queue() instead


vim +369 fs/ubifs/journal.c

   360	
   361	/**
   362	 * wake_up_reservation - add current task in queue or start queuing.
   363	 * @c: UBIFS file-system description object
   364	 *
   365	 * This function starts queuing if queuing is not started, otherwise adds
   366	 * current task in queue.
   367	 */
   368	static void add_or_start_queue(struct ubifs_info *c)
 > 369	{
   370		spin_lock(&c->reserve_space_wq.lock);
   371		if (atomic_cmpxchg(&c->need_wait_space, 0, 1) == 0) {
   372			/* Starts queuing, task can go on directly. */
   373			spin_unlock(&c->reserve_space_wq.lock);
   374			return;
   375		}
   376	
   377		/*
   378		 * There are at least two tasks have retried more than 32 times
   379		 * at certain point, first task has started queuing, just queue
   380		 * the left tasks.
   381		 */
   382		__queue_and_wait(c);
   383	}
   384	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-02-26 11:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402261912.yAxZePRG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=chengzhihao1@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=richard@nod.at \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.