All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: <dri-devel@lists.freedesktop.org>, <amd-gfx@lists.freedesktop.org>
Cc: <wayland-devel@lists.freedesktop.org>,
	Harry Wentland <harry.wentland@amd.com>
Subject: [RFC PATCH v4 26/42] drm/colorop: pass plane_color_pipeline client cap to atomic check
Date: Mon, 26 Feb 2024 16:10:40 -0500	[thread overview]
Message-ID: <20240226211100.100108-27-harry.wentland@amd.com> (raw)
In-Reply-To: <20240226211100.100108-1-harry.wentland@amd.com>

Drivers will need to know whether an atomic check/commit
originated from a client with DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE
so they can ignore deprecated properties, like COLOR_ENCODING
and COLOR_RANGE.

Pass the plane_color_pipeline bit to drm_atomic_state.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
 drivers/gpu/drm/drm_atomic_uapi.c |  1 +
 include/drm/drm_atomic.h          | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 23b248987a7c..c7c1c614b0d9 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1571,6 +1571,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,
 	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
 	state->acquire_ctx = &ctx;
 	state->allow_modeset = !!(arg->flags & DRM_MODE_ATOMIC_ALLOW_MODESET);
+	state->plane_color_pipeline = file_priv->plane_color_pipeline;
 
 retry:
 	copied_objs = 0;
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index 2346f19eda9f..61e6b5553eec 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -404,6 +404,23 @@ struct drm_atomic_state {
 	 * states.
 	 */
 	bool duplicated : 1;
+
+	/**
+	 * @plane_color_pipeline : 1
+	 *
+	 * Indicates whether this atomic state originated with a client that
+	 * set the DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE.
+	 *
+	 * Drivers and helper functions should use this to ignore legacy
+	 * properties that are incompatible with the drm_plane COLOR_PIPELINE
+	 * behavior, such as
+	 *  - COLOR_RANGE
+	 *  - COLOR_ENCODING
+	 * or any other driver-specific properties that might affect pixel
+	 * values.
+	 */
+	bool plane_color_pipeline : 1;
+
 	struct __drm_colorops_state *colorops;
 	struct __drm_planes_state *planes;
 	struct __drm_crtcs_state *crtcs;
-- 
2.44.0


  parent reply	other threads:[~2024-02-26 21:13 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 21:10 [RFC PATCH v4 00/42] Color Pipeline API w/ VKMS Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 01/42] drm: Don't treat 0 as -1 in drm_fixp2int_ceil Harry Wentland
2024-03-14 13:41   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 02/42] drm: Add helper for conversion from signed-magnitude Harry Wentland
2024-03-14 13:16   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 03/42] drm: Correctly round for fixp2int_round Harry Wentland
2024-03-11 13:11   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 04/42] drm/vkms: Round fixp2int conversion in lerp_u16 Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 05/42] drm/vkms: Create separate Kconfig file for VKMS Harry Wentland
2024-03-12 18:49   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 06/42] drm/vkms: Add kunit tests for VKMS LUT handling Harry Wentland
2024-02-27 12:14   ` Arthur Grillo
2024-02-27 14:09     ` Harry Wentland
2024-03-11 13:45   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 07/42] drm/vkms: Avoid reading beyond LUT array Harry Wentland
2024-03-12 18:54   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 08/42] drm/doc/rfc: Describe why prescriptive color pipeline is needed Harry Wentland
2024-03-11 15:11   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 09/42] drm/colorop: Introduce new drm_colorop mode object Harry Wentland
2024-05-21 15:28   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 10/42] drm/colorop: Add TYPE property Harry Wentland
2024-03-12 15:02   ` Pekka Paalanen
2024-03-12 15:15     ` Simon Ser
2024-03-12 15:55       ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 11/42] drm/colorop: Add 1D Curve subtype Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 12/42] drm/colorop: Add BYPASS property Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 13/42] drm/colorop: Add NEXT property Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 14/42] drm/colorop: Add atomic state print for drm_colorop Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 15/42] drm/plane: Add COLOR PIPELINE property Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 16/42] drm/colorop: Add NEXT to colorop state print Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 17/42] drm/vkms: Add enumerated 1D curve colorop Harry Wentland
2024-03-12 15:27   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 18/42] drm/vkms: Add kunit tests for linear and sRGB LUTs Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 19/42] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 20/42] drm/colorop: Add 3x4 CTM type Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 21/42] drm/vkms: Pull apply_colorop out of pre_blend_color_transform Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 22/42] drm/vkms: Use s32 for internal color pipeline precision Harry Wentland
2024-03-12 15:50   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 23/42] drm/vkms: add 3x4 matrix in color pipeline Harry Wentland
2024-03-14 15:23   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 24/42] drm/tests: Add a few tests around drm_fixed.h Harry Wentland
2024-03-14 15:36   ` Pekka Paalanen
2024-02-26 21:10 ` [RFC PATCH v4 25/42] drm/vkms: Add tests for CTM handling Harry Wentland
2024-03-14 16:02   ` Pekka Paalanen
2024-02-26 21:10 ` Harry Wentland [this message]
2024-02-26 21:10 ` [RFC PATCH v4 27/42] drm/colorop: define a new macro for_each_new_colorop_in_state Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 28/42] drm/amd/display: Ignore deprecated props when plane_color_pipeline set Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 29/42] drm/amd/display: Add bypass COLOR PIPELINE Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 30/42] drm/amd/display: Skip color pipeline initialization for cursor plane Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 31/42] drm/amd/display: Add support for sRGB EOTF in DEGAM block Harry Wentland
2024-05-21 15:45   ` Melissa Wen
2024-05-21 15:55     ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 32/42] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 33/42] drm/amd/display: Add support for sRGB EOTF in BLND block Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 34/42] drm/colorop: Add PQ 125 EOTF and its inverse Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 35/42] drm/amd/display: Enable support for PQ 125 EOTF and Inverse Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 36/42] drm/colorop: add BT2020/BT709 OETF and Inverse OETF Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 37/42] drm/amd/display: Add support for BT.709 and BT.2020 TFs Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 38/42] drm/colorop: Add 1D Curve Custom LUT type Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 39/42] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 40/42] drm/amd/display: add 3x4 matrix colorop Harry Wentland
2024-02-26 21:10 ` [RFC PATCH v4 41/42] drm/colorop: Add mutliplier type Harry Wentland
2024-05-21 15:38   ` Melissa Wen
2024-02-26 21:10 ` [RFC PATCH v4 42/42] drm/amd/display: add multiplier colorop Harry Wentland
2024-02-27 10:26 ` [RFC PATCH v4 00/42] Color Pipeline API w/ VKMS Joshua Ashton
2024-02-27 14:00   ` Harry Wentland
2024-02-29 10:43 ` Daniel Vetter
2024-02-29 15:31   ` Joshua Ashton
2024-05-21 15:50 ` Melissa Wen
2024-06-05 10:04 ` Melissa Wen
2024-06-11 17:35   ` Harry Wentland
2024-08-04 21:25     ` Melissa Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226211100.100108-27-harry.wentland@amd.com \
    --to=harry.wentland@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.