From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDF61CD20; Mon, 26 Feb 2024 10:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708944176; cv=none; b=QbqHPEcBdrNavq7mcaWih/azUn7YoqZpJyziQ5+Li5FsJAJuFajysWSoGaCwfPKKmjdeYUuW9C6L3K3nrJuWAAucAu3+1bLHjfUGgLGTyGTDfXiOhhilO7KZ2Iuu+MsqJbm9oof7DG7tmxi2QwIQbatS4mEhAYTcXv9jTqPmyPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708944176; c=relaxed/simple; bh=L+2CqeBwfk1IbAkkt5wBDfGerIaFwB6IFcqQZl+himw=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=jFWep3OUhO0pmeyIPz3RA+JHq5AU417E9Sa98Stqsw7tig4MNO9j3+q/smKp1z77D+XScD26iOuGzBAx3Mk4dztHJAiyxkb0MjC4gaYwaqL4Z9URzBf7U1NjxuqFHLnr5DyLzP0o+MZjPhHJJX0CH/j6YfBDVLRC+9JJnZ2NI0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iXcNaZV4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iXcNaZV4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F18C433F1; Mon, 26 Feb 2024 10:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708944176; bh=L+2CqeBwfk1IbAkkt5wBDfGerIaFwB6IFcqQZl+himw=; h=Subject:To:Cc:From:Date:From; b=iXcNaZV4496ZW7RE1xggjHyzuMuu49oWD9APqI/iqAP+eqVBVGSN2dSmYqa5HVWVU qWtrAvk/9conmI+9FhjPs7qIIDC7wMLpM2kd8oYjTS1elQgcYe6Xevrft6qSGgvjUB egxAXrJ5axkzPHyTofz72UTMQTGRzjzIcEVfZxtY= Subject: Patch "platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler" has been added to the 5.15-stable tree To: 295984ce-bd4b-49bd-adc5-ffe7c898d7f0@a-kobel.de,a-kobel@a-kobel.de,arngozum@gmail.com,gregkh@linuxfoundation.org,hdegoede@redhat.com,regressions@lists.linux.dev Cc: From: Date: Mon, 26 Feb 2024 11:42:38 +0100 Message-ID: <2024022638-size-versus-a3e6@gregkh> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: platform-x86-intel-vbtn-stop-calling-vbdl-from-notify_handler.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 84c16d01ff219bc0a5dca5219db6b8b86a6854fb Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Fri, 16 Feb 2024 21:33:00 +0100 Subject: platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler From: Hans de Goede commit 84c16d01ff219bc0a5dca5219db6b8b86a6854fb upstream. Commit 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events") causes 2 issues on the ThinkPad X1 Tablet Gen2: 1. The ThinkPad will wake up immediately from suspend 2. When put in tablet mode SW_TABLET_MODE reverts to 0 after about 1 second Both these issues are caused by the "VBDL" ACPI method call added at the end of the notify_handler. And it never became entirely clear if this call is even necessary to fix the issue of missing tablet-mode-switch events on the Dell Inspiron 7352. Drop the "VBDL" ACPI method call again to fix the 2 issues this is causing on the ThinkPad X1 Tablet Gen2. Fixes: 14c200b7ca46 ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events") Reported-by: Alexander Kobel Closes: https://lore.kernel.org/platform-driver-x86/295984ce-bd4b-49bd-adc5-ffe7c898d7f0@a-kobel.de/ Cc: regressions@lists.linux.dev Cc: Arnold Gozum Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Tested-by: Alexander Kobel Link: https://lore.kernel.org/r/20240216203300.245826-1-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/intel/vbtn.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c index 210b0a81b7ec..084c355c86f5 100644 --- a/drivers/platform/x86/intel/vbtn.c +++ b/drivers/platform/x86/intel/vbtn.c @@ -200,9 +200,6 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) autorelease = val && (!ke_rel || ke_rel->type == KE_IGNORE); sparse_keymap_report_event(input_dev, event, val, autorelease); - - /* Some devices need this to report further events */ - acpi_evaluate_object(handle, "VBDL", NULL, NULL); } /* -- 2.44.0 Patches currently in stable-queue which might be from hdegoede@redhat.com are queue-5.15/platform-x86-touchscreen_dmi-add-info-for-the-teclas.patch queue-5.15/ahci-asm1166-correct-count-of-reported-ports.patch queue-5.15/platform-x86-intel-vbtn-stop-calling-vbdl-from-notify_handler.patch queue-5.15/platform-x86-touchscreen_dmi-allow-partial-prefix-matches-for-acpi-names.patch