From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: chengming.zhou@linux.dev
Cc: minchan@kernel.org, senozhatsky@chromium.org,
akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com,
yosryahmed@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] mm/zsmalloc: don't need to save tag bit in handle
Date: Tue, 27 Feb 2024 16:52:09 +0900 [thread overview]
Message-ID: <20240227075209.GA11972@google.com> (raw)
In-Reply-To: <20240227030045.3443702-1-chengming.zhou@linux.dev>
On (24/02/27 03:00), chengming.zhou@linux.dev wrote:
>
> We only need to save the position (pfn + obj_idx) in the handle, don't
> need to save tag bit in handle. So one more bit can be used as obj_idx.
[..]
> mm/zsmalloc: don't need to save tag bit in handle
Does this mean "don't need to reserve LSB for tag"?
We still save allocated tag in the handle, that's what
handle |= OBJ_ALLOCATED_TAG;
does.
> Actually, the tag bit is only useful in zspage's memory space, to tell
> if an object is allocated or not.
I'm not completely sure if I follow this sentence.
next prev parent reply other threads:[~2024-02-27 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 3:00 [PATCH] mm/zsmalloc: don't need to save tag bit in handle chengming.zhou
2024-02-27 7:52 ` Sergey Senozhatsky [this message]
2024-02-27 8:16 ` Chengming Zhou
2024-02-28 1:54 ` Sergey Senozhatsky
2024-02-28 2:17 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227075209.GA11972@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.