From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBBA61419A6 for ; Tue, 27 Feb 2024 12:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709036519; cv=none; b=jZfQTzc9U55Yl4qxLv0WGk3PRLY8uH085BjYnHHm0/nGyaLPvgy4hmmkp84xJnc4aDXUuzE/RflD84kgHoI9+2hGtJyLJJgarvbcyJq70kG4qXj7+8+39CIAQ6YCIeWPDiRig0OBfgp6exvVT/dM4LRsBN2jRvwCLW5cZ+oNJso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709036519; c=relaxed/simple; bh=OS7E+/QQezCuwcjLO9iExKTfqPQ2LbBPhoHoghWs9UE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QjilxWEW4ou7DgR4OsxEbVDH8YVRfGVPla6/gt13NWUZvdzcQuUNS5ChJvDIpJZ8apqVpId4sYS+ZZkFQiXyRBvJ2r6Zg9YfPbkv5JjiIIY/W0ZQJ6Bq0Hl3oe/qpsyFZw2er7MDqOEfZToZZfixXc8FJS9uv6O1N22z53jIq+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GewXukva; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GewXukva" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dca3951ad9so18560895ad.3 for ; Tue, 27 Feb 2024 04:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709036515; x=1709641315; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=GewXukvadPyjq8mmPdVrgdexPxxyZVm5taQLw4UE8uzO1qUZywn25e1hJOamHZRCwn yY+fYRQ8cx2oj0K3Cn0m0LlooL1bgs+2XFfZJwLd2QmFcpgqANpbYHXxKYXJRTtr/IY5 54ykV2o0Lwwn2FjqEAhg5xUQj9vmNHZ24yruwhr6w7w6Nw/fz8WwRIg/HvWqz6JmzNTK NGvIyAFIELJm2LZ539C/VM+BNa1k9PKPHXKVhOxVPtyXRJBTFys9lI3XaxtMM3MXeo/N as6NuVHKMzRAOzFJ9NXZBZFLeLvQptX86wJ0CeHmULxbgBk9ACo8WuXLMj05/Bnsad29 hBMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709036515; x=1709641315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=LMwsVxOzUgFfwcbYwEsdKJyDRkbf5Ebqd5PclP3vP5q4JotclYzabKny3dkh/o6P/U ZA107cPo3rtaOMpWCtjvj3xGUOWKvdnZ3yXcjjehHbb6u7Cl5OM1gmNV5maWYLnXaF8P 6fYVVMvE+uluV4bzHooReqKYeqx5C1dNt4GdXOrZkr8h3ybOZ304i+5XvQePO3Lr+S+8 byWxeSu3QuywLY1ZMYvZtOQBYbgcPysCODuaPPmSjyY5L0nxvu5JUPXd6+4AKWf/CU89 /juH2T5kCnqRDr1pWiiRRYYnyKFADlMAOOIm1ovPzNhN2jsMFe9z4MB3c7SOcye03Eda pOMw== X-Forwarded-Encrypted: i=1; AJvYcCW23oASGWnBwoKetYxaa0gOG7DlIxoq59JMcFRAHRPSNfNqLXCwIl4wtx/DrgfbWFrYmB7hZcrI9yrx0MG7JBU/Mdhr0WD4MnKImMOnYw== X-Gm-Message-State: AOJu0YySZ8wXnqk3HWjGtdea2rHpMjbmgfUxWSYv6/3dWCi+S0pdx7Cj fKAGXPdb4MAeJf4GBNOfsj8I+fi9LdBCOQOxMZXMLNTJLYi/pX9Amy/NrmiS3A== X-Google-Smtp-Source: AGHT+IHOZyIvtu9udPjddxeRBkjckef05G60ZrgUBTNS/Hn/UgLmDOmQzD5ShaYiOTnnINlgtxpJEw== X-Received: by 2002:a17:903:181:b0:1dc:b173:f27b with SMTP id z1-20020a170903018100b001dcb173f27bmr4528891plg.32.1709036515334; Tue, 27 Feb 2024 04:21:55 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id h8-20020a170902b94800b001dba356b96esm1406270pls.306.2024.02.27.04.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 04:21:54 -0800 (PST) Date: Tue, 27 Feb 2024 17:51:41 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227122141.GN2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Feb 26, 2024 at 12:04:33PM -0500, Frank Li wrote: > On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > drivers requiring active refclk from host. But for the other drivers, it is > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > that this API initializes DWC EP specific registers and that requires an > > active refclk (either from host or generated locally by endpoint itsef). > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > confusion, let's call this API directly from all glue drivers irrespective > > of refclk dependency. Only difference here is that the drivers requiring > > refclk from host will call this API only after the refclk is received and > > other drivers without refclk dependency will call this API right after > > dw_pcie_ep_init(). > > > > This change will also allow us to remove the "core_init_notifier" flag in > > the later commits. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > 8 files changed, 63 insertions(+), 24 deletions(-) [...] > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index ed1f2afd830a..278bdc9b2269 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > @@ -729,7 +729,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > struct device *dev = pci->dev; > > struct platform_device *pdev = to_platform_device(dev); > > struct device_node *np = dev->of_node; > > - const struct pci_epc_features *epc_features; > > > > INIT_LIST_HEAD(&ep->func_list); > > > > @@ -775,29 +774,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > goto err_exit_epc_mem; > > } > > > > - if (ep->ops->get_features) { > > - epc_features = ep->ops->get_features(ep); > > - if (epc_features->core_init_notifier) > > - return 0; > > - } > > why remove this check? > There is no point in keeping this check since we are removing the call to dw_pcie_ep_init_registers() below. But I should've described this change in the commit message. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B641C54798 for ; Tue, 27 Feb 2024 12:22:46 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FZRPD9sy; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tkc7m6mgLz3vXW for ; Tue, 27 Feb 2024 23:22:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FZRPD9sy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::633; helo=mail-pl1-x633.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tkc6v473kz2xPW for ; Tue, 27 Feb 2024 23:21:57 +1100 (AEDT) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1dc49afb495so35171505ad.2 for ; Tue, 27 Feb 2024 04:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709036515; x=1709641315; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=FZRPD9sySwuoIY8NLPLF07AtjTdeNEprsGWQ1dQFj7ZNhWAHFcSl8J5ZxL89rFabY5 n1uDLeSn5fNtEWD+X6N9J/FgpdJ5Kqib/MVfSDjuL5ntYxbGlt5D7oTJMBkLLaYns66I Ie6gOiuJE2C8nJwdC3UoYyyWER07DngfYvg5s4yNpeP2CMeS025x2Y+XJKx9NizusQrP RNovRh8bJfsBetvCXcCO7G2b+YLL8uQqhnod+kAvI10NndNn+ImIQj9VITM2ByiT4uE1 MeSlAVivIvnU+c/xUTjRt+5Nd7HDlJJuy9vKZjX6E8Q3uqa1q25ck0EzWzUEvvqVW688 N6wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709036515; x=1709641315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=vhkXQgKiz7KbNBRoAhq7elg4AhFHBexNw0NMFgZe8xa0ZPPEn19z2SbFDnprPTwzAF +I1L9NjsNcmetw2nDo/lvdc0yuc9i2BXMmb3y1hy0FW8zEw7XzgOjg3RbS/vWtwH3u5b kMxBLoMAzFlqiZFrdbCyPa+1as6ldW/QOk9feOC2UM7ita7wx9y+cqizaJKt0Y4nmSrA oQBspuHQZePchA8MdyKvGa655fxAqSzKgkf9uj/OxA4txUoqtxO3cSAiTqIW7KHIoY6M gpOy4Cq9FRZT31ifv5oMQrS+ge8k/1N8pyld1Uqvs/1/P3b1s5U8F695ekj/JMOhTaj7 0uaQ== X-Forwarded-Encrypted: i=1; AJvYcCV1webC1xcH8NYQnZqhd9Ezr/kFoHJYmegrI6vKK6+BU5RbiwkypylROjOCTlb98DLgLd+zVWCIscS+II2Z4QjER+l3oKMXDlqA6awWkA== X-Gm-Message-State: AOJu0YyJfjpeMmvJBlJo+DZ3UZ5lyE5rQCwQ8nRSNkxBZJjfISaTaDnV gkTFzpAOQnLvTrs5lKHXYw1RtoUieuAqqprCtBW7qMZstqE9nsNJGC7M65S57w== X-Google-Smtp-Source: AGHT+IHOZyIvtu9udPjddxeRBkjckef05G60ZrgUBTNS/Hn/UgLmDOmQzD5ShaYiOTnnINlgtxpJEw== X-Received: by 2002:a17:903:181:b0:1dc:b173:f27b with SMTP id z1-20020a170903018100b001dcb173f27bmr4528891plg.32.1709036515334; Tue, 27 Feb 2024 04:21:55 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id h8-20020a170902b94800b001dba356b96esm1406270pls.306.2024.02.27.04.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 04:21:54 -0800 (PST) Date: Tue, 27 Feb 2024 17:51:41 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227122141.GN2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Niklas Cassel , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Feb 26, 2024 at 12:04:33PM -0500, Frank Li wrote: > On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > drivers requiring active refclk from host. But for the other drivers, it is > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > that this API initializes DWC EP specific registers and that requires an > > active refclk (either from host or generated locally by endpoint itsef). > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > confusion, let's call this API directly from all glue drivers irrespective > > of refclk dependency. Only difference here is that the drivers requiring > > refclk from host will call this API only after the refclk is received and > > other drivers without refclk dependency will call this API right after > > dw_pcie_ep_init(). > > > > This change will also allow us to remove the "core_init_notifier" flag in > > the later commits. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > 8 files changed, 63 insertions(+), 24 deletions(-) [...] > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index ed1f2afd830a..278bdc9b2269 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > @@ -729,7 +729,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > struct device *dev = pci->dev; > > struct platform_device *pdev = to_platform_device(dev); > > struct device_node *np = dev->of_node; > > - const struct pci_epc_features *epc_features; > > > > INIT_LIST_HEAD(&ep->func_list); > > > > @@ -775,29 +774,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > goto err_exit_epc_mem; > > } > > > > - if (ep->ops->get_features) { > > - epc_features = ep->ops->get_features(ep); > > - if (epc_features->core_init_notifier) > > - return 0; > > - } > > why remove this check? > There is no point in keeping this check since we are removing the call to dw_pcie_ep_init_registers() below. But I should've described this change in the commit message. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C90DC5478C for ; Tue, 27 Feb 2024 12:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KdV6M95P2yEWkr1tAJYqCcFVIAONfXwBhnxcEudLHkw=; b=Rch/cMKo3AS1ZY ity4EIYtvCHw0FnEpUW67NIZ1e3eDcUR/38BON67ZJl52wbO6GcbqVaKOdtrr++/0NLO8rmHi1s0s y1rB8t3obXq0M8sZD1rVGTUfOPyaArQDh+seUmGH+fmTvSpBWvCnGoyBaxjAEK4edpYCIP5uHe5ua fEFQrS4iLHS91zzAfqOO/hPMmft4kRPbNhkmUaWqGoMX195m0iYWe+Do2gJNgdOGLuMJulJ7sXCp3 sXp3w+JBtFvtszyyf0rvg8/Ir8zp/VyPgZusaAEXWjoLWXksF6Dp5v3dSUL92tDrCm5XpaAUuoRx4 EFhGto5qy+xd/TaqAikg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rewT9-000000059kI-42IL; Tue, 27 Feb 2024 12:21:59 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rewT6-000000059jA-2Mgd for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 12:21:57 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1dca3951ad9so18560955ad.3 for ; Tue, 27 Feb 2024 04:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709036515; x=1709641315; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=x9dIOCkD69nbMHyOD9L4di2w/bnv0umgVX6QOp0gWahn6hDsHBIl4dzb+xB0x3RmWY cLl2ezxxyzwL0N+Jgyrnb++IQmcr8OIXJKmJ3EcqHl7uK6AktFUFFLE4duW3/rvZ91/Z tVFSJCNTJ8AqO/7OCr+sthwopmnU8HxUvgQ0/FqdfEQ6o4Noqhj8BYfefFZqylTSa7Pd F7Z3pfzkQfBCCSUVWIPVb0rPWHnMKyvd5a9NVAIX4Ob6+LXPcQ+safub4gEo7xtOX/Qy gZnXpI9hagOG0zb1HJacHcz2sOAepfbx95EJzLonPKfYs+AahefWe2PXMozFC7pSDwkD brJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709036515; x=1709641315; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fox2FOTrnn7H7ARtUpilsDQjBFro1sbb1UtQfPOSFHk=; b=ZqY//+CNoKnkfHNg5t+qmLtv30h9kRylw9TNmRPRmgFQBIDlNZHOMI+D05892zOnGu WoZwJglOwxof4NF8LdJJVBLveMC3CP+2VcP2Cb10vl8gwtRieUckT84scu0GQWK5/qhk XJyW+cScdi23IXCfhEbDmFpbzdHWID8+9lpo9h3jXOJa7cNTSKJsSY760ztckYUwIEwN XicyaorHrasYvhpbnEng9998AIfN9ZE4VSPD/ljYVDAYONkx4UcR9X9Di5rDTDNwaHfF E+CrIea7kyYeFrsM3pgynbXDFoUSeCm7mXI7U41zcgfFuuC7gfQQss2NFEcHyebRCAJF hJhA== X-Forwarded-Encrypted: i=1; AJvYcCX3WKg4LO+99Rj1QBWH5CdnHbSvx889Qis9lvdsQfZTd6eRVLO32t6agJNp5W8OTERYFxu19X50levjdUTtE7z382lFPirqP3iXiqwoD5c5equv9QI= X-Gm-Message-State: AOJu0YxHONmGM6kP5bn9IEDgWrZVdxBdChRkpICrDc7VmLaAvIePwxQa w4yya1P6jiWtfEiOcDzYvxZYjcRJ3TWBc7NW/ceTL2L9GXvSJHsWQRtOxsdM2g== X-Google-Smtp-Source: AGHT+IHOZyIvtu9udPjddxeRBkjckef05G60ZrgUBTNS/Hn/UgLmDOmQzD5ShaYiOTnnINlgtxpJEw== X-Received: by 2002:a17:903:181:b0:1dc:b173:f27b with SMTP id z1-20020a170903018100b001dcb173f27bmr4528891plg.32.1709036515334; Tue, 27 Feb 2024 04:21:55 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id h8-20020a170902b94800b001dba356b96esm1406270pls.306.2024.02.27.04.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 04:21:54 -0800 (PST) Date: Tue, 27 Feb 2024 17:51:41 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227122141.GN2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_042156_636456_0C155810 X-CRM114-Status: GOOD ( 26.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBGZWIgMjYsIDIwMjQgYXQgMTI6MDQ6MzNQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gU2F0LCBGZWIgMjQsIDIwMjQgYXQgMTI6MjQ6MTJQTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gQ3VycmVudGx5LCBkd19wY2llX2VwX2luaXRfcmVnaXN0ZXJz KCkgQVBJIGlzIGRpcmVjdGx5IGNhbGxlZCBieSB0aGUgZ2x1ZQo+ID4gZHJpdmVycyByZXF1aXJp bmcgYWN0aXZlIHJlZmNsayBmcm9tIGhvc3QuIEJ1dCBmb3IgdGhlIG90aGVyIGRyaXZlcnMsIGl0 IGlzCj4gPiBnZXR0aW5nIGNhbGxlZCBpbXBsaWNpdGx5IGJ5IGR3X3BjaWVfZXBfaW5pdCgpLiBU aGlzIGlzIGR1ZSB0byB0aGUgZmFjdAo+ID4gdGhhdCB0aGlzIEFQSSBpbml0aWFsaXplcyBEV0Mg RVAgc3BlY2lmaWMgcmVnaXN0ZXJzIGFuZCB0aGF0IHJlcXVpcmVzIGFuCj4gPiBhY3RpdmUgcmVm Y2xrIChlaXRoZXIgZnJvbSBob3N0IG9yIGdlbmVyYXRlZCBsb2NhbGx5IGJ5IGVuZHBvaW50IGl0 c2VmKS4KPiA+IAo+ID4gQnV0LCB0aGlzIGNhdXNlcyBhIGRpc2NyZXBhbmN5IGFtb25nIHRoZSBn bHVlIGRyaXZlcnMuIFNvIHRvIGF2b2lkIHRoaXMKPiA+IGNvbmZ1c2lvbiwgbGV0J3MgY2FsbCB0 aGlzIEFQSSBkaXJlY3RseSBmcm9tIGFsbCBnbHVlIGRyaXZlcnMgaXJyZXNwZWN0aXZlCj4gPiBv ZiByZWZjbGsgZGVwZW5kZW5jeS4gT25seSBkaWZmZXJlbmNlIGhlcmUgaXMgdGhhdCB0aGUgZHJp dmVycyByZXF1aXJpbmcKPiA+IHJlZmNsayBmcm9tIGhvc3Qgd2lsbCBjYWxsIHRoaXMgQVBJIG9u bHkgYWZ0ZXIgdGhlIHJlZmNsayBpcyByZWNlaXZlZCBhbmQKPiA+IG90aGVyIGRyaXZlcnMgd2l0 aG91dCByZWZjbGsgZGVwZW5kZW5jeSB3aWxsIGNhbGwgdGhpcyBBUEkgcmlnaHQgYWZ0ZXIKPiA+ IGR3X3BjaWVfZXBfaW5pdCgpLgo+ID4gCj4gPiBUaGlzIGNoYW5nZSB3aWxsIGFsc28gYWxsb3cg dXMgdG8gcmVtb3ZlIHRoZSAiY29yZV9pbml0X25vdGlmaWVyIiBmbGFnIGluCj4gPiB0aGUgbGF0 ZXIgY29tbWl0cy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFt IDxtYW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1kcmE3eHguYyAgICAgICAgICAgfCAgNyArKysrKysrCj4g PiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYyAgICAgICAgICAgICB8ICA4 ICsrKysrKysrCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWtleXN0b25lLmMg ICAgICAgICB8ICA5ICsrKysrKysrKwo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3Bj aS1sYXllcnNjYXBlLWVwLmMgICAgfCAgNyArKysrKysrCj4gPiAgZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgICB8IDIyIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWRlc2lnbndhcmUtcGxhdC5j IHwgIDkgKysrKysrKysrCj4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1yY2Fy LWdlbjQuYyAgICAgICB8IDEyICsrKysrKysrKysrLQo+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvZHdjL3BjaWUtdW5pcGhpZXItZXAuYyAgICAgfCAxMyArKysrKysrKysrKystCj4gPiAgOCBm aWxlcyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKClsuLi5dCgo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdud2Fy ZS1lcC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMK PiA+IGluZGV4IGVkMWYyYWZkODMwYS4uMjc4YmRjOWIyMjY5IDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMKPiA+ICsrKyBiL2Ry aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZGVzaWdud2FyZS1lcC5jCj4gPiBAQCAtNzI5 LDcgKzcyOSw2IEBAIGludCBkd19wY2llX2VwX2luaXQoc3RydWN0IGR3X3BjaWVfZXAgKmVwKQo+ ID4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBwY2ktPmRldjsKPiA+ICAJc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldiA9IHRvX3BsYXRmb3JtX2RldmljZShkZXYpOwo+ID4gIAlzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wID0gZGV2LT5vZl9ub2RlOwo+ID4gLQljb25zdCBzdHJ1Y3QgcGNpX2VwY19m ZWF0dXJlcyAqZXBjX2ZlYXR1cmVzOwo+ID4gIAo+ID4gIAlJTklUX0xJU1RfSEVBRCgmZXAtPmZ1 bmNfbGlzdCk7Cj4gPiAgCj4gPiBAQCAtNzc1LDI5ICs3NzQsOCBAQCBpbnQgZHdfcGNpZV9lcF9p bml0KHN0cnVjdCBkd19wY2llX2VwICplcCkKPiA+ICAJCWdvdG8gZXJyX2V4aXRfZXBjX21lbTsK PiA+ICAJfQo+ID4gIAo+ID4gLQlpZiAoZXAtPm9wcy0+Z2V0X2ZlYXR1cmVzKSB7Cj4gPiAtCQll cGNfZmVhdHVyZXMgPSBlcC0+b3BzLT5nZXRfZmVhdHVyZXMoZXApOwo+ID4gLQkJaWYgKGVwY19m ZWF0dXJlcy0+Y29yZV9pbml0X25vdGlmaWVyKQo+ID4gLQkJCXJldHVybiAwOwo+ID4gLQl9Cj4g Cj4gd2h5IHJlbW92ZSB0aGlzIGNoZWNrPwo+IAoKVGhlcmUgaXMgbm8gcG9pbnQgaW4ga2VlcGlu ZyB0aGlzIGNoZWNrIHNpbmNlIHdlIGFyZSByZW1vdmluZyB0aGUgY2FsbCB0bwpkd19wY2llX2Vw X2luaXRfcmVnaXN0ZXJzKCkgYmVsb3cuIEJ1dCBJIHNob3VsZCd2ZSBkZXNjcmliZWQgdGhpcyBj aGFuZ2UgaW4gdGhlCmNvbW1pdCBtZXNzYWdlLgoKLSBNYW5pCgotLSAK4K6u4K6j4K6/4K614K6j 4K+N4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=