From: Simon Horman <horms@kernel.org>
To: Chengming Zhou <chengming.zhou@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, vbabka@suse.cz,
Xiongwei.Song@windriver.com
Subject: Re: [PATCH] net: remove SLAB_MEM_SPREAD flag usage
Date: Tue, 27 Feb 2024 17:09:37 +0000 [thread overview]
Message-ID: <20240227170937.GD277116@kernel.org> (raw)
In-Reply-To: <bda53361-d334-411b-8ac1-069d41025804@linux.dev>
On Mon, Feb 26, 2024 at 04:55:01PM +0800, Chengming Zhou wrote:
> On 2024/2/24 21:49, chengming.zhou@linux.dev wrote:
> > From: Chengming Zhou <zhouchengming@bytedance.com>
> >
> > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > its usage so we can delete it from slab. No functional change.
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
>
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>
> Thanks!
>
> >
> > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Thanks Chengming Zhou,
this seems reasonable to me. But I think it would be best to post
a v2 of this patch with the updated patch description (which is very
helpful, BTW).
--
pw-bot: changes-requested
next prev parent reply other threads:[~2024-02-27 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:49 [PATCH] net: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-26 8:55 ` Chengming Zhou
2024-02-27 17:09 ` Simon Horman [this message]
2024-02-28 3:06 ` [PATCH v2] " Chengming Zhou
2024-02-28 15:04 ` Simon Horman
2024-02-29 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227170937.GD277116@kernel.org \
--to=horms@kernel.org \
--cc=Xiongwei.Song@windriver.com \
--cc=chengming.zhou@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.