From: Jakub Kicinski <kuba@kernel.org>
To: "Lameter, Christopher" <cl@os.amperecomputing.com>
Cc: Eric Dumazet <edumazet@google.com>,
Adam Li <adamli@os.amperecomputing.com>,
corbet@lwn.net, davem@davemloft.net, pabeni@redhat.com,
willemb@google.com, yangtiezhu@loongson.cn, atenart@kernel.org,
kuniyu@amazon.com, wuyun.abel@bytedance.com, leitao@debian.org,
alexander@mihalicyn.com, dhowells@redhat.com, paulmck@kernel.org,
joel.granados@gmail.com, urezki@gmail.com,
joel@joelfernandes.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
patches@amperecomputing.com, shijie@os.amperecomputing.com
Subject: Re: [PATCH] net: make SK_MEMORY_PCPU_RESERV tunable
Date: Tue, 27 Feb 2024 17:13:16 -0800 [thread overview]
Message-ID: <20240227171316.40fe9c35@kernel.org> (raw)
In-Reply-To: <bc168824-25dd-7541-1a34-38b1a3c00489@os.amperecomputing.com>
On Tue, 27 Feb 2024 15:08:18 -0800 (PST) Lameter, Christopher wrote:
> > This looks good, do you have any performance numbers to share ?
> >
> > On a host with 384 threads, 384*16 -> 6 GB of memory.
>
> Those things also come with corresponding memories of a couple of TB...
We have a lot of machines at Meta with more cores than gigabytes of
memory. Keying on amount of memory would make sense. Something like
max(1MB, sk_mem / cores / 8) comes to mind?
In fact it may be a better idea to have the sysctl control the divisor
(the 8 in my example above). I had issues in the past with people
"micro-optimizing" the absolute size, forgetting about it, moving
workload to a larger machine and then complaining TCP is choking :(
next prev parent reply other threads:[~2024-02-28 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 2:24 [PATCH] net: make SK_MEMORY_PCPU_RESERV tunable Adam Li
2024-02-26 16:01 ` Lameter, Christopher
2024-02-27 20:38 ` Eric Dumazet
2024-02-27 23:08 ` Lameter, Christopher
2024-02-28 1:13 ` Jakub Kicinski [this message]
2024-02-28 9:32 ` Eric Dumazet
2024-02-28 13:23 ` Adam Li
2024-02-28 13:46 ` Eric Dumazet
2024-03-06 17:01 ` Lameter, Christopher
2024-03-06 17:28 ` Eric Dumazet
2024-02-28 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227171316.40fe9c35@kernel.org \
--to=kuba@kernel.org \
--cc=adamli@os.amperecomputing.com \
--cc=alexander@mihalicyn.com \
--cc=atenart@kernel.org \
--cc=cl@os.amperecomputing.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=joel.granados@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patches@amperecomputing.com \
--cc=paulmck@kernel.org \
--cc=shijie@os.amperecomputing.com \
--cc=urezki@gmail.com \
--cc=willemb@google.com \
--cc=wuyun.abel@bytedance.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.