From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3204CB55 for ; Tue, 27 Feb 2024 18:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059355; cv=none; b=RLhSOTm/bpmLM33glhVLKV1UdWUEz7pNAb2ybZlSzJm4r+FY/kivbhcYgIptJwegZnVEgAHiTy18S7KLc2G1PN5IJiMwN9UFo29ZjDyAtiDuH/6H1DgCjf65Vv1EePcbWP4NL1BS5AcJ1QMgGkc+nLUGS2u4ooBfV7EgSAMsezw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059355; c=relaxed/simple; bh=TeDNuU90ly9acziamBX1PT4TgShziEBCnefgqu8SzNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IuoIoth4rZCiF3ILrgbIQ3+EPYZ83JVPuaRAhu80Jko3gEoevewV1/mMVCb9xEwWFHDU11mlb48Y3NpAS0rtkGm63sY5ZCpUv8eHnRSbd6A6PdZu6lqvegiYAZS81kljMn6BpUOf3auAu1xF6uXwDHcWfZN0Ofme16JFK+5k9CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OD4KwaAW; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OD4KwaAW" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5cdbc4334edso3392574a12.3 for ; Tue, 27 Feb 2024 10:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059352; x=1709664152; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=OD4KwaAW5YRbf3nRwotlMQFuGPEEQqHOJ7Grl8+wj/23FYaYlioTcxFCEPN63qpWKD hcYHUCyBIGz+FtHeflthN/eGvK1w69FWDyuHH/KTYHjvrUdSKiUwNz0ZotyZ5POM2g4v yDZM1uFw1HbGFn088iaXuQyCN5hxuOaglTMjSrJ2IZwxiEDaZ1w7eAfSr8otQ4UJ0UIm Ef1sK7HMi64X4tr86rsDgPzHi49PF4Z1ZGCsAeYOKvF2qjg+Jl5qQRjoKTKbNNLYHj9C 41mq4i8R/qHdas64GsuSAmwzz/M/qED9491WlJtJW26KtBhCRSbuTKIiaDnE7IQkbIXV c8iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059352; x=1709664152; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=QguXxOWZmu0yaGNW1VDSIDCOWAra45G+nK2xORvvDg+ey5PpinKHYdJneOGZTkdACp 1H+f1lXDCPiU6nQzR4AXpaCvxwCNxzgyNT+SJGmffFEe+KsQkCRQfAeC62Gn8IaQg08h wHfHOpqrbqiV2erMY7IhRNjNHdUULBEu/QQU6h7EWctvlLjyhgkPGK22Dlt0lv/vFRUX Fr6NgFB6KXjrOupanmg/7iFQnJfglU8irJCPGY3IFBfJ9W76xETduluvBTiExqpWyTHz ZFpBA+IOq/jLJ4iQ1XI3E/kg7fIXEBbzHuaSPwyeD1Qwsqc5q6AHnbHHt3Hd1Sh/5zit kxxA== X-Forwarded-Encrypted: i=1; AJvYcCUGc7etyKQ9uOHHkVPdzfUxHe2PzX+1p0zkIawsuTgU3cFf28LLdKI7I8FmRKG6zn/ZQlT12Z5TN/EW/2W2IKRn//MlCxgP0uNptTLA3g== X-Gm-Message-State: AOJu0YxFIB6N7amn1LvYuZ1dW+LZpW917mdN++HaF3EIAMivNgWoQr85 EObiyYmkY7XbH/TNyqhc061csP33ikkcIAovlzBUkyZl3SiAr/cYVPgSBc/qbA== X-Google-Smtp-Source: AGHT+IHGnijMDtvZJeDBn9BB121pNvr/sMLOiP6/y+CYwXPpfHEAryi1aO3yqqkJry/L7BDxwUlTZw== X-Received: by 2002:a17:90a:4285:b0:299:6a7f:cc09 with SMTP id p5-20020a17090a428500b002996a7fcc09mr7865801pjg.33.1709059351862; Tue, 27 Feb 2024 10:42:31 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id nr14-20020a17090b240e00b00299332505d7sm3758838pjb.26.2024.02.27.10.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:42:31 -0800 (PST) Date: Wed, 28 Feb 2024 00:12:18 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227184218.GT2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> <20240227122141.GN2587@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 27, 2024 at 12:28:41PM -0500, Frank Li wrote: > On Tue, Feb 27, 2024 at 05:51:41PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Feb 26, 2024 at 12:04:33PM -0500, Frank Li wrote: > > > On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > > > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > > > drivers requiring active refclk from host. But for the other drivers, it is > > > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > > > that this API initializes DWC EP specific registers and that requires an > > > > active refclk (either from host or generated locally by endpoint itsef). > > > > > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > > > confusion, let's call this API directly from all glue drivers irrespective > > > > of refclk dependency. Only difference here is that the drivers requiring > > > > refclk from host will call this API only after the refclk is received and > > > > other drivers without refclk dependency will call this API right after > > > > dw_pcie_ep_init(). > > > > > > > > This change will also allow us to remove the "core_init_notifier" flag in > > > > the later commits. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > > > 8 files changed, 63 insertions(+), 24 deletions(-) > > > > [...] > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > index ed1f2afd830a..278bdc9b2269 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > @@ -729,7 +729,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > > > struct device *dev = pci->dev; > > > > struct platform_device *pdev = to_platform_device(dev); > > > > struct device_node *np = dev->of_node; > > > > - const struct pci_epc_features *epc_features; > > > > > > > > INIT_LIST_HEAD(&ep->func_list); > > > > > > > > @@ -775,29 +774,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > > > goto err_exit_epc_mem; > > > > } > > > > > > > > - if (ep->ops->get_features) { > > > > - epc_features = ep->ops->get_features(ep); > > > > - if (epc_features->core_init_notifier) > > > > - return 0; > > > > - } > > > > > > why remove this check? > > > > > > > There is no point in keeping this check since we are removing the call to > > dw_pcie_ep_init_registers() below. But I should've described this change in the > > commit message. > > Sperated patch will be helpful. This clean up does not related with other > change. > Well this is not a generic cleanup that could be moved to a separate patch. Due to the changes in this patch, the use of the flag becomes redundant. So it has to removed here itself. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE38CC54798 for ; Tue, 27 Feb 2024 18:43:21 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=mnKF8/V+; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TkmZw3JN9z3vf2 for ; Wed, 28 Feb 2024 05:43:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=mnKF8/V+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::1033; helo=mail-pj1-x1033.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TkmZ46bm8z3vYC for ; Wed, 28 Feb 2024 05:42:35 +1100 (AEDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-29954bb87b4so3262756a91.2 for ; Tue, 27 Feb 2024 10:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059352; x=1709664152; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=mnKF8/V+UJEkxT4cuP5ul2r9M3tEMH10SEzVWrcRWFBSBYTzNjZvkCO1TxTtHrYy6s nFOVVVPDBCBYu0peFsqBHmvwXUcrB5/SUGEe580VR3fwLaMHwGrTL3zY88qTjXfHnvko cObxNNpui6M3ve9vOwM25labE+f1OvG2xHwZfH1IMykcdnHeMLhI5Sf8/LcgLkCJIlWG pXPdR2k6q3hkbmm2KCbSVKhzmrb1sJUAQ3WrODeBWEH3hw37uBr+Hh5QjLRQBa+L2hGH XjCN9dPApmUgMEku/berSbd+BXd01jx9T2ek1+tMN5As+ATkVGNtNf2Hoog5yZGuKJSd zhEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059352; x=1709664152; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=JSKuwUaQ3n85xkydvFiuEz1zAWFG5EIk4HE9Y2Gbewh9jqTnliDetc3rKBX4IRM6br 52ZEefG/GupDYJbEYg9dESh35Nk7fz5eN1ZKvK2EqcomZl5jCLVVRgrYXr4FgmnSgDRl 6iuYjQkpQeZUXyvTj8Z50W8AWilg9O9FjnzlTjVQyeOg0PbcwoU3olLNeMNWfzVesEnt 8qDay4xGwJcBaFYSJxol2j7dnwGIb1l1uRJACSeWgH/cTn88Q0RJ2HlUo7aP+YM9FIUZ U3JUJoyR/qMgGMTgXi/dabegmSlOW5XpgJXIwuxgSgMnemLY+Vud690x7w80bKA/p+bL FFiw== X-Forwarded-Encrypted: i=1; AJvYcCVgpYLQz63id+BQz489EQkPz32H1QPRYfUO2tfKTGWFRXD5kJkjQgWIqJcTU1JdpaqDQclVZLPZMYd58+pIuZO9g+CsPqU1pJWW76tE9A== X-Gm-Message-State: AOJu0YzG/4Dril30iucDMVh7pbleohvw+bbib2AgjVRg9Tr9gmzBUX0Q vkFTbvcUW0NoziKYfrcNtOka36FTSZoi/q+LD9KlG+pguHT6aJ19z108PROAHQ== X-Google-Smtp-Source: AGHT+IHGnijMDtvZJeDBn9BB121pNvr/sMLOiP6/y+CYwXPpfHEAryi1aO3yqqkJry/L7BDxwUlTZw== X-Received: by 2002:a17:90a:4285:b0:299:6a7f:cc09 with SMTP id p5-20020a17090a428500b002996a7fcc09mr7865801pjg.33.1709059351862; Tue, 27 Feb 2024 10:42:31 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id nr14-20020a17090b240e00b00299332505d7sm3758838pjb.26.2024.02.27.10.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:42:31 -0800 (PST) Date: Wed, 28 Feb 2024 00:12:18 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227184218.GT2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> <20240227122141.GN2587@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Niklas Cassel , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Feb 27, 2024 at 12:28:41PM -0500, Frank Li wrote: > On Tue, Feb 27, 2024 at 05:51:41PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Feb 26, 2024 at 12:04:33PM -0500, Frank Li wrote: > > > On Sat, Feb 24, 2024 at 12:24:12PM +0530, Manivannan Sadhasivam wrote: > > > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > > > drivers requiring active refclk from host. But for the other drivers, it is > > > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > > > that this API initializes DWC EP specific registers and that requires an > > > > active refclk (either from host or generated locally by endpoint itsef). > > > > > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > > > confusion, let's call this API directly from all glue drivers irrespective > > > > of refclk dependency. Only difference here is that the drivers requiring > > > > refclk from host will call this API only after the refclk is received and > > > > other drivers without refclk dependency will call this API right after > > > > dw_pcie_ep_init(). > > > > > > > > This change will also allow us to remove the "core_init_notifier" flag in > > > > the later commits. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > > > 8 files changed, 63 insertions(+), 24 deletions(-) > > > > [...] > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > index ed1f2afd830a..278bdc9b2269 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > > > @@ -729,7 +729,6 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > > > struct device *dev = pci->dev; > > > > struct platform_device *pdev = to_platform_device(dev); > > > > struct device_node *np = dev->of_node; > > > > - const struct pci_epc_features *epc_features; > > > > > > > > INIT_LIST_HEAD(&ep->func_list); > > > > > > > > @@ -775,29 +774,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) > > > > goto err_exit_epc_mem; > > > > } > > > > > > > > - if (ep->ops->get_features) { > > > > - epc_features = ep->ops->get_features(ep); > > > > - if (epc_features->core_init_notifier) > > > > - return 0; > > > > - } > > > > > > why remove this check? > > > > > > > There is no point in keeping this check since we are removing the call to > > dw_pcie_ep_init_registers() below. But I should've described this change in the > > commit message. > > Sperated patch will be helpful. This clean up does not related with other > change. > Well this is not a generic cleanup that could be moved to a separate patch. Due to the changes in this patch, the use of the flag becomes redundant. So it has to removed here itself. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A012C54798 for ; Tue, 27 Feb 2024 18:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VChgdO2BfOgmOTJS40Q4WT9Aqoy3rgvVVWuh4/fo1z0=; b=3YbnzgckSct2G7 iMih+sugqalxA6/QtOqS0bEXLV3QH2s01+wggA6fniJS4TxJ322ahXPs9CN0Fhf3p3m2fyrMwzZ9/ Z6zhcMF0SoFq5J2QWCsU0xyZLbJSTOtFzWk4xTVhiTkR4EFAVefhrhAjhnIS/FjHM8LJGL5TAHOy3 6LyiLpr3vmjdKhcquB1RHDGVCB45Ba8aLAwXudh+V03XQRezm51GARnZ/gm9FV3w5mXHAj3OSB/pZ XcFem2GBxdIRhw8vAonS2oTvRTV0Yw0wWikxwMxz1KXQ0YpIv+9fy/aunUSbJO5OFlMGqIdkEJotV U9G8KpNNq/x9cIIQqprQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2PU-00000006Tc5-22CC; Tue, 27 Feb 2024 18:42:36 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2PR-00000006TbX-1S68 for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 18:42:34 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5e152c757a5so3457829a12.2 for ; Tue, 27 Feb 2024 10:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059352; x=1709664152; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=pXrMz2lJ+YqFy4qfElv83dXbw4n1dZmCGZY0PHmVaFJqXlEM8xmfRQGMg1az2UumIB CihyKFVxxsl9od6K436DtWcKY9tsRAR9zpkj+54Y/Pd7h8060muFhx3QmiymRU11JAGS 2kyeQCgkd5QrkqQkm97dfEZoBrx+Or6spUl7V5N66eEJBJs3XC0HTEap0Z1hR82mLFAE r84hwbVk6zRvlpZ64K2ep4Y8nK7Q3wzgZyW241Di95yH+VAdOlRMRuEnOfu3Qd54aoMh XC5ipD5uESAEO/o+zV7UuOxIPSNJTXWzYbgKd6LU7Py7Z4CiUzTH8AQ+jb7TyBZ7qylh Ls4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059352; x=1709664152; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+6rCPg+j8C1jvS9yOkEQeWpFYDNNuRJYfgnyrNY8KDs=; b=jkppw3/97D2tVj5pORO0XYoQ09Cl1l1/MNbXw33f0SdRBdS08c81hsfjYwSae2lWbF Lx56f1zOdVQff9NXV60o3tthVHPLHHUoyz5XRFHQPj0nLch5blthvd8+Fbxi8SdHMooD DzDIt82rNeVHIJymuUieVTf8fmnBxRFGNVCWyU8PeiqZ9SCCKvGf7iiumoJO5fNFa6qz iZDR5yW3JNHn0TjyYJiK4kn5vEfVsQqdOTIrSqieED3cBiaPwv+a1o/6IF5BiyiSEsLp pDB2Y6oatzlHt8fXTSGDzHE/ZznaCVQ4N+v62muN5yDNKiw87iqOfeWMUilR8U2nMwfv vCZA== X-Forwarded-Encrypted: i=1; AJvYcCXycY8+Ms7z8+qWWhH1p8fbgYgZxrlSCk2r36QXGRNrJ6HiTp16lbU1VQczhwygs9IzfjmF4qSIbMAGDjn0wMG8rbC3xiygQgUwWV8Ebt8UA537pGo= X-Gm-Message-State: AOJu0Yz84H5lqsGPBmqvUSrwTlh5zxkQwdL7XJ+jQcDa1vHC8DQ86NAJ Px5akIpW9mX6xPfVkKlQr+OA7kS/TDLal02JSbr7I7w1G71SQi20DofGEGlwIGbBVO7iL6z40H8 = X-Google-Smtp-Source: AGHT+IHGnijMDtvZJeDBn9BB121pNvr/sMLOiP6/y+CYwXPpfHEAryi1aO3yqqkJry/L7BDxwUlTZw== X-Received: by 2002:a17:90a:4285:b0:299:6a7f:cc09 with SMTP id p5-20020a17090a428500b002996a7fcc09mr7865801pjg.33.1709059351862; Tue, 27 Feb 2024 10:42:31 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id nr14-20020a17090b240e00b00299332505d7sm3758838pjb.26.2024.02.27.10.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:42:31 -0800 (PST) Date: Wed, 28 Feb 2024 00:12:18 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240227184218.GT2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-6-64c7fd0cfe64@linaro.org> <20240227122141.GN2587@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_104233_415811_966AA9A9 X-CRM114-Status: GOOD ( 32.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMTI6Mjg6NDFQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMDU6NTE6NDFQTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gTW9uLCBGZWIgMjYsIDIwMjQgYXQgMTI6MDQ6MzNQTSAt MDUwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiA+IE9uIFNhdCwgRmViIDI0LCAyMDI0IGF0IDEyOjI0 OjEyUE0gKzA1MzAsIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3cm90ZToKPiA+ID4gPiBDdXJyZW50 bHksIGR3X3BjaWVfZXBfaW5pdF9yZWdpc3RlcnMoKSBBUEkgaXMgZGlyZWN0bHkgY2FsbGVkIGJ5 IHRoZSBnbHVlCj4gPiA+ID4gZHJpdmVycyByZXF1aXJpbmcgYWN0aXZlIHJlZmNsayBmcm9tIGhv c3QuIEJ1dCBmb3IgdGhlIG90aGVyIGRyaXZlcnMsIGl0IGlzCj4gPiA+ID4gZ2V0dGluZyBjYWxs ZWQgaW1wbGljaXRseSBieSBkd19wY2llX2VwX2luaXQoKS4gVGhpcyBpcyBkdWUgdG8gdGhlIGZh Y3QKPiA+ID4gPiB0aGF0IHRoaXMgQVBJIGluaXRpYWxpemVzIERXQyBFUCBzcGVjaWZpYyByZWdp c3RlcnMgYW5kIHRoYXQgcmVxdWlyZXMgYW4KPiA+ID4gPiBhY3RpdmUgcmVmY2xrIChlaXRoZXIg ZnJvbSBob3N0IG9yIGdlbmVyYXRlZCBsb2NhbGx5IGJ5IGVuZHBvaW50IGl0c2VmKS4KPiA+ID4g PiAKPiA+ID4gPiBCdXQsIHRoaXMgY2F1c2VzIGEgZGlzY3JlcGFuY3kgYW1vbmcgdGhlIGdsdWUg ZHJpdmVycy4gU28gdG8gYXZvaWQgdGhpcwo+ID4gPiA+IGNvbmZ1c2lvbiwgbGV0J3MgY2FsbCB0 aGlzIEFQSSBkaXJlY3RseSBmcm9tIGFsbCBnbHVlIGRyaXZlcnMgaXJyZXNwZWN0aXZlCj4gPiA+ ID4gb2YgcmVmY2xrIGRlcGVuZGVuY3kuIE9ubHkgZGlmZmVyZW5jZSBoZXJlIGlzIHRoYXQgdGhl IGRyaXZlcnMgcmVxdWlyaW5nCj4gPiA+ID4gcmVmY2xrIGZyb20gaG9zdCB3aWxsIGNhbGwgdGhp cyBBUEkgb25seSBhZnRlciB0aGUgcmVmY2xrIGlzIHJlY2VpdmVkIGFuZAo+ID4gPiA+IG90aGVy IGRyaXZlcnMgd2l0aG91dCByZWZjbGsgZGVwZW5kZW5jeSB3aWxsIGNhbGwgdGhpcyBBUEkgcmln aHQgYWZ0ZXIKPiA+ID4gPiBkd19wY2llX2VwX2luaXQoKS4KPiA+ID4gPiAKPiA+ID4gPiBUaGlz IGNoYW5nZSB3aWxsIGFsc28gYWxsb3cgdXMgdG8gcmVtb3ZlIHRoZSAiY29yZV9pbml0X25vdGlm aWVyIiBmbGFnIGluCj4gPiA+ID4gdGhlIGxhdGVyIGNvbW1pdHMuCj4gPiA+ID4gCj4gPiA+ID4g U2lnbmVkLW9mZi1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2 YW1AbGluYXJvLm9yZz4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpLWRyYTd4eC5jICAgICAgICAgICB8ICA3ICsrKysrKysKPiA+ID4gPiAgZHJpdmVy cy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYyAgICAgICAgICAgICB8ICA4ICsrKysrKysr Cj4gPiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jICAgICAg ICAgfCAgOSArKysrKysrKysKPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNp LWxheWVyc2NhcGUtZXAuYyAgICB8ICA3ICsrKysrKysKPiA+ID4gPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgICB8IDIyIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiA+ID4gPiAgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJl LXBsYXQuYyB8ICA5ICsrKysrKysrKwo+ID4gPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3 Yy9wY2llLXJjYXItZ2VuNC5jICAgICAgIHwgMTIgKysrKysrKysrKystCj4gPiA+ID4gIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtdW5pcGhpZXItZXAuYyAgICAgfCAxMyArKysrKysr KysrKystCj4gPiA+ID4gIDggZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgMjQgZGVs ZXRpb25zKC0pCj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMgYi9kcml2ZXJzL3BjaS9j b250cm9sbGVyL2R3Yy9wY2llLWRlc2lnbndhcmUtZXAuYwo+ID4gPiA+IGluZGV4IGVkMWYyYWZk ODMwYS4uMjc4YmRjOWIyMjY5IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaWUtZGVzaWdud2FyZS1lcC5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpZS1kZXNpZ253YXJlLWVwLmMKPiA+ID4gPiBAQCAtNzI5LDcgKzcy OSw2IEBAIGludCBkd19wY2llX2VwX2luaXQoc3RydWN0IGR3X3BjaWVfZXAgKmVwKQo+ID4gPiA+ ICAJc3RydWN0IGRldmljZSAqZGV2ID0gcGNpLT5kZXY7Cj4gPiA+ID4gIAlzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpwZGV2ID0gdG9fcGxhdGZvcm1fZGV2aWNlKGRldik7Cj4gPiA+ID4gIAlzdHJ1 Y3QgZGV2aWNlX25vZGUgKm5wID0gZGV2LT5vZl9ub2RlOwo+ID4gPiA+IC0JY29uc3Qgc3RydWN0 IHBjaV9lcGNfZmVhdHVyZXMgKmVwY19mZWF0dXJlczsKPiA+ID4gPiAgCj4gPiA+ID4gIAlJTklU X0xJU1RfSEVBRCgmZXAtPmZ1bmNfbGlzdCk7Cj4gPiA+ID4gIAo+ID4gPiA+IEBAIC03NzUsMjkg Kzc3NCw4IEBAIGludCBkd19wY2llX2VwX2luaXQoc3RydWN0IGR3X3BjaWVfZXAgKmVwKQo+ID4g PiA+ICAJCWdvdG8gZXJyX2V4aXRfZXBjX21lbTsKPiA+ID4gPiAgCX0KPiA+ID4gPiAgCj4gPiA+ ID4gLQlpZiAoZXAtPm9wcy0+Z2V0X2ZlYXR1cmVzKSB7Cj4gPiA+ID4gLQkJZXBjX2ZlYXR1cmVz ID0gZXAtPm9wcy0+Z2V0X2ZlYXR1cmVzKGVwKTsKPiA+ID4gPiAtCQlpZiAoZXBjX2ZlYXR1cmVz LT5jb3JlX2luaXRfbm90aWZpZXIpCj4gPiA+ID4gLQkJCXJldHVybiAwOwo+ID4gPiA+IC0JfQo+ ID4gPiAKPiA+ID4gd2h5IHJlbW92ZSB0aGlzIGNoZWNrPwo+ID4gPiAKPiA+IAo+ID4gVGhlcmUg aXMgbm8gcG9pbnQgaW4ga2VlcGluZyB0aGlzIGNoZWNrIHNpbmNlIHdlIGFyZSByZW1vdmluZyB0 aGUgY2FsbCB0bwo+ID4gZHdfcGNpZV9lcF9pbml0X3JlZ2lzdGVycygpIGJlbG93LiBCdXQgSSBz aG91bGQndmUgZGVzY3JpYmVkIHRoaXMgY2hhbmdlIGluIHRoZQo+ID4gY29tbWl0IG1lc3NhZ2Uu Cj4gCj4gU3BlcmF0ZWQgcGF0Y2ggd2lsbCBiZSBoZWxwZnVsLiBUaGlzIGNsZWFuIHVwIGRvZXMg bm90IHJlbGF0ZWQgd2l0aCBvdGhlcgo+IGNoYW5nZS4KPiAKCldlbGwgdGhpcyBpcyBub3QgYSBn ZW5lcmljIGNsZWFudXAgdGhhdCBjb3VsZCBiZSBtb3ZlZCB0byBhIHNlcGFyYXRlIHBhdGNoLiBE dWUKdG8gdGhlIGNoYW5nZXMgaW4gdGhpcyBwYXRjaCwgdGhlIHVzZSBvZiB0aGUgZmxhZyBiZWNv bWVzIHJlZHVuZGFudC4gU28gaXQgaGFzCnRvIHJlbW92ZWQgaGVyZSBpdHNlbGYuCgotIE1hbmkK Ci0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+N CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==