From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C5D54F618 for ; Tue, 27 Feb 2024 18:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059684; cv=none; b=t3C6RKZZp586gx2lldObpPKL7WjHW38X/fqPBiMFYbqLbCOpvj3677SQ3Wl/atvTddldD6tsXmrJlRCa1x373h1N4G2est6h6VMR7mVms2exiE6Oqt3Mah9ZHUOiuurj1hIkQo0s7pR2LgER4lIqgv13oKauUMKMs9hQW1XlsfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709059684; c=relaxed/simple; bh=eopTjD6dnBhQmGbU1b50iW81wisqf1duKytlAiZoS+I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hpB2Sz5SkCIp5hKJmCg52ueO9w0IvvFLFfpGWKbhEZ/2O+BcGb2SrzpnophYy0Iw7Tcyd5CsHeODvHn/lfI8SiRMQJNdWPRuaZItQWdPJfjH1VvupwTu9e2CTOQ8ycs4TQHfiLRe7rJsjrxDnBmzse7lukcmNECuW9/4QgdkUGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R77E8hBV; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R77E8hBV" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6e55731af5cso394963b3a.0 for ; Tue, 27 Feb 2024 10:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059682; x=1709664482; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=R77E8hBVMGqBGagFYRfwRcGo/Qk+s0Bpxn/QeEk4KyPQeYsl4IpIRxtCmy29ksnqPU 3kRR25neRJUdEb2imXR1R0g4q9JBJkejJRjpurELLRsyK691fkcTL5wmkz06KN8fz0u2 oOZAwczL8HsPOzQS4asKKlqZmKlLbz1Sd8IV8niWe2V0uK4Q2eaYcFSYfg9rwc4IeCdf SUipNY8f1Atcesj+CjQ/oekZSzSb1/ssEjVSQZIbArUXYPOn0lFBqzYEKyno90GZcsvJ K8/d1Sugq/CvIj5Y7yBAA/EMgnoXgdF8bL795rBUXLEDvr9drmK65/yWRXjOdObt2HJQ fYXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059682; x=1709664482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=AYBlcGoftuZOfiJXkPE0P5bbWyoLTge49exjmjs9Ka345Vm5sQG7Nkq4wIJOM1RG1q /ZhtosiPaMSKJCxo4r4tXl97CFkPtGAFZIBfJfWKypz6+GG1eieBiAaSu+QGwA/tLrJ8 IZiHo2d+Ix73a/rryE1BVwk2JTd4dwnQqtTpwzUg1zJ1mOMKq8MS7UfBG7RrkiuLCMKZ oujO9OximeYpVGof+CnIDH2O77TSfK1FjTgTszRo0Q752mHmC9+16xHEaJbgkAzFI6a9 +RrBR+D8m8fxacZPUc7dDCvIa75dY28HcrMCl9xzdLUILJiKt/up0YatSicnDklCVYAD uyDA== X-Forwarded-Encrypted: i=1; AJvYcCUvFvOx+pUcs5tpdQsnEuHRehxjjNIkT092vkKFT8RGujEsIXutUmspJu8tDjUW1UChft70xtaX+7q7gHKBji6WGZBQ5pFd8tSvZuAp2A== X-Gm-Message-State: AOJu0Yzs3ZSqD58UcrtSIy3jjmGP1HJH2TOuA1rcy53TCiiyk0bhXjPn oSAhOzBduu71KhnmryNX0AvB1HhTHd+lk1M5g2HeNk62Zuuq5hyQ5DV3BUQXVA== X-Google-Smtp-Source: AGHT+IGkys0fKbeS9Jt1kuxo+kV1ICMy26+vP7tNYAsfOhXbaH/LE978wltzQSZ6voKtVRqGdPcHyg== X-Received: by 2002:a05:6a21:920b:b0:1a0:adbc:7a96 with SMTP id tl11-20020a056a21920b00b001a0adbc7a96mr3099279pzb.36.1709059682411; Tue, 27 Feb 2024 10:48:02 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id km8-20020a17090327c800b001d8f81ecebesm1845645plb.192.2024.02.27.10.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:48:02 -0800 (PST) Date: Wed, 28 Feb 2024 00:17:46 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event Message-ID: <20240227184746.GU2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org> <20240227123230.GP2587@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Feb 27, 2024 at 12:34:15PM -0500, Frank Li wrote: > On Tue, Feb 27, 2024 at 06:02:30PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Feb 26, 2024 at 12:20:41PM -0500, Frank Li wrote: > > > On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > > > > Now that the API is available, let's make use of it. It also handles the > > > > reinitialization of DWC non-sticky registers in addition to sending the > > > > notification to EPF drivers. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > index 2fb8c15e7a91..4e45bc4bca45 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > > > > if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) { > > > > dev_dbg(dev, "Received Linkdown event\n"); > > > > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > > > > - pci_epc_linkdown(pci->ep.epc); > > > > + dw_pcie_ep_linkdown(&pci->ep); > > > > > > Suppose pci_epc_linkdown() will call dw_pcie_ep_linkdown() ? > > > why need direct call dw_pcie_ep_linkdown() here? > > > > > > > I've already justified this in the commit message. Here is the excerpt: > > > > "It also handles the reinitialization of DWC non-sticky registers in addition > > to sending the notification to EPF drivers." > > API function name is too similar. It is hard to know difference from API > naming. It'd better to know what function do from function name. > In reality we cannot name a function based on everything it does. The naming is mostly based on what is the primary motive of the API and here it is handling Link down event. Maybe dw_pcie_ep_handle_linkdown() would be an apt one, but that's out of scope of this series (since changing that would also require changes to other similar APIs). - Mani > Frank > > > > - Mani > > > > -- > > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 646F1C5478C for ; Tue, 27 Feb 2024 18:48:50 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=m9O+KwkO; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TkmjD53M4z3vdQ for ; Wed, 28 Feb 2024 05:48:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=m9O+KwkO; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TkmhQ5RVlz3dVj for ; Wed, 28 Feb 2024 05:48:05 +1100 (AEDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e55bb75c9eso55242b3a.3 for ; Tue, 27 Feb 2024 10:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059682; x=1709664482; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=m9O+KwkOpbEbg8jkMa9VJQWMZsEiB+EMkADwlZR2QY3TZChTaQ1ryTTbknZh7L6Be9 pqYs2f5ujrme4O2CpeUiiJZdu6U4hZS++oPv+vj0gheOt4heMUdpoLQbkmeZcVuagbtY zN+dIcNcrrg0oP2TfK4PzX2x70oYfoAhR5akJe9XJBgxhek4+jRt0FilzI+vqTLiaAME Gayt03KjfParQ6K6Y9gWMob2bWNnt1j2iw7gVuRswTLY0eT0owSOS1+As6S6XEnexNo7 /hGkqbbmsOv0V4NcZChCcZlfY+RgNDmVbR0II3dx0FiZL/LMyeQ4QuLPU2Y7I+62r5YD WPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059682; x=1709664482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=LKYV8gyfGQ85BiHYjyvWXfdhS2Dc+7RyPDbP3bPcd1wEn42VV9cVaVGGWlpJMQnU2q HmX0HLrei6JWVseIYiCTTn9nFfLIeacbSjzkQ3koHAvNLsg1Lbt64uelg49V7Sbl9U1e N0caq92Lu2/yWgiI3UeZp3mSzQ2M/tpicYW9MfZhQp+emaCaAcP09DOWJ+0FOXLFKwKM SyLgFaSOxtC5odam2RHG6llWP82EMPC3oEcDOoHrEjRIkAvYkwFkL2z6ccmDwHpmtne6 lAQCgoqc/iTdU3Pr7zTc/SQ4XMexh/1MNnRlodeg4+is4lPJtBlKsx8VdrRfsaz7sCcT O8Tg== X-Forwarded-Encrypted: i=1; AJvYcCVTanwtPAQu6YuojENfb6+hN4ov9E07iR7snN/UNvbLsf4kKEApuj5P3tjqdJb2W9jU1UDFaqa4+iJpivuGVYpoajeRY42pU9D4SNwz5Q== X-Gm-Message-State: AOJu0YzDumuYem1zWlkKjIppZ2iW5UbK9wKieTDqlQP8+wFoEvzBZKw0 ZEBRAVU3kVFcLZIRuhTRSLGviMFVRgJDDEERjnB6ryID4+1c3YIb+K2pmjLIqQ== X-Google-Smtp-Source: AGHT+IGkys0fKbeS9Jt1kuxo+kV1ICMy26+vP7tNYAsfOhXbaH/LE978wltzQSZ6voKtVRqGdPcHyg== X-Received: by 2002:a05:6a21:920b:b0:1a0:adbc:7a96 with SMTP id tl11-20020a056a21920b00b001a0adbc7a96mr3099279pzb.36.1709059682411; Tue, 27 Feb 2024 10:48:02 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id km8-20020a17090327c800b001d8f81ecebesm1845645plb.192.2024.02.27.10.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:48:02 -0800 (PST) Date: Wed, 28 Feb 2024 00:17:46 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event Message-ID: <20240227184746.GU2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org> <20240227123230.GP2587@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Minghuan Lian , Thierry Reding , Kishon Vijay Abraham I , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , linux-tegra@vger.kernel.org, Jonathan Hunter , NXP Linux Team , Richard Zhu , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Niklas Cassel , Jingoo Han , Yoshihiro Shimoda , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Feb 27, 2024 at 12:34:15PM -0500, Frank Li wrote: > On Tue, Feb 27, 2024 at 06:02:30PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Feb 26, 2024 at 12:20:41PM -0500, Frank Li wrote: > > > On Sat, Feb 24, 2024 at 12:24:15PM +0530, Manivannan Sadhasivam wrote: > > > > Now that the API is available, let's make use of it. It also handles the > > > > reinitialization of DWC non-sticky registers in addition to sending the > > > > notification to EPF drivers. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > index 2fb8c15e7a91..4e45bc4bca45 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > > > @@ -640,7 +640,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > > > > if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) { > > > > dev_dbg(dev, "Received Linkdown event\n"); > > > > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > > > > - pci_epc_linkdown(pci->ep.epc); > > > > + dw_pcie_ep_linkdown(&pci->ep); > > > > > > Suppose pci_epc_linkdown() will call dw_pcie_ep_linkdown() ? > > > why need direct call dw_pcie_ep_linkdown() here? > > > > > > > I've already justified this in the commit message. Here is the excerpt: > > > > "It also handles the reinitialization of DWC non-sticky registers in addition > > to sending the notification to EPF drivers." > > API function name is too similar. It is hard to know difference from API > naming. It'd better to know what function do from function name. > In reality we cannot name a function based on everything it does. The naming is mostly based on what is the primary motive of the API and here it is handling Link down event. Maybe dw_pcie_ep_handle_linkdown() would be an apt one, but that's out of scope of this series (since changing that would also require changes to other similar APIs). - Mani > Frank > > > > - Mani > > > > -- > > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E34BC54798 for ; Tue, 27 Feb 2024 18:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2rqzz4Zn11V3SV3DkTrRLCt0tvi/fDsAvk+qJX549SA=; b=DdeH8wMqUbikiE DZ+CCUrwsyG6NQ4DktJbSB+0dd5M28cgKu61zR0rIGWxEKGuEKx3sKvGdi4DsyGyGtX7eNIH84JzH fbyPOU3EluRjdB5dzgcTplx/a+ylyUzLuu/UhO5fStJoxW7gWzKOh8bohOojXmnMcFy7YOk2Dmt9i UqkJArd68wGXNke9jsCZ4K1kb2t4gqNVDALKDOMQk0aoKoKAb+ga3iXXmCytnQdu+7HwoyRhWVM2h kG2I3/pjiSn3QtEOkdb9G5gnoqAR0foM0ETiTfXFZavrpPM1n01dRmAbgnzWB+unEathk8sNzzvHg h5LwChA/74TWhm8hKgFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2Uo-00000006UNu-2XHK; Tue, 27 Feb 2024 18:48:06 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2Ul-00000006UMp-2JE0 for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 18:48:05 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6e55bb75c9eso55245b3a.3 for ; Tue, 27 Feb 2024 10:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709059682; x=1709664482; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=CLATq9F3oIKyxmdb+8zYxo30SLGKOGfwpKLvX3ifL6mkUoPViD8sz93eaQ+ACaOmND u2QiK08ITFFN6/IEENVsZeQnRuIj0JDVhNFk2tkMyhbbaVI4R8HSstlygS5mtHsnbPx4 GmdqsIWUCHxM4UJkaDRfTVNp65fLPB1uDcvNvJ+3DsnFnyhBZL6F3cDwGSOzXxNGYZi/ ZD81mr+nyAGWSJAawJLeXrErWkMXZNe2g6DetYLHWKpU21LzU0DuAVEmYBgGvFWDdjH/ SP8WQsgF5LD/qTcRbkapC29W1RjHNuw8qpq+sDkjw9ccrf3vh1XoaSWKrYR8dJjP7p3N lcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059682; x=1709664482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q8ShmjsBfirtuVXn7YN7NE2+9S2ssUe4qcNu7gqy8zk=; b=sAaBi72SRF5/+eTqvvtD6z/QnhUvhvzFAJl8vRgqMXmuneU4ZvH6jDvDwkcm7H6MFc rMnqd9OSWIz7fykwnmrKNCPot0rsl5Nl4r0M4iQf8YculFeDGHbmHoZk1eyP5NnZ5Ujo w4b7hzOkV82+wPpfjZiWcn3ViJUoCbkFR13HOehQCorlWMyOlEhvQClmHyLP068OQDVp BKJTfPPr3mCn13rQnjqXhm3g45LngsQxLvpuYlZDZhNy3ZXzcDCJZlKBFVopt6mt79Jh M4Y1y5xOLW4dKZOPiUzChgfme4POhMXjFrdFCwGgzOX/LZ74kqaq779rT3dNTVnRbEwP J09A== X-Forwarded-Encrypted: i=1; AJvYcCWd+9E5XuZWT9V9BYM/UP2u7MWmIDGfdTftwoFP+rqfs6+GAptVkZUHDm0dWOG4dJ6mr9H7N4vusqwfKo9NPxDuKCh8spSosxz1qeYFTeucyjxJ5dQ= X-Gm-Message-State: AOJu0YyqU9aciNLgsLz6WgGG+IvO+tb4zJNsX+8+3R7uCMp6NCoC7cYJ yhF/fC/lHotBU/E9v+jVidddwJWg8mJcKsvDwLXdKpph3Wx3Qct4W0xdPR5Zow== X-Google-Smtp-Source: AGHT+IGkys0fKbeS9Jt1kuxo+kV1ICMy26+vP7tNYAsfOhXbaH/LE978wltzQSZ6voKtVRqGdPcHyg== X-Received: by 2002:a05:6a21:920b:b0:1a0:adbc:7a96 with SMTP id tl11-20020a056a21920b00b001a0adbc7a96mr3099279pzb.36.1709059682411; Tue, 27 Feb 2024 10:48:02 -0800 (PST) Received: from thinkpad ([117.213.97.177]) by smtp.gmail.com with ESMTPSA id km8-20020a17090327c800b001d8f81ecebesm1845645plb.192.2024.02.27.10.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 10:48:02 -0800 (PST) Date: Wed, 28 Feb 2024 00:17:46 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel Subject: Re: [PATCH v8 09/10] PCI: qcom-ep: Use the generic dw_pcie_ep_linkdown() API to handle LINK_DOWN event Message-ID: <20240227184746.GU2587@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-9-64c7fd0cfe64@linaro.org> <20240227123230.GP2587@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_104803_662657_43E71882 X-CRM114-Status: GOOD ( 27.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMTI6MzQ6MTVQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gVHVlLCBGZWIgMjcsIDIwMjQgYXQgMDY6MDI6MzBQTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gTW9uLCBGZWIgMjYsIDIwMjQgYXQgMTI6MjA6NDFQTSAt MDUwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiA+IE9uIFNhdCwgRmViIDI0LCAyMDI0IGF0IDEyOjI0 OjE1UE0gKzA1MzAsIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3cm90ZToKPiA+ID4gPiBOb3cgdGhh dCB0aGUgQVBJIGlzIGF2YWlsYWJsZSwgbGV0J3MgbWFrZSB1c2Ugb2YgaXQuIEl0IGFsc28gaGFu ZGxlcyB0aGUKPiA+ID4gPiByZWluaXRpYWxpemF0aW9uIG9mIERXQyBub24tc3RpY2t5IHJlZ2lz dGVycyBpbiBhZGRpdGlvbiB0byBzZW5kaW5nIHRoZQo+ID4gPiA+IG5vdGlmaWNhdGlvbiB0byBF UEYgZHJpdmVycy4KPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5pdmFubmFuIFNh ZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZhbUBsaW5hcm8ub3JnPgo+ID4gPiA+IC0tLQo+ ID4gPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXFjb20tZXAuYyB8IDIgKy0K PiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4g PiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3Bj aWUtcWNvbS1lcC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1xY29tLWVwLmMK PiA+ID4gPiBpbmRleCAyZmI4YzE1ZTdhOTEuLjRlNDViYzRiY2E0NSAxMDA2NDQKPiA+ID4gPiAt LS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXFjb20tZXAuYwo+ID4gPiA+ICsr KyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtcWNvbS1lcC5jCj4gPiA+ID4gQEAg LTY0MCw3ICs2NDAsNyBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgcWNvbV9wY2llX2VwX2dsb2JhbF9p cnFfdGhyZWFkKGludCBpcnEsIHZvaWQgKmRhdGEpCj4gPiA+ID4gIAlpZiAoRklFTERfR0VUKFBB UkZfSU5UX0FMTF9MSU5LX0RPV04sIHN0YXR1cykpIHsKPiA+ID4gPiAgCQlkZXZfZGJnKGRldiwg IlJlY2VpdmVkIExpbmtkb3duIGV2ZW50XG4iKTsKPiA+ID4gPiAgCQlwY2llX2VwLT5saW5rX3N0 YXR1cyA9IFFDT01fUENJRV9FUF9MSU5LX0RPV047Cj4gPiA+ID4gLQkJcGNpX2VwY19saW5rZG93 bihwY2ktPmVwLmVwYyk7Cj4gPiA+ID4gKwkJZHdfcGNpZV9lcF9saW5rZG93bigmcGNpLT5lcCk7 Cj4gPiA+IAo+ID4gPiBTdXBwb3NlIHBjaV9lcGNfbGlua2Rvd24oKSB3aWxsIGNhbGwgZHdfcGNp ZV9lcF9saW5rZG93bigpID8KPiA+ID4gd2h5IG5lZWQgZGlyZWN0IGNhbGwgZHdfcGNpZV9lcF9s aW5rZG93bigpIGhlcmU/Cj4gPiA+IAo+ID4gCj4gPiBJJ3ZlIGFscmVhZHkganVzdGlmaWVkIHRo aXMgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLiBIZXJlIGlzIHRoZSBleGNlcnB0Ogo+ID4gCj4gPiAi SXQgYWxzbyBoYW5kbGVzIHRoZSByZWluaXRpYWxpemF0aW9uIG9mIERXQyBub24tc3RpY2t5IHJl Z2lzdGVycyBpbiBhZGRpdGlvbgo+ID4gdG8gc2VuZGluZyB0aGUgbm90aWZpY2F0aW9uIHRvIEVQ RiBkcml2ZXJzLiIKPiAKPiBBUEkgZnVuY3Rpb24gbmFtZSBpcyB0b28gc2ltaWxhci4gSXQgaXMg aGFyZCB0byBrbm93IGRpZmZlcmVuY2UgZnJvbSBBUEkKPiBuYW1pbmcuIEl0J2QgYmV0dGVyIHRv IGtub3cgd2hhdCBmdW5jdGlvbiBkbyBmcm9tIGZ1bmN0aW9uIG5hbWUuCj4gCgpJbiByZWFsaXR5 IHdlIGNhbm5vdCBuYW1lIGEgZnVuY3Rpb24gYmFzZWQgb24gZXZlcnl0aGluZyBpdCBkb2VzLiBU aGUgbmFtaW5nIGlzCm1vc3RseSBiYXNlZCBvbiB3aGF0IGlzIHRoZSBwcmltYXJ5IG1vdGl2ZSBv ZiB0aGUgQVBJIGFuZCBoZXJlIGl0IGlzIGhhbmRsaW5nCkxpbmsgZG93biBldmVudC4gTWF5YmUg ZHdfcGNpZV9lcF9oYW5kbGVfbGlua2Rvd24oKSB3b3VsZCBiZSBhbiBhcHQgb25lLCBidXQKdGhh dCdzIG91dCBvZiBzY29wZSBvZiB0aGlzIHNlcmllcyAoc2luY2UgY2hhbmdpbmcgdGhhdCB3b3Vs ZCBhbHNvIHJlcXVpcmUKY2hhbmdlcyB0byBvdGhlciBzaW1pbGFyIEFQSXMpLgoKLSBNYW5pCgo+ IEZyYW5rCj4gPiAKPiA+IC0gTWFuaQo+ID4gCj4gPiAtLSAKPiA+IOCuruCuo+Cuv+CuteCuo+Cv jeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCi0tIArgrq7grqPgrr/grrXgrqPg r43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==