From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: stable@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Avi Kivity <avi@scylladb.com>,
Sandeep Dhavale <dhavale@google.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH 4.19.y] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio
Date: Tue, 27 Feb 2024 10:22:44 +0100 [thread overview]
Message-ID: <2024022735-overstay-greedy-91c6@gregkh> (raw)
In-Reply-To: <20240226193726.93631-1-bvanassche@acm.org>
On Mon, Feb 26, 2024 at 11:37:26AM -0800, Bart Van Assche wrote:
> If kiocb_set_cancel_fn() is called for I/O submitted via io_uring, the
> following kernel warning appears:
>
> WARNING: CPU: 3 PID: 368 at fs/aio.c:598 kiocb_set_cancel_fn+0x9c/0xa8
> Call trace:
> kiocb_set_cancel_fn+0x9c/0xa8
> ffs_epfile_read_iter+0x144/0x1d0
> io_read+0x19c/0x498
> io_issue_sqe+0x118/0x27c
> io_submit_sqes+0x25c/0x5fc
> __arm64_sys_io_uring_enter+0x104/0xab0
> invoke_syscall+0x58/0x11c
> el0_svc_common+0xb4/0xf4
> do_el0_svc+0x2c/0xb0
> el0_svc+0x2c/0xa4
> el0t_64_sync_handler+0x68/0xb4
> el0t_64_sync+0x1a4/0x1a8
>
> Fix this by setting the IOCB_AIO_RW flag for read and write I/O that is
> submitted by libaio.
>
> Suggested-by: Jens Axboe <axboe@kernel.dk>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Avi Kivity <avi@scylladb.com>
> Cc: Sandeep Dhavale <dhavale@google.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Kent Overstreet <kent.overstreet@linux.dev>
> Cc: stable@vger.kernel.org
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> Link: https://lore.kernel.org/r/20240215204739.2677806-2-bvanassche@acm.org
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> (cherry picked from commit b820de741ae48ccf50dd95e297889c286ff4f760)
> [ bvanassche: resolved merge conflicts ]
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
All backports now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-02-27 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:25 FAILED: patch "[PATCH] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via" failed to apply to 4.19-stable tree gregkh
2024-02-26 19:37 ` [PATCH 4.19.y] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio Bart Van Assche
2024-02-27 9:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024022735-overstay-greedy-91c6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=dhavale@google.com \
--cc=hch@lst.de \
--cc=kent.overstreet@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.