From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Jiri Pirko <jiri@nvidia.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 03/15] ipv6: addrconf_disable_ipv6() optimizations
Date: Wed, 28 Feb 2024 07:11:42 -0800 [thread overview]
Message-ID: <20240228071142.29c8fe1c@kernel.org> (raw)
In-Reply-To: <CANn89iLefNuOXBdf2Cg8SbwAXCm=X+qZ-Cqkx8CQ=vESv-LYSg@mail.gmail.com>
On Wed, 28 Feb 2024 10:28:28 +0100 Eric Dumazet wrote:
> > Good catch, I simply misread the line.
>
> I note that addrconf_disable_policy() does not have a similar write.
>
> When writing on net->ipv6.devconf_all->disable_policy, we loop over all idev
> to call addrconf_disable_policy_idev(),
> but we do _not_ change net->ipv6.devconf_dflt->disable_policy
>
> This seems quite strange we change net->ipv6.devconf_dflt->disable_ipv6 when
> user only wanted to change net->ipv6.devconf_all->disable_policy
The all / default behavior is a complete mess, I don't mind changing!
I commented because there was a flake in TCP-AO tests and I was trying
to find any functional changes :)
next prev parent reply other threads:[~2024-02-28 15:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 15:01 [PATCH v2 net-next 00/15] ipv6: lockless accesses to devconf Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 01/15] ipv6: add ipv6_devconf_read_txrx cacheline_group Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 02/15] ipv6: annotate data-races around cnf.disable_ipv6 Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 03/15] ipv6: addrconf_disable_ipv6() optimizations Eric Dumazet
2024-02-28 2:51 ` Jakub Kicinski
2024-02-28 8:51 ` Eric Dumazet
2024-02-28 9:28 ` Eric Dumazet
2024-02-28 15:11 ` Jakub Kicinski [this message]
2024-02-28 15:14 ` Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 04/15] ipv6: annotate data-races around cnf.mtu6 Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 05/15] ipv6: annotate data-races around cnf.hop_limit Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 06/15] ipv6: annotate data-races around cnf.forwarding Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 07/15] ipv6: annotate data-races in ndisc_router_discovery() Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 08/15] ipv6: annotate data-races around idev->cnf.ignore_routes_with_linkdown Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 09/15] ipv6: annotate data-races in rt6_probe() Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 10/15] ipv6: annotate data-races around devconf->proxy_ndp Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 11/15] ipv6: annotate data-races around devconf->disable_policy Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 12/15] ipv6: addrconf_disable_policy() optimization Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 13/15] ipv6/addrconf: annotate data-races around devconf fields (I) Eric Dumazet
2024-02-27 15:01 ` [PATCH v2 net-next 14/15] ipv6/addrconf: annotate data-races around devconf fields (II) Eric Dumazet
2024-02-27 15:02 ` [PATCH v2 net-next 15/15] ipv6: use xa_array iterator to implement inet6_netconf_dump_devconf() Eric Dumazet
2024-02-27 15:17 ` [PATCH v2 net-next 00/15] ipv6: lockless accesses to devconf Florian Westphal
2024-02-27 15:36 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228071142.29c8fe1c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.