From: Jakub Kicinski <kuba@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Breno Leitao <leitao@debian.org>,
Arnd Bergmann <arnd@arndb.de>, Roger Quadros <rogerq@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs
Date: Wed, 28 Feb 2024 07:25:55 -0800 [thread overview]
Message-ID: <20240228072555.428e0312@kernel.org> (raw)
In-Reply-To: <20240228140413.1862310-1-arnd@kernel.org>
On Wed, 28 Feb 2024 15:03:10 +0100 Arnd Bergmann wrote:
> +#ifdef CONFIG_BQL
> dql_avail(&netif_txq->dql),
> +#else
> + 0,
> +#endif
Same exact code exists in qdisc_avail_bulklimit()
How about we add static inline in netdevice.h wrapping
this, like we do for other BQL related functionality?
(taking in txq as the argument)
prev parent reply other threads:[~2024-02-28 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 14:03 [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs Arnd Bergmann
2024-02-28 14:44 ` Dave Taht
2024-02-28 14:54 ` Arnd Bergmann
2024-02-28 14:56 ` Breno Leitao
2024-02-28 15:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228072555.428e0312@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.