From: Stephen Hemminger <stephen@networkplumber.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Tristram.Ha@microchip.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>,
Simon Horman <horms@kernel.org>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
Murali Karicheri <m-karicheri2@ti.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Ziyang Xuan <william.xuanziyang@huawei.com>,
Kristian Overskeid <koverskeid@gmail.com>,
Matthieu Baerts <matttbe@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: hsr: Provide RedBox support
Date: Wed, 28 Feb 2024 08:31:15 -0800 [thread overview]
Message-ID: <20240228083115.01d4c93e@hermes.local> (raw)
In-Reply-To: <20240228150735.3647892-1-lukma@denx.de>
On Wed, 28 Feb 2024 16:07:35 +0100
Lukasz Majewski <lukma@denx.de> wrote:
>
> +/* hsr_proxy_node_table_show - Formats and prints proxy node_table entries */
> +static int
> +hsr_proxy_node_table_show(struct seq_file *sfp, void *data)
> +{
> + struct hsr_priv *priv = (struct hsr_priv *)sfp->private;
> + struct hsr_node *node;
> +
> + seq_printf(sfp, "Proxy Node Table entries for HSR device\n");
> + seq_puts(sfp, "MAC-Address-SAN, time_in\n");
> + rcu_read_lock();
> + list_for_each_entry_rcu(node, &priv->proxy_node_db, mac_list) {
> + seq_printf(sfp, "%pM ", &node->macaddress_A[0]);
> + seq_printf(sfp, "%10lx\n", node->time_in[HSR_PT_INTERLINK]);
> + }
> + rcu_read_unlock();
> + return 0;
> +}
> +
> DEFINE_SHOW_ATTRIBUTE(hsr_node_table);
> +DEFINE_SHOW_ATTRIBUTE(hsr_proxy_node_table);
NAK
Do not abuse sysfs to be a debug proc style output.
Sysfs is supposed to be one value per file (or not used at all).
Formatting belongs in the user space program.
next prev parent reply other threads:[~2024-02-28 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 15:07 [RFC] net: hsr: Provide RedBox support Lukasz Majewski
2024-02-28 16:31 ` Stephen Hemminger [this message]
2024-02-28 17:03 ` Andrew Lunn
2024-02-29 9:25 ` Lukasz Majewski
2024-02-29 14:59 ` Andrew Lunn
2024-03-01 9:37 ` Lukasz Majewski
2024-02-28 17:13 ` Andrew Lunn
2024-02-29 9:30 ` Lukasz Majewski
2024-02-28 17:58 ` Dan Carpenter
2024-03-01 7:38 ` Ziyang Xuan (William)
2024-03-01 9:55 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228083115.01d4c93e@hermes.local \
--to=stephen@networkplumber.org \
--cc=Tristram.Ha@microchip.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=koverskeid@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=m-karicheri2@ti.com \
--cc=matttbe@kernel.org \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=william.xuanziyang@huawei.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.