From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433576EF17 for ; Wed, 28 Feb 2024 16:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709137916; cv=none; b=PUlZEXs5zMKNvPTcMBVtGvDYIvFNSdxtc1PTCimS0NlSV5CxRhNen94xCXuaN1WaRWg9VZ/HHAFvdAvkWBwIbf67NVa0mSRJmvK1f2awyqRzLZwgr71SoZZDBFK8WurBFe9B6nW8UniCSjZuwj1Ld9lx+pbCG+qrw2G5T1JDGms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709137916; c=relaxed/simple; bh=Ld3prT7ShGpEOrPCyeYTPU4C15FK30+hWNzqk5w4tzA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DSdralKS8z7R3TwYhnGrYs/jzbBHbhhcnjvX+dKP78x7EhRP2GU8DxQ1cxvaYGg2skUiJsxmqw6oE5XRDyySiScPMEUHy7A7+KeitrYth/ZTKumqkDQRA/5T8wz1eROKJaG7v056Hm8xSJCIL1wzyU3TjV1I/X9AEMMoL/SO7l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=sJzbh4ef; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sJzbh4ef" Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F2FAF6B3; Wed, 28 Feb 2024 17:31:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709137899; bh=Ld3prT7ShGpEOrPCyeYTPU4C15FK30+hWNzqk5w4tzA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sJzbh4efxJVI5Wp8EXN+EO7gy5mPR5BrZn2eFX95SDBjruAiHd+hNBrBNd6FlTW8d Aa745wLSXZA4mERHHtlje70Kh40pKUOMRD/6mLBHz1KVwScw20bp1anIiOr/3OA+Cw Yk/f+VdjveJdz5UwfrEZopWkk0g7yojG8O3V0d30= Date: Wed, 28 Feb 2024 18:31:53 +0200 From: Laurent Pinchart To: Adam Ford Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins Message-ID: <20240228163153.GH9863@pendragon.ideasonboard.com> References: <20240228113737.43434-1-aford173@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240228113737.43434-1-aford173@gmail.com> Hi Adam, Thank you for the patch. On Wed, Feb 28, 2024 at 05:37:35AM -0600, Adam Ford wrote: > The IRQ registration currently assumes that the GPIO is > dedicated to it, but that may not necessarily be the case. > If the board has another device sharing the IRQ, it won't be > registered and the hot-plug detect fails. This is easily > fixed by add the IRQF_SHARED flag. > > Signed-off-by: Adam Ford > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index b5518ff97165..21f08b2ae265 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -1318,7 +1318,8 @@ static int adv7511_probe(struct i2c_client *i2c) > > ret = devm_request_threaded_irq(dev, i2c->irq, NULL, > adv7511_irq_handler, > - IRQF_ONESHOT, dev_name(dev), > + IRQF_ONESHOT | IRQF_SHARED, > + dev_name(dev), This looks fine, but the IRQ handler doesn't. static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd) { unsigned int irq0, irq1; int ret; ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0); if (ret < 0) return ret; ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(1), &irq1); if (ret < 0) return ret; regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0); regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1); if (process_hpd && irq0 & ADV7511_INT0_HPD && adv7511->bridge.encoder) schedule_work(&adv7511->hpd_work); if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) { adv7511->edid_read = true; if (adv7511->i2c_main->irq) wake_up_all(&adv7511->wq); } #ifdef CONFIG_DRM_I2C_ADV7511_CEC adv7511_cec_irq_process(adv7511, irq1); #endif return 0; } static irqreturn_t adv7511_irq_handler(int irq, void *devid) { struct adv7511 *adv7511 = devid; int ret; ret = adv7511_irq_process(adv7511, true); return ret < 0 ? IRQ_NONE : IRQ_HANDLED; } The function will return IRQ_HANDLED as long as the registers can be read, even if they don't report any interrupt. > adv7511); > if (ret) > goto err_unregister_audio; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0947C54E4A for ; Wed, 28 Feb 2024 16:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rbOP+L3+eQLi8eQR1iCbYVWqJCr2ahvMulR3Lfhc3FU=; b=LAdxGZu7DuDgMf cYkfQb19lEJSj78ElMqAJZP7ndixwBurdQLFc1dzCVQZdWMXaheBcr+AZ5ggGUXoAIw8kdeb9/NQ1 X1h+2Ea3cZ/AKUH6VwS2qVhSieyQKu4EP6XombjVS0SAFQe+DKTAkq6Gi1l6JFf9lIsw2Oz/PSNW+ zkMt28RpG5B19MzWVyYO3OuBe/AUumOtTQ/4eQKqLC2j76YyIsyBjyfDc5O3+51u4gy24bclJuCBX FTAkM1m/FJL0iqT4W6lTsU2fTEJHayNRCsGRYUdrhCrxqfUUplSBS/DezMV3MHUzJp98MP6YwKHN+ OGw6pZ29CpVF+Rr+m4XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfMqa-0000000A8Ll-0GVt; Wed, 28 Feb 2024 16:31:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfMqX-0000000A8L2-3B2Z for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 16:31:55 +0000 Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F2FAF6B3; Wed, 28 Feb 2024 17:31:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709137899; bh=Ld3prT7ShGpEOrPCyeYTPU4C15FK30+hWNzqk5w4tzA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sJzbh4efxJVI5Wp8EXN+EO7gy5mPR5BrZn2eFX95SDBjruAiHd+hNBrBNd6FlTW8d Aa745wLSXZA4mERHHtlje70Kh40pKUOMRD/6mLBHz1KVwScw20bp1anIiOr/3OA+Cw Yk/f+VdjveJdz5UwfrEZopWkk0g7yojG8O3V0d30= Date: Wed, 28 Feb 2024 18:31:53 +0200 From: Laurent Pinchart To: Adam Ford Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins Message-ID: <20240228163153.GH9863@pendragon.ideasonboard.com> References: <20240228113737.43434-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240228113737.43434-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_083153_961501_B467EA99 X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adam, Thank you for the patch. On Wed, Feb 28, 2024 at 05:37:35AM -0600, Adam Ford wrote: > The IRQ registration currently assumes that the GPIO is > dedicated to it, but that may not necessarily be the case. > If the board has another device sharing the IRQ, it won't be > registered and the hot-plug detect fails. This is easily > fixed by add the IRQF_SHARED flag. > > Signed-off-by: Adam Ford > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index b5518ff97165..21f08b2ae265 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -1318,7 +1318,8 @@ static int adv7511_probe(struct i2c_client *i2c) > > ret = devm_request_threaded_irq(dev, i2c->irq, NULL, > adv7511_irq_handler, > - IRQF_ONESHOT, dev_name(dev), > + IRQF_ONESHOT | IRQF_SHARED, > + dev_name(dev), This looks fine, but the IRQ handler doesn't. static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd) { unsigned int irq0, irq1; int ret; ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(0), &irq0); if (ret < 0) return ret; ret = regmap_read(adv7511->regmap, ADV7511_REG_INT(1), &irq1); if (ret < 0) return ret; regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0); regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1); if (process_hpd && irq0 & ADV7511_INT0_HPD && adv7511->bridge.encoder) schedule_work(&adv7511->hpd_work); if (irq0 & ADV7511_INT0_EDID_READY || irq1 & ADV7511_INT1_DDC_ERROR) { adv7511->edid_read = true; if (adv7511->i2c_main->irq) wake_up_all(&adv7511->wq); } #ifdef CONFIG_DRM_I2C_ADV7511_CEC adv7511_cec_irq_process(adv7511, irq1); #endif return 0; } static irqreturn_t adv7511_irq_handler(int irq, void *devid) { struct adv7511 *adv7511 = devid; int ret; ret = adv7511_irq_process(adv7511, true); return ret < 0 ? IRQ_NONE : IRQ_HANDLED; } The function will return IRQ_HANDLED as long as the registers can be read, even if they don't report any interrupt. > adv7511); > if (ret) > goto err_unregister_audio; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel