From: Robert Marko <robimarko@gmail.com>
To: andersson@kernel.org, konrad.dybcio@linaro.org, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Robert Marko <robimarko@gmail.com>
Subject: [PATCH net-next v2 0/2] net: phy: qcom: qca808x: fill in possible_interfaces
Date: Wed, 28 Feb 2024 18:24:08 +0100 [thread overview]
Message-ID: <20240228172452.2456842-1-robimarko@gmail.com> (raw)
QCA808x does not currently fill in the possible_interfaces.
This leads to Phylink not being aware that it supports 2500Base-X as well
so in cases where it is connected to a DSA switch like MV88E6393 it will
limit that port to phy-mode set in the DTS.
That means that if SGMII is used you are limited to 1G only while if
2500Base-X was set you are limited to 2.5G only.
Populating the possible_interfaces fixes this.
Changes in v2:
* Get rid of the if/else by Russels suggestion in the helper
Robert Marko (2):
net: phy: qcom: qca808x: add helper for checking for 1G only model
net: phy: qcom: qca808x: fill in possible_interfaces
drivers/net/phy/qcom/qca808x.c | 29 ++++++++++++++++++++++++-----
1 file changed, 24 insertions(+), 5 deletions(-)
--
2.44.0
next reply other threads:[~2024-02-28 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 17:24 Robert Marko [this message]
2024-02-28 17:24 ` [PATCH net-next v2 1/2] net: phy: qcom: qca808x: add helper for checking for 1G only model Robert Marko
2024-02-28 17:24 ` [PATCH net-next v2 2/2] net: phy: qcom: qca808x: fill in possible_interfaces Robert Marko
2024-02-28 18:04 ` Russell King (Oracle)
2024-03-01 9:00 ` [PATCH net-next v2 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228172452.2456842-1-robimarko@gmail.com \
--to=robimarko@gmail.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.