From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D97FC5475B for ; Thu, 29 Feb 2024 01:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EGWZ0cD7x136SOPcqoeVdzgHJ9mzEsKOD+NIhP/2Vmc=; b=hsqee9Uymg6UT+Pki3SKY6RS+Y 0gqBxsEMdvcB73QdOKoLJ4tYsx5IuzEyG8zUokFGnjt2P642Sx61XgAzS63TJbY0vHNdqJBFCW2M/ eU00l0DpYuRjiaLO1H2WwsuMqfaTGROQa2hv90KYpClst6kbD4XTvsP86OFi4HplZtUkE9SFYAWRX Pn36dMd1S/7xRMx1zJc1AjXXTRQOKVu7MO/s1++jQizauVS306J/rzW+HE4W7EQHR9mSikiLi36ui cEb/PByhvPqNc1l/Ks1VaW0unR9/VLvw3BrM772whCrT2epT2qF7SabnBenLNHGy07HNrRRv49Qfo dxao+uQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfVYI-0000000Bf0j-1n7X; Thu, 29 Feb 2024 01:49:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfVYE-0000000Bezp-3Ufk; Thu, 29 Feb 2024 01:49:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 12DBA61336; Thu, 29 Feb 2024 01:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 180F9C433C7; Thu, 29 Feb 2024 01:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709171373; bh=Z9+ZItlUKOOugftEXhTeLovJnwPdw0FTe0BJHEfOUvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fZ7/Asn9fee487a/DT2NBXMTgVevreMAjByrP3R1pgFm9XrySx0/QyxylioN5kg5Q TlwAvaCqHNJ9nApguOtuNYt7xw99FnQL2zA5atAfdE6+UIzSd/S8iG5oGfg9hT5Sni vw9NPfzwVYHt1SRGTKCzA67NNWSWIuteEwRPt/nVU03sLVxK+ghXoP4K11IT9AsGnS VH5PacwR99K0WLfN/ev/9lfrooz9Lmsvl6njq1qH5uC9VegOL2nv6XEaXatKfVJ1AS iuWH0zSNCCzfHZUIlT8U2rH8EnHyL3u7oLpUn4WEa/ZhD5t5LtZZZ6JkUyVw1zLNST ka3MCb83MttpA== Date: Wed, 28 Feb 2024 17:49:32 -0800 From: Jakub Kicinski To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= via B4 Relay Cc: , Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 8/8] net: dsa: mt7530: simplify link operations and force link down on all ports Message-ID: <20240228174932.2500653d@kernel.org> In-Reply-To: <20240216-for-netnext-mt7530-improvements-3-v2-8-094cae3ff23b@arinc9.com> References: <20240216-for-netnext-mt7530-improvements-3-v2-0-094cae3ff23b@arinc9.com> <20240216-for-netnext-mt7530-improvements-3-v2-8-094cae3ff23b@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_174934_987821_75F99CC4 X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 16 Feb 2024 14:05:36 +0300 Ar=C4=B1n=C3=A7 =C3=9CNAL via B4 Relay w= rote: > From: Ar=C4=B1n=C3=A7 =C3=9CNAL >=20 > Currently, the link operations for switch MACs are scattered across > port_enable, port_disable, phylink_mac_config, phylink_mac_link_up, and > phylink_mac_link_down. >=20 > port_enable and port_disable clears the link settings. Move that to > mt7530_setup() and mt7531_setup_common() which set up the switches. This > way, the link settings are cleared on all ports at setup, and then only > once with phylink_mac_link_down() when a link goes down. >=20 > Enable force mode at setup to apply the force part of the link settings. > This ensures that only active ports will have their link up. I don't know phylink so some basic questions.. What's "mode" in this case? > Now that the bit for setting the port on force mode is done on > mt7530_setup() and mt7531_setup_common(), get rid of PMCR_FORCE_MODE_ID() > which helped determine which bit to use for the switch model. MT7531_FORCE_MODE also includes MT7531_FORCE_LNK, doesn't that mean=20 the link will be up? > The "MT7621 Giga Switch Programming Guide v0.3", "MT7531 Reference Manual > for Development Board v1.0", and "MT7988A Wi-Fi 7 Generation Router > Platform: Datasheet (Open Version) v0.1" documents show that these bits a= re > enabled at reset: >=20 > PMCR_IFG_XMIT(1) (not part of PMCR_LINK_SETTINGS_MASK) > PMCR_MAC_MODE (not part of PMCR_LINK_SETTINGS_MASK) > PMCR_TX_EN > PMCR_RX_EN > PMCR_BACKOFF_EN (not part of PMCR_LINK_SETTINGS_MASK) > PMCR_BACKPR_EN (not part of PMCR_LINK_SETTINGS_MASK) > PMCR_TX_FC_EN > PMCR_RX_FC_EN >=20 > These bits also don't exist on the MT7530_PMCR_P(6) register of the switch > on the MT7988 SoC: >=20 > PMCR_IFG_XMIT() > PMCR_MAC_MODE > PMCR_BACKOFF_EN > PMCR_BACKPR_EN >=20 > Remove the setting of the bits not part of PMCR_LINK_SETTINGS_MASK on > phylink_mac_config as they're already set. This should be a separate change. > Suggested-by: Vladimir Oltean > Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL > @@ -2257,6 +2255,12 @@ mt7530_setup(struct dsa_switch *ds) > mt7530_mib_reset(ds); > =20 > for (i =3D 0; i < MT7530_NUM_PORTS; i++) { > + /* Clear link settings and enable force mode to force link down "Clear link settings to force link down" makes sense. Since I don't know what the mode is, the "and enable force mode" sounds possibly out of place. If you're only combining this for the convenience of RMW, keep the reasoning separate. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBAEBC5478C for ; Thu, 29 Feb 2024 01:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WKpHywfLPJe5spSNqV8DgZJ3SHDMWG+TsbCE617+bms=; b=NXiZidxYWY7416 BbgX6kLyhyJ90CakqiL3BMMQGw2pIlCeoTp/X0j4qmJHO2iYtQ6XhhRzehNf8Xf4KJ41NeezoZBTt LW2+a0pF8/yqSfRpEOPozv1AELy65DZDWTN8VEuB2v6EiPVJqY25JMHPSUdtKhkPwsIQQ9iICY8Ij cnUCqSdrRfGbM/IR7w6cv81003srMKPR2FzI4hi8ZNbZzgnJwbN4HoGt7AHY8lNbl49lsbaQuShnI Su8+b5vC+STnSlNlScQrD91o2P2kgjEX5HFSfix/xffD35J3bTSvafGtHSbjWW5Km1q/egXB+stii tZQ1KTyr1r6iF0z0hSAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfVYG-0000000Bf0L-3Lxs; Thu, 29 Feb 2024 01:49:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfVYE-0000000Bezp-3Ufk; Thu, 29 Feb 2024 01:49:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 12DBA61336; Thu, 29 Feb 2024 01:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 180F9C433C7; Thu, 29 Feb 2024 01:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709171373; bh=Z9+ZItlUKOOugftEXhTeLovJnwPdw0FTe0BJHEfOUvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fZ7/Asn9fee487a/DT2NBXMTgVevreMAjByrP3R1pgFm9XrySx0/QyxylioN5kg5Q TlwAvaCqHNJ9nApguOtuNYt7xw99FnQL2zA5atAfdE6+UIzSd/S8iG5oGfg9hT5Sni vw9NPfzwVYHt1SRGTKCzA67NNWSWIuteEwRPt/nVU03sLVxK+ghXoP4K11IT9AsGnS VH5PacwR99K0WLfN/ev/9lfrooz9Lmsvl6njq1qH5uC9VegOL2nv6XEaXatKfVJ1AS iuWH0zSNCCzfHZUIlT8U2rH8EnHyL3u7oLpUn4WEa/ZhD5t5LtZZZ6JkUyVw1zLNST ka3MCb83MttpA== Date: Wed, 28 Feb 2024 17:49:32 -0800 From: Jakub Kicinski To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= via B4 Relay Cc: , Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 8/8] net: dsa: mt7530: simplify link operations and force link down on all ports Message-ID: <20240228174932.2500653d@kernel.org> In-Reply-To: <20240216-for-netnext-mt7530-improvements-3-v2-8-094cae3ff23b@arinc9.com> References: <20240216-for-netnext-mt7530-improvements-3-v2-0-094cae3ff23b@arinc9.com> <20240216-for-netnext-mt7530-improvements-3-v2-8-094cae3ff23b@arinc9.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_174934_987821_75F99CC4 X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNiBGZWIgMjAyNCAxNDowNTozNiArMDMwMCBBcsSxbsOnIMOcTkFMIHZpYSBCNCBS ZWxheSB3cm90ZToKPiBGcm9tOiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFsQGFyaW5jOS5jb20+ Cj4gCj4gQ3VycmVudGx5LCB0aGUgbGluayBvcGVyYXRpb25zIGZvciBzd2l0Y2ggTUFDcyBhcmUg c2NhdHRlcmVkIGFjcm9zcwo+IHBvcnRfZW5hYmxlLCBwb3J0X2Rpc2FibGUsIHBoeWxpbmtfbWFj X2NvbmZpZywgcGh5bGlua19tYWNfbGlua191cCwgYW5kCj4gcGh5bGlua19tYWNfbGlua19kb3du Lgo+IAo+IHBvcnRfZW5hYmxlIGFuZCBwb3J0X2Rpc2FibGUgY2xlYXJzIHRoZSBsaW5rIHNldHRp bmdzLiBNb3ZlIHRoYXQgdG8KPiBtdDc1MzBfc2V0dXAoKSBhbmQgbXQ3NTMxX3NldHVwX2NvbW1v bigpIHdoaWNoIHNldCB1cCB0aGUgc3dpdGNoZXMuIFRoaXMKPiB3YXksIHRoZSBsaW5rIHNldHRp bmdzIGFyZSBjbGVhcmVkIG9uIGFsbCBwb3J0cyBhdCBzZXR1cCwgYW5kIHRoZW4gb25seQo+IG9u Y2Ugd2l0aCBwaHlsaW5rX21hY19saW5rX2Rvd24oKSB3aGVuIGEgbGluayBnb2VzIGRvd24uCj4g Cj4gRW5hYmxlIGZvcmNlIG1vZGUgYXQgc2V0dXAgdG8gYXBwbHkgdGhlIGZvcmNlIHBhcnQgb2Yg dGhlIGxpbmsgc2V0dGluZ3MuCj4gVGhpcyBlbnN1cmVzIHRoYXQgb25seSBhY3RpdmUgcG9ydHMg d2lsbCBoYXZlIHRoZWlyIGxpbmsgdXAuCgpJIGRvbid0IGtub3cgcGh5bGluayBzbyBzb21lIGJh c2ljIHF1ZXN0aW9ucy4uCgpXaGF0J3MgIm1vZGUiIGluIHRoaXMgY2FzZT8KCj4gTm93IHRoYXQg dGhlIGJpdCBmb3Igc2V0dGluZyB0aGUgcG9ydCBvbiBmb3JjZSBtb2RlIGlzIGRvbmUgb24KPiBt dDc1MzBfc2V0dXAoKSBhbmQgbXQ3NTMxX3NldHVwX2NvbW1vbigpLCBnZXQgcmlkIG9mIFBNQ1Jf Rk9SQ0VfTU9ERV9JRCgpCj4gd2hpY2ggaGVscGVkIGRldGVybWluZSB3aGljaCBiaXQgdG8gdXNl IGZvciB0aGUgc3dpdGNoIG1vZGVsLgoKTVQ3NTMxX0ZPUkNFX01PREUgYWxzbyBpbmNsdWRlcyBN VDc1MzFfRk9SQ0VfTE5LLCBkb2Vzbid0IHRoYXQgbWVhbiAKdGhlIGxpbmsgd2lsbCBiZSB1cD8K Cj4gVGhlICJNVDc2MjEgR2lnYSBTd2l0Y2ggUHJvZ3JhbW1pbmcgR3VpZGUgdjAuMyIsICJNVDc1 MzEgUmVmZXJlbmNlIE1hbnVhbAo+IGZvciBEZXZlbG9wbWVudCBCb2FyZCB2MS4wIiwgYW5kICJN VDc5ODhBIFdpLUZpIDcgR2VuZXJhdGlvbiBSb3V0ZXIKPiBQbGF0Zm9ybTogRGF0YXNoZWV0IChP cGVuIFZlcnNpb24pIHYwLjEiIGRvY3VtZW50cyBzaG93IHRoYXQgdGhlc2UgYml0cyBhcmUKPiBl bmFibGVkIGF0IHJlc2V0Ogo+IAo+IFBNQ1JfSUZHX1hNSVQoMSkgKG5vdCBwYXJ0IG9mIFBNQ1Jf TElOS19TRVRUSU5HU19NQVNLKQo+IFBNQ1JfTUFDX01PREUgKG5vdCBwYXJ0IG9mIFBNQ1JfTElO S19TRVRUSU5HU19NQVNLKQo+IFBNQ1JfVFhfRU4KPiBQTUNSX1JYX0VOCj4gUE1DUl9CQUNLT0ZG X0VOIChub3QgcGFydCBvZiBQTUNSX0xJTktfU0VUVElOR1NfTUFTSykKPiBQTUNSX0JBQ0tQUl9F TiAobm90IHBhcnQgb2YgUE1DUl9MSU5LX1NFVFRJTkdTX01BU0spCj4gUE1DUl9UWF9GQ19FTgo+ IFBNQ1JfUlhfRkNfRU4KPiAKPiBUaGVzZSBiaXRzIGFsc28gZG9uJ3QgZXhpc3Qgb24gdGhlIE1U NzUzMF9QTUNSX1AoNikgcmVnaXN0ZXIgb2YgdGhlIHN3aXRjaAo+IG9uIHRoZSBNVDc5ODggU29D Ogo+IAo+IFBNQ1JfSUZHX1hNSVQoKQo+IFBNQ1JfTUFDX01PREUKPiBQTUNSX0JBQ0tPRkZfRU4K PiBQTUNSX0JBQ0tQUl9FTgo+IAo+IFJlbW92ZSB0aGUgc2V0dGluZyBvZiB0aGUgYml0cyBub3Qg cGFydCBvZiBQTUNSX0xJTktfU0VUVElOR1NfTUFTSyBvbgo+IHBoeWxpbmtfbWFjX2NvbmZpZyBh cyB0aGV5J3JlIGFscmVhZHkgc2V0LgoKVGhpcyBzaG91bGQgYmUgYSBzZXBhcmF0ZSBjaGFuZ2Uu Cgo+IFN1Z2dlc3RlZC1ieTogVmxhZGltaXIgT2x0ZWFuIDxvbHRlYW52QGdtYWlsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFsQGFyaW5jOS5jb20+Cgo+IEBA IC0yMjU3LDYgKzIyNTUsMTIgQEAgbXQ3NTMwX3NldHVwKHN0cnVjdCBkc2Ffc3dpdGNoICpkcykK PiAgCW10NzUzMF9taWJfcmVzZXQoZHMpOwo+ICAKPiAgCWZvciAoaSA9IDA7IGkgPCBNVDc1MzBf TlVNX1BPUlRTOyBpKyspIHsKPiArCQkvKiBDbGVhciBsaW5rIHNldHRpbmdzIGFuZCBlbmFibGUg Zm9yY2UgbW9kZSB0byBmb3JjZSBsaW5rIGRvd24KCiJDbGVhciBsaW5rIHNldHRpbmdzIHRvIGZv cmNlIGxpbmsgZG93biIgbWFrZXMgc2Vuc2UuClNpbmNlIEkgZG9uJ3Qga25vdyB3aGF0IHRoZSBt b2RlIGlzLCB0aGUgImFuZCBlbmFibGUgZm9yY2UgbW9kZSIKc291bmRzIHBvc3NpYmx5IG91dCBv ZiBwbGFjZS4gSWYgeW91J3JlIG9ubHkgY29tYmluaW5nIHRoaXMKZm9yIHRoZSBjb252ZW5pZW5j ZSBvZiBSTVcsIGtlZXAgdGhlIHJlYXNvbmluZyBzZXBhcmF0ZS4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK