All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Charlie Jenkins <charlie@rivosinc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Erhard Furtner <erhard_f@mailbox.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs
Date: Wed, 28 Feb 2024 17:51:58 -0800	[thread overview]
Message-ID: <20240228175158.04c0aa1b@kernel.org> (raw)
In-Reply-To: <f0eeaab76d6386e22b88d9526ec7a53ae7e98ef5.camel@redhat.com>

On Tue, 27 Feb 2024 10:06:41 +0100 Paolo Abeni wrote:
> On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
> > Hi,
> > 
> > Le 23/02/2024 à 11:41, Christophe Leroy a écrit :  
> > > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
> > > fixed endianness issues with kunit checksum tests, but then
> > > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
> > > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
> > > are once again reflected by the warnings reported by sparse.
> > > 
> > > So, fix them with the same approach, perform proper conversion in
> > > order to support both little and big endian CPUs. Once the conversions
> > > are properly done and the right types used, the sparse warnings are
> > > cleared as well.
> > > 
> > > Reported-by: Erhard Furtner <erhard_f@mailbox.org>
> > > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
> > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>  
> > 
> > netdev checkpatch complains about "1 blamed authors not CCed: 
> > palmer@rivosinc.com; 1 maintainers not CCed: palmer@rivosinc.com "
> > 
> > Palmer was copied but as Palmer Dabbelt <palmer@dabbelt.com>. Hope it is 
> > not a show stopper.  
> 
> No, it's not.
> 
> Acked-by: Paolo Abeni <pabeni@redhat.com>
> 
> I *think* this, despite the subject prefix, should go via Andrew's tree
> to avoid conflicts.
> 
> @Andrew does the above fits you?

I don't see this in linux-next, so unless told otherwise I'll merge it
and ship to Linus tomorrow.

  reply	other threads:[~2024-02-29  1:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 10:41 [PATCH net] kunit: Fix again checksum tests on big endian CPUs Christophe Leroy
2024-02-23 17:57 ` Charlie Jenkins
2024-02-23 18:15   ` Christophe Leroy
2024-02-23 20:05     ` Charlie Jenkins
2024-02-24  7:40       ` Christophe Leroy
2024-02-24  7:44 ` Christophe Leroy
2024-02-27  9:06   ` Paolo Abeni
2024-02-29  1:51     ` Jakub Kicinski [this message]
2024-02-29  1:55       ` Palmer Dabbelt
2024-02-25 15:58 ` Guenter Roeck
2024-02-29 17:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240228175158.04c0aa1b@kernel.org \
    --to=kuba@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=charlie@rivosinc.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=davem@davemloft.net \
    --cc=erhard_f@mailbox.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.