From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next v2 1/2] doc: sfp-phylink: update the porting guide with PCS handling
Date: Wed, 28 Feb 2024 19:56:20 -0800 [thread overview]
Message-ID: <20240228195620.35442c0f@kernel.org> (raw)
In-Reply-To: <20240228095755.1499577-2-maxime.chevallier@bootlin.com>
On Wed, 28 Feb 2024 10:57:53 +0100 Maxime Chevallier wrote:
> + struct foo_priv *priv = container_of(config, struct foo_priv, phylink_config);
The watchful eye of checkpatch spots a trailing space at the end of
this line. While fixing it, perhaps wrap the line as well, it's long.
--
pw-bot: cr
next prev parent reply other threads:[~2024-02-29 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 9:57 [PATCH net-next v2 0/2] doc: sfp-phylink: update the porting guide Maxime Chevallier
2024-02-28 9:57 ` [PATCH net-next v2 1/2] doc: sfp-phylink: update the porting guide with PCS handling Maxime Chevallier
2024-02-29 3:56 ` Jakub Kicinski [this message]
2024-02-28 9:57 ` [PATCH net-next v2 2/2] net: phylink: clean the pcs_get_state documentation Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228195620.35442c0f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.