From: Jakub Kicinski <kuba@kernel.org>
To: "Sanjuán García, Jorge" <Jorge.SanjuanGarcia@duagon.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"s-vadapalli@ti.com" <s-vadapalli@ti.com>,
"r-gunasekaran@ti.com" <r-gunasekaran@ti.com>,
"rogerq@kernel.org" <rogerq@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add IFF_UNICAST_FLT flag to port device
Date: Wed, 28 Feb 2024 20:05:16 -0800 [thread overview]
Message-ID: <20240228200516.1166a097@kernel.org> (raw)
In-Reply-To: <20240228111300.2516590-1-jorge.sanjuangarcia@duagon.com>
On Wed, 28 Feb 2024 11:13:23 +0000 Sanjuán García, Jorge wrote:
> Since commit 8940e6b669ca ("net: dsa: avoid call to __dev_set_promiscuity()
> while rtnl_mutex isn't held") when conecting one of this switch's port
> to a DSA switch as the conduit interface, the network interface is set to
> promiscuous mode by default and cannot be set to not promiscuous mode again
> from userspace. The reason for this is that the cpsw ports net devices
> do not have the flag IFF_UNICAST_FLT set in their private flags.
>
> The cpsw switch should be able to set not promiscuous mode as otherwise
> a '1' is written to bit ALE_PORT_MACONLY_CAF which makes ethernet frames
> get an additional VLAN tag when entering the port connected to the DSA
> switch. Setting the IFF_UNICAST_FLT flag to all ports allows us to have
> the conduit interface on the DSA subsystem set as not promiscuous.
It doesn't look like am65-cpsw-nuss supports unicast filtering,
tho, does it? So we're lying about support to work around some
CPSW weirdness (additional VLAN tag thing)?
next prev parent reply other threads:[~2024-02-29 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 11:13 [PATCH net RESEND] net: ethernet: ti: am65-cpsw: Add IFF_UNICAST_FLT flag to port device Sanjuán García, Jorge
2024-02-29 4:05 ` Jakub Kicinski [this message]
2024-02-29 13:22 ` Andrew Lunn
2024-03-01 11:09 ` Ravi Gunasekaran
2024-03-01 15:49 ` Vladimir Oltean
2024-03-04 10:27 ` Sanjuán García, Jorge
2024-03-06 13:48 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228200516.1166a097@kernel.org \
--to=kuba@kernel.org \
--cc=Jorge.SanjuanGarcia@duagon.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.