From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BD67C48BF6 for ; Thu, 29 Feb 2024 10:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9nRlweZwfY95KPXP9cQvJ/CTC98y/zzhGH4JDs7goUo=; b=sABCnYdI+ICJsM 1LGFhg7PqJi/CFMHtf5ewNoUv4Dy3iZMGf75zzx6LcoIL8im+1VdfLvPbr19/LTI1cBkRMFoqzjNi 506pGPgMdq5tSnOsLfwEXo0jAylVvHyeg45chXGtVtk+ofcfLtKXNc5yaFHtX9KyPYi/h18wqngUY wgR7ul8qzfQ54dUOKDqjTNpBfXgPjtLXKdAduNzHtKuaDeK0AUihafy4CdKrr5iZNHLwSh7poUu8g AikCTGlUQTnQf601pWXd6GGx28B35r2m/AIYvt4PvJP7ngJmH6n38eOB879Sn6tHlRi0lb2cQb6KQ 2vP65OY7+MgkWgqAOoMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdhH-0000000DAno-3JLA; Thu, 29 Feb 2024 10:31:27 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdhD-0000000DAmJ-3BHv; Thu, 29 Feb 2024 10:31:25 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 12CF7E0008; Thu, 29 Feb 2024 10:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709202681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xB/mH2t7HucMvUeJIJZB7RytH2L7kmSd4lRMo452s7Q=; b=QU0VLTe5qBP5PiMq57AosE7CFqBFOBXnPt5TwOODUBfDS3l8/e/Tj4B7hh+x34uzlZmPPw pKfLh3ILuGLD4Lfvgm84/9sbL/BkupVZes47Yz598J+Pug6lLYjHqbN3Vy0vJeWZ9h2WmB 1WLaySXulLngWCHOW64VKR8LS2bLJn91gPYZhsuPF4NIiPjYORzX18ZyDzuIVE1SFZfbIv wTD8UtHmvCK8K4T8UusSmytLGagbr5oezKNJHjbYaICQlSIeQIB2fjcoKjYj9KveHPYxVl slKXGYK+StUOcpqaoN9pENEGE6UFLjHJILKrmEcwrylplnI8G8ozEEfK30DXWw== Date: Thu, 29 Feb 2024 11:31:19 +0100 From: Miquel Raynal To: William Zhang Cc: Linux MTD List , Linux ARM List , Broadcom Kernel List , f.fainelli@gmail.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, David Regan , linux-kernel@vger.kernel.org, Vignesh Raghavendra , Brian Norris , Richard Weinberger Subject: Re: [PATCH v6 12/13] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap Message-ID: <20240229113119.30f7cee6@xps-13> In-Reply-To: References: <20240223034758.13753-1-william.zhang@broadcom.com> <20240223034758.13753-13-william.zhang@broadcom.com> <20240223101852.005da3ad@xps-13> <20240226093632.089d594c@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_023124_089160_DF45E3E8 X-CRM114-Status: GOOD ( 27.70 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgV2lsbGlhbSwKCndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tIHdyb3RlIG9uIE1vbiwgMjYg RmViIDIwMjQgMTI6MDU6MTggLTA4MDA6Cgo+IE9uIDIvMjYvMjQgMDA6MzYsIE1pcXVlbCBSYXlu YWwgd3JvdGU6Cj4gPiBIaSBXaWxsaWFtLAo+ID4gCj4gPiB3aWxsaWFtLnpoYW5nQGJyb2FkY29t LmNvbSB3cm90ZSBvbiBGcmksIDIzIEZlYiAyMDI0IDA5OjI1OjA5IC0wODAwOgo+ID4gICAKPiA+ PiBIaSBNaXF1ZWwsCj4gPj4KPiA+PiBPbiAyLzIzLzI0IDAxOjE4LCBNaXF1ZWwgUmF5bmFsIHdy b3RlOiAgCj4gPj4+IEhpIFdpbGxpYW0sCj4gPj4+Cj4gPj4+IHdpbGxpYW0uemhhbmdAYnJvYWRj b20uY29tIHdyb3RlIG9uIFRodSwgMjIgRmViIDIwMjQgMTk6NDc6NTcgLTA4MDA6ICAKPiA+Pj4g ICAgPj4+PiBCQ01CQ0EgYnJvYWRiYW5kIFNvQyBiYXNlZCBib2FyZCBkZXNpZ24gZG9lcyBub3Qg c3BlY2lmeSBlY2Mgc2V0dGluZyBpbiAgCj4gPj4+PiBkdHMgYnV0IHJhdGhlciB1c2UgdGhlIFNv QyBOQU5EIHN0cmFwIGluZm8gdG8gb2J0YWluIHRoZSBlY2Mgc3RyZW5ndGgKPiA+Pj4+IGFuZCBz cGFyZSBhcmVhIHNpemUgc2V0dGluZy4gQWRkIGJyY20sbmFuZC1lY2MtdXNlLXN0cmFwIGR0cyBw cm9wZXR5IGZvcgo+ID4+Pj4gdGhpcyBwdXJwb3NlIGFuZCB1cGRhdGUgZHJpdmVyIHRvIHN1cHBv cnQgdGhpcyBvcHRpb24uIEhvd2V2ZXIgdGhlc2UgdHdvCj4gPj4+PiBvcHRpb25zIGNhbiBub3Qg YmUgdXNlZCBhdCB0aGUgc2FtZSB0aW1lLgo+ID4+Pj4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IFdp bGxpYW0gWmhhbmcgPHdpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tPgo+ID4+Pj4gUmV2aWV3ZWQt Ynk6IERhdmlkIFJlZ2FuIDxkcmVnYW5AYnJvYWRjb20uY29tPiAgCj4gPj4+PiAgID4+PiAgCj4g Pj4+IEZZSSBJIGRpZCBub3QgcmVjZWl2ZSBwYXRjaGVzIDcsIDgsIDksIHdoaWNoIG1ha2VzIHRo ZSBzZXJpZXMgbnVtYmVyaW5nCj4gPj4+IHZlcnkgb2RkLiAgCj4gPj4+ICAgID4+IEkgd2FzIHVz aW5nIHRoZSBnZXQgbWFpbnRhaW5lciBzY3JpcHQgbWFpbmx5IGFuZCBpdCBzZW5kcyB0byB0aGUg bGludXggTVREIGxpc3QuICBJIHdpbGwgYWRkIHlvdXIgZW1haWwgZGlyZWN0bHkgbmV4dCB0aW1l LiAgCj4gPiAKPiA+IFllcywgSSBwcmVmZXIgdG8gYmUgaW4gQ2Mgb2YgdGhlIHdob2xlIHNlcmll cywgcGxlYXNlLgo+ID4gICAKPiBTdXJlLiAgQW5kIHRoYW5rcyBmb3IgYXBwbHlpbmcgb3RoZXIg cGF0Y2hlcy4gIERvIHlvdSB3YW50IG1lIHRvIGp1c3Qgc2VuZCBhIG5ldyBzaW5nbGUgcGF0Y2gg Zm9yIHRoZSB1cGRhdGU/CgpZZXMganVzdCB0aGUgbWlzc2luZyBwYXRjaC4KCj4gPj4+PiAgICA+ PiArc3RhdGljIGludCBicmNtbmFuZF9nZXRfc2VjdG9yX3NpemVfMWsoc3RydWN0IGJyY21uYW5k X2hvc3QgKmhvc3QpICAKPiA+Pj4+ICt7Cj4gPj4+PiArCXN0cnVjdCBicmNtbmFuZF9jb250cm9s bGVyICpjdHJsID0gaG9zdC0+Y3RybDsKPiA+Pj4+ICsJaW50IHNlY3Rvcl9zaXplX2JpdCA9IGJy Y21uYW5kX3NlY3Rvcl8xa19zaGlmdChjdHJsKTsKPiA+Pj4+ICsJdTE2IGFjY19jb250cm9sX29m ZnMgPSBicmNtbmFuZF9jc19vZmZzZXQoY3RybCwgaG9zdC0+Y3MsCj4gPj4+PiArCQkJCQkJICBC UkNNTkFORF9DU19BQ0NfQ09OVFJPTCk7Cj4gPj4+PiArCXUzMiBhY2NfY29udHJvbDsKPiA+Pj4+ ICsKPiA+Pj4+ICsJaWYgKHNlY3Rvcl9zaXplX2JpdCA8IDApCj4gPj4+PiArCQlyZXR1cm4gMDsK PiA+Pj4+ICsKPiA+Pj4+ICsJYWNjX2NvbnRyb2wgPSBuYW5kX3JlYWRyZWcoY3RybCwgYWNjX2Nv bnRyb2xfb2Zmcyk7Cj4gPj4+PiArCj4gPj4+PiArCXJldHVybiAoYWNjX2NvbnRyb2wgJiBCSVQo c2VjdG9yX3NpemVfYml0KSkgPj4gc2VjdG9yX3NpemVfYml0OyAgCj4gPj4+Cj4gPj4+IEZJRUxE X1BSRVAsIEZJRUxEX0dFVCwgKnBsZWFzZSouICAKPiA+PiBZb3UgcHJvYmFibHkgbWlzc2VkIG15 IHJlcGx5IHRvIHlvdXIgY29tbWVudHMgb24gdGhlIHNhbWUgcGF0Y2ggaW4gdjUuIEhlcmUgaXMg dGhlIGxpbmsgZm9yIHRoZSBwb3N0IGluIGNhc2UgaXQgbG9zdCBpbiB5b3VyIGVtYWlsOgo+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvYzE0NWI5MGMtZTlmMC00ZDgyLTk0Y2MtYmFm N2JmZGE1OTU0QGdtYWlsLmNvbS9ULyNtMWQ5MTFkMmYxMTlmM2JkMzQ1YzU3NWE4MWI2MGJjMmJk OGM0NjFlYiAgCj4gPiAKPiA+IEkgZGlkbid0IG1pc3MgaXQsIGJ1dCB0aGUgcmVhc29uIGRvZXMg bm90IHNvdW5kIGxlZ2l0aW1hdGUgdG8gbWUuCj4gPiBQbGVhc2Ugd29yayBvbiBpdCwgaXQgd2ls bCBiZSBzbyBtdWNoIGNsZWFuZXIuCj4gPiAgIAo+IEkgdW5kZXJzdGFuZCBGSUVMRF9QUkVQL0dF VCBpcyB0aGUgcHJlZmVycmVkIHdheSBvZiBsaW51eCBhY2Nlc3NpbmcgdGhlIHJlZ2lzdGVyIGZp ZWxkcyBidXQgaXQgcmVxdWlyZXMgYSBjb25zdGFudCBNQVNLIHZhbHVlIGFuZCBkb2VzIG5vdCBh cHBseSB0byBvdXIgY2FzZSBhcyB3ZSBoYXZlIGRpZmZlcmVudCB2ZXJzaW9ucyBvZiB0aGUgcmVn aXN0ZXIgYW5kIGhhdmUgZGlmZmVyZW50IG1hc2suICBUaGVyZSBpcyB3YXkgdG8gd29ya2Fyb3Vu ZCBpdC4gaS5lIGRlZmluaW5nIHRoZSBtdWx0aXBsZSBjb25zdGFudHMgZGlyZWN0bHkgYW5kIHVz aW5nIHRoZXNlIG1hY3JvcyB3aXRoIGlmL2Vsc2UgYmFzZWQgb24gcmVnIHZlcnNpb24uIEJ1dCBp dCBpcyBub3QgY2xlYW4gYW5kIHNpbmNlIHdlIGFscmVhZHkgaGF2ZSBoZWxwZXIgZnVuY3Rpb25z IHRoYXQgaGFuZGxlIGFuZCByZXR1cm4gZGlmZmVyZW50IHNoaWZ0L21hc2sgdmFsdWUsIEkgc2Vl IHRoaXMgaXMgYSBwZXJmZWN0IHdheSBmb3Igb3VyIHNpdHVhdGlvbiBhbmQgY2FuIGFkYXB0IHRv IGZ1dHVyZSByZWcgdmVyc2lvbiBjaGFuZ2UgZWFzaWx5IGFuZCBjbGVhbmx5Lgo+IAo+ID4+IFRo ZSBtYXNrIGlzIG5vdCBjb25zdGFudCBoZXJlIGFuZCBjYXVzZSBidWlsZCBlcnJvcnMuICAKCldo aWNoIGVycm9ycz8KCisgICAgICAgYWNjX2NvbnRyb2wgPSBuYW5kX3JlYWRyZWcoY3RybCwgYWNj X2NvbnRyb2xfb2Zmcyk7CisgICAgICAgcmV0dXJuIEZJRUxEX0dFVChCSVQoc2VjdG9yX3NpemVf Yml0KSwgYWNjX2NvbnRyb2wpOwoKRG9lcyBub3QgcmV0dXJuIGFueSBlcnJvciBoZXJlLgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2343C48BF6 for ; Thu, 29 Feb 2024 10:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xG1sjlUb/b3ebpR92EWP1t6LQCKO50wvJ908nQeEKBM=; b=nHuijO7p1DTpGC EOSyvxVQpcNuI8doNrSMp4dkGxEjdMcCJKRsTGCy4Yx4Eq2q3/AOkV9NS4MrB+0MlvUeYGE7CUgLP TnL8w1ETX8lLMiAu/keVAjXTSj5VYr1RUSQV5cxUVPeAySTVgWBywodQD1ECMUfORWFfRUtvQN9TV 0v8b+Ca3wauMijnMlreqvLz2731fwNxLWrBa83B0S9i7TZ7xEdd4/dYKVZiOvz+6R0a6tQDb43UZK PjOI1ZLCPbVd1Uj4BKk8tMOaXJ8Pu7cDkr37yNcnBTw2h+dfB/qViRpG9ht5v/Rvp6ZKnzbScYxT5 IGEf5DjbPfioRr6nNNkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdhH-0000000DAnb-0ewo; Thu, 29 Feb 2024 10:31:27 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfdhD-0000000DAmJ-3BHv; Thu, 29 Feb 2024 10:31:25 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 12CF7E0008; Thu, 29 Feb 2024 10:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709202681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xB/mH2t7HucMvUeJIJZB7RytH2L7kmSd4lRMo452s7Q=; b=QU0VLTe5qBP5PiMq57AosE7CFqBFOBXnPt5TwOODUBfDS3l8/e/Tj4B7hh+x34uzlZmPPw pKfLh3ILuGLD4Lfvgm84/9sbL/BkupVZes47Yz598J+Pug6lLYjHqbN3Vy0vJeWZ9h2WmB 1WLaySXulLngWCHOW64VKR8LS2bLJn91gPYZhsuPF4NIiPjYORzX18ZyDzuIVE1SFZfbIv wTD8UtHmvCK8K4T8UusSmytLGagbr5oezKNJHjbYaICQlSIeQIB2fjcoKjYj9KveHPYxVl slKXGYK+StUOcpqaoN9pENEGE6UFLjHJILKrmEcwrylplnI8G8ozEEfK30DXWw== Date: Thu, 29 Feb 2024 11:31:19 +0100 From: Miquel Raynal To: William Zhang Cc: Linux MTD List , Linux ARM List , Broadcom Kernel List , f.fainelli@gmail.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, David Regan , linux-kernel@vger.kernel.org, Vignesh Raghavendra , Brian Norris , Richard Weinberger Subject: Re: [PATCH v6 12/13] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap Message-ID: <20240229113119.30f7cee6@xps-13> In-Reply-To: References: <20240223034758.13753-1-william.zhang@broadcom.com> <20240223034758.13753-13-william.zhang@broadcom.com> <20240223101852.005da3ad@xps-13> <20240226093632.089d594c@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_023124_089160_DF45E3E8 X-CRM114-Status: GOOD ( 27.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgV2lsbGlhbSwKCndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tIHdyb3RlIG9uIE1vbiwgMjYg RmViIDIwMjQgMTI6MDU6MTggLTA4MDA6Cgo+IE9uIDIvMjYvMjQgMDA6MzYsIE1pcXVlbCBSYXlu YWwgd3JvdGU6Cj4gPiBIaSBXaWxsaWFtLAo+ID4gCj4gPiB3aWxsaWFtLnpoYW5nQGJyb2FkY29t LmNvbSB3cm90ZSBvbiBGcmksIDIzIEZlYiAyMDI0IDA5OjI1OjA5IC0wODAwOgo+ID4gICAKPiA+ PiBIaSBNaXF1ZWwsCj4gPj4KPiA+PiBPbiAyLzIzLzI0IDAxOjE4LCBNaXF1ZWwgUmF5bmFsIHdy b3RlOiAgCj4gPj4+IEhpIFdpbGxpYW0sCj4gPj4+Cj4gPj4+IHdpbGxpYW0uemhhbmdAYnJvYWRj b20uY29tIHdyb3RlIG9uIFRodSwgMjIgRmViIDIwMjQgMTk6NDc6NTcgLTA4MDA6ICAKPiA+Pj4g ICAgPj4+PiBCQ01CQ0EgYnJvYWRiYW5kIFNvQyBiYXNlZCBib2FyZCBkZXNpZ24gZG9lcyBub3Qg c3BlY2lmeSBlY2Mgc2V0dGluZyBpbiAgCj4gPj4+PiBkdHMgYnV0IHJhdGhlciB1c2UgdGhlIFNv QyBOQU5EIHN0cmFwIGluZm8gdG8gb2J0YWluIHRoZSBlY2Mgc3RyZW5ndGgKPiA+Pj4+IGFuZCBz cGFyZSBhcmVhIHNpemUgc2V0dGluZy4gQWRkIGJyY20sbmFuZC1lY2MtdXNlLXN0cmFwIGR0cyBw cm9wZXR5IGZvcgo+ID4+Pj4gdGhpcyBwdXJwb3NlIGFuZCB1cGRhdGUgZHJpdmVyIHRvIHN1cHBv cnQgdGhpcyBvcHRpb24uIEhvd2V2ZXIgdGhlc2UgdHdvCj4gPj4+PiBvcHRpb25zIGNhbiBub3Qg YmUgdXNlZCBhdCB0aGUgc2FtZSB0aW1lLgo+ID4+Pj4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IFdp bGxpYW0gWmhhbmcgPHdpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tPgo+ID4+Pj4gUmV2aWV3ZWQt Ynk6IERhdmlkIFJlZ2FuIDxkcmVnYW5AYnJvYWRjb20uY29tPiAgCj4gPj4+PiAgID4+PiAgCj4g Pj4+IEZZSSBJIGRpZCBub3QgcmVjZWl2ZSBwYXRjaGVzIDcsIDgsIDksIHdoaWNoIG1ha2VzIHRo ZSBzZXJpZXMgbnVtYmVyaW5nCj4gPj4+IHZlcnkgb2RkLiAgCj4gPj4+ICAgID4+IEkgd2FzIHVz aW5nIHRoZSBnZXQgbWFpbnRhaW5lciBzY3JpcHQgbWFpbmx5IGFuZCBpdCBzZW5kcyB0byB0aGUg bGludXggTVREIGxpc3QuICBJIHdpbGwgYWRkIHlvdXIgZW1haWwgZGlyZWN0bHkgbmV4dCB0aW1l LiAgCj4gPiAKPiA+IFllcywgSSBwcmVmZXIgdG8gYmUgaW4gQ2Mgb2YgdGhlIHdob2xlIHNlcmll cywgcGxlYXNlLgo+ID4gICAKPiBTdXJlLiAgQW5kIHRoYW5rcyBmb3IgYXBwbHlpbmcgb3RoZXIg cGF0Y2hlcy4gIERvIHlvdSB3YW50IG1lIHRvIGp1c3Qgc2VuZCBhIG5ldyBzaW5nbGUgcGF0Y2gg Zm9yIHRoZSB1cGRhdGU/CgpZZXMganVzdCB0aGUgbWlzc2luZyBwYXRjaC4KCj4gPj4+PiAgICA+ PiArc3RhdGljIGludCBicmNtbmFuZF9nZXRfc2VjdG9yX3NpemVfMWsoc3RydWN0IGJyY21uYW5k X2hvc3QgKmhvc3QpICAKPiA+Pj4+ICt7Cj4gPj4+PiArCXN0cnVjdCBicmNtbmFuZF9jb250cm9s bGVyICpjdHJsID0gaG9zdC0+Y3RybDsKPiA+Pj4+ICsJaW50IHNlY3Rvcl9zaXplX2JpdCA9IGJy Y21uYW5kX3NlY3Rvcl8xa19zaGlmdChjdHJsKTsKPiA+Pj4+ICsJdTE2IGFjY19jb250cm9sX29m ZnMgPSBicmNtbmFuZF9jc19vZmZzZXQoY3RybCwgaG9zdC0+Y3MsCj4gPj4+PiArCQkJCQkJICBC UkNNTkFORF9DU19BQ0NfQ09OVFJPTCk7Cj4gPj4+PiArCXUzMiBhY2NfY29udHJvbDsKPiA+Pj4+ ICsKPiA+Pj4+ICsJaWYgKHNlY3Rvcl9zaXplX2JpdCA8IDApCj4gPj4+PiArCQlyZXR1cm4gMDsK PiA+Pj4+ICsKPiA+Pj4+ICsJYWNjX2NvbnRyb2wgPSBuYW5kX3JlYWRyZWcoY3RybCwgYWNjX2Nv bnRyb2xfb2Zmcyk7Cj4gPj4+PiArCj4gPj4+PiArCXJldHVybiAoYWNjX2NvbnRyb2wgJiBCSVQo c2VjdG9yX3NpemVfYml0KSkgPj4gc2VjdG9yX3NpemVfYml0OyAgCj4gPj4+Cj4gPj4+IEZJRUxE X1BSRVAsIEZJRUxEX0dFVCwgKnBsZWFzZSouICAKPiA+PiBZb3UgcHJvYmFibHkgbWlzc2VkIG15 IHJlcGx5IHRvIHlvdXIgY29tbWVudHMgb24gdGhlIHNhbWUgcGF0Y2ggaW4gdjUuIEhlcmUgaXMg dGhlIGxpbmsgZm9yIHRoZSBwb3N0IGluIGNhc2UgaXQgbG9zdCBpbiB5b3VyIGVtYWlsOgo+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvYzE0NWI5MGMtZTlmMC00ZDgyLTk0Y2MtYmFm N2JmZGE1OTU0QGdtYWlsLmNvbS9ULyNtMWQ5MTFkMmYxMTlmM2JkMzQ1YzU3NWE4MWI2MGJjMmJk OGM0NjFlYiAgCj4gPiAKPiA+IEkgZGlkbid0IG1pc3MgaXQsIGJ1dCB0aGUgcmVhc29uIGRvZXMg bm90IHNvdW5kIGxlZ2l0aW1hdGUgdG8gbWUuCj4gPiBQbGVhc2Ugd29yayBvbiBpdCwgaXQgd2ls bCBiZSBzbyBtdWNoIGNsZWFuZXIuCj4gPiAgIAo+IEkgdW5kZXJzdGFuZCBGSUVMRF9QUkVQL0dF VCBpcyB0aGUgcHJlZmVycmVkIHdheSBvZiBsaW51eCBhY2Nlc3NpbmcgdGhlIHJlZ2lzdGVyIGZp ZWxkcyBidXQgaXQgcmVxdWlyZXMgYSBjb25zdGFudCBNQVNLIHZhbHVlIGFuZCBkb2VzIG5vdCBh cHBseSB0byBvdXIgY2FzZSBhcyB3ZSBoYXZlIGRpZmZlcmVudCB2ZXJzaW9ucyBvZiB0aGUgcmVn aXN0ZXIgYW5kIGhhdmUgZGlmZmVyZW50IG1hc2suICBUaGVyZSBpcyB3YXkgdG8gd29ya2Fyb3Vu ZCBpdC4gaS5lIGRlZmluaW5nIHRoZSBtdWx0aXBsZSBjb25zdGFudHMgZGlyZWN0bHkgYW5kIHVz aW5nIHRoZXNlIG1hY3JvcyB3aXRoIGlmL2Vsc2UgYmFzZWQgb24gcmVnIHZlcnNpb24uIEJ1dCBp dCBpcyBub3QgY2xlYW4gYW5kIHNpbmNlIHdlIGFscmVhZHkgaGF2ZSBoZWxwZXIgZnVuY3Rpb25z IHRoYXQgaGFuZGxlIGFuZCByZXR1cm4gZGlmZmVyZW50IHNoaWZ0L21hc2sgdmFsdWUsIEkgc2Vl IHRoaXMgaXMgYSBwZXJmZWN0IHdheSBmb3Igb3VyIHNpdHVhdGlvbiBhbmQgY2FuIGFkYXB0IHRv IGZ1dHVyZSByZWcgdmVyc2lvbiBjaGFuZ2UgZWFzaWx5IGFuZCBjbGVhbmx5Lgo+IAo+ID4+IFRo ZSBtYXNrIGlzIG5vdCBjb25zdGFudCBoZXJlIGFuZCBjYXVzZSBidWlsZCBlcnJvcnMuICAKCldo aWNoIGVycm9ycz8KCisgICAgICAgYWNjX2NvbnRyb2wgPSBuYW5kX3JlYWRyZWcoY3RybCwgYWNj X2NvbnRyb2xfb2Zmcyk7CisgICAgICAgcmV0dXJuIEZJRUxEX0dFVChCSVQoc2VjdG9yX3NpemVf Yml0KSwgYWNjX2NvbnRyb2wpOwoKRG9lcyBub3QgcmV0dXJuIGFueSBlcnJvciBoZXJlLgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3926A8D7 for ; Thu, 29 Feb 2024 10:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709202685; cv=none; b=WKSKlto+ZpUbYmhNzVKw+Kl/pWnWiiuBJOmK8TUzJ3aGZjGaTl1TIR0kYDnJSKZ8cwf7AoqGhupbSIX9qokBZW2jbHQR1arLB6YuTxG+vI83N+pKx+UQ/74/+1Xeo3pt2AFsbXf8Fk2ZP3BAG1mTIz7DQ9Kt1cu7amCE3rTYcZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709202685; c=relaxed/simple; bh=X9genLYk5vEwjtUt1AvHjc3bwNpSYBG4qQ/naf2npqs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FV8P8xXm37FDEwweCuBaC2z16N6j75tTGQccI2MZH8iBU4Axgt/N7rCEXi5CV0tXrfZcY1TFb2t9hzhd1JZaBOPb+4td4hBP5zWvOylFqtUA60CaAP9duZBcRotuLl3AHcS+/e4HajtpCGnwbUpsDT+tpf2z1Wd2icrn8rtx/zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=QU0VLTe5; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="QU0VLTe5" Received: by mail.gandi.net (Postfix) with ESMTPSA id 12CF7E0008; Thu, 29 Feb 2024 10:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709202681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xB/mH2t7HucMvUeJIJZB7RytH2L7kmSd4lRMo452s7Q=; b=QU0VLTe5qBP5PiMq57AosE7CFqBFOBXnPt5TwOODUBfDS3l8/e/Tj4B7hh+x34uzlZmPPw pKfLh3ILuGLD4Lfvgm84/9sbL/BkupVZes47Yz598J+Pug6lLYjHqbN3Vy0vJeWZ9h2WmB 1WLaySXulLngWCHOW64VKR8LS2bLJn91gPYZhsuPF4NIiPjYORzX18ZyDzuIVE1SFZfbIv wTD8UtHmvCK8K4T8UusSmytLGagbr5oezKNJHjbYaICQlSIeQIB2fjcoKjYj9KveHPYxVl slKXGYK+StUOcpqaoN9pENEGE6UFLjHJILKrmEcwrylplnI8G8ozEEfK30DXWw== Date: Thu, 29 Feb 2024 11:31:19 +0100 From: Miquel Raynal To: William Zhang Cc: Linux MTD List , Linux ARM List , Broadcom Kernel List , f.fainelli@gmail.com, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, David Regan , linux-kernel@vger.kernel.org, Vignesh Raghavendra , Brian Norris , Richard Weinberger Subject: Re: [PATCH v6 12/13] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap Message-ID: <20240229113119.30f7cee6@xps-13> In-Reply-To: References: <20240223034758.13753-1-william.zhang@broadcom.com> <20240223034758.13753-13-william.zhang@broadcom.com> <20240223101852.005da3ad@xps-13> <20240226093632.089d594c@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi William, william.zhang@broadcom.com wrote on Mon, 26 Feb 2024 12:05:18 -0800: > On 2/26/24 00:36, Miquel Raynal wrote: > > Hi William, > >=20 > > william.zhang@broadcom.com wrote on Fri, 23 Feb 2024 09:25:09 -0800: > > =20 > >> Hi Miquel, > >> > >> On 2/23/24 01:18, Miquel Raynal wrote: =20 > >>> Hi William, > >>> > >>> william.zhang@broadcom.com wrote on Thu, 22 Feb 2024 19:47:57 -0800: = =20 > >>> >>>> BCMBCA broadband SoC based board design does not specify ecc = setting in =20 > >>>> dts but rather use the SoC NAND strap info to obtain the ecc strength > >>>> and spare area size setting. Add brcm,nand-ecc-use-strap dts propety= for > >>>> this purpose and update driver to support this option. However these= two > >>>> options can not be used at the same time. > >>>> > >>>> Signed-off-by: William Zhang > >>>> Reviewed-by: David Regan =20 > >>>> >>> =20 > >>> FYI I did not receive patches 7, 8, 9, which makes the series numberi= ng > >>> very odd. =20 > >>> >> I was using the get maintainer script mainly and it sends to th= e linux MTD list. I will add your email directly next time. =20 > >=20 > > Yes, I prefer to be in Cc of the whole series, please. > > =20 > Sure. And thanks for applying other patches. Do you want me to just sen= d a new single patch for the update? Yes just the missing patch. > >>>> >> +static int brcmnand_get_sector_size_1k(struct brcmnand_host *= host) =20 > >>>> +{ > >>>> + struct brcmnand_controller *ctrl =3D host->ctrl; > >>>> + int sector_size_bit =3D brcmnand_sector_1k_shift(ctrl); > >>>> + u16 acc_control_offs =3D brcmnand_cs_offset(ctrl, host->cs, > >>>> + BRCMNAND_CS_ACC_CONTROL); > >>>> + u32 acc_control; > >>>> + > >>>> + if (sector_size_bit < 0) > >>>> + return 0; > >>>> + > >>>> + acc_control =3D nand_readreg(ctrl, acc_control_offs); > >>>> + > >>>> + return (acc_control & BIT(sector_size_bit)) >> sector_size_bit; =20 > >>> > >>> FIELD_PREP, FIELD_GET, *please*. =20 > >> You probably missed my reply to your comments on the same patch in v5.= Here is the link for the post in case it lost in your email: > >> https://lore.kernel.org/lkml/c145b90c-e9f0-4d82-94cc-baf7bfda5954@gmai= l.com/T/#m1d911d2f119f3bd345c575a81b60bc2bd8c461eb =20 > >=20 > > I didn't miss it, but the reason does not sound legitimate to me. > > Please work on it, it will be so much cleaner. > > =20 > I understand FIELD_PREP/GET is the preferred way of linux accessing the r= egister fields but it requires a constant MASK value and does not apply to = our case as we have different versions of the register and have different m= ask. There is way to workaround it. i.e defining the multiple constants di= rectly and using these macros with if/else based on reg version. But it is = not clean and since we already have helper functions that handle and return= different shift/mask value, I see this is a perfect way for our situation = and can adapt to future reg version change easily and cleanly. >=20 > >> The mask is not constant here and cause build errors. =20 Which errors? + acc_control =3D nand_readreg(ctrl, acc_control_offs); + return FIELD_GET(BIT(sector_size_bit), acc_control); Does not return any error here. Thanks, Miqu=C3=A8l