From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Jiri Pirko <jiri@resnulli.us>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"nathan.sullivan@ni.com" <nathan.sullivan@ni.com>,
"Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net] igb: extend PTP timestamp adjustments to i211
Date: Thu, 29 Feb 2024 12:14:52 -0800 [thread overview]
Message-ID: <20240229121452.2272d01c@kernel.org> (raw)
In-Reply-To: <CO1PR11MB508939BB0C87493121CBE3B2D65F2@CO1PR11MB5089.namprd11.prod.outlook.com>
On Thu, 29 Feb 2024 20:09:03 +0000 Keller, Jacob E wrote:
> > On Wed, 28 Feb 2024 17:43:03 +0000 Keller, Jacob E wrote:
> > > Without this, the i211 doesn't apply the Tx/Rx latency adjustments,
> > > so the timestamps would be less accurate than if the corrections are
> > > applied. On the one hand I guess this is a "feature" and the lack of
> > > a feature isn't a bug, so maybe its not viewed as a bug fix then.
> >
> > I tossed a coin and it said.... "whatever, man". Such sass, tsk tsk.
>
> I might have not had enough caffiene when writing that email... 😊
Sorry, my bad, I was barely awake. What I meant to convey is that
it's borderline, so discussing how people feel is not a good use of
anyone's time.
It's a 3 LoC change to include one chip in what's done for another chip,
it has been well tested, and has user impact. It's fine.
next prev parent reply other threads:[~2024-02-29 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 18:49 [PATCH net] igb: extend PTP timestamp adjustments to i211 Tony Nguyen
2024-02-28 9:37 ` Jiri Pirko
2024-02-28 12:28 ` Oleksij Rempel
2024-02-28 17:43 ` Keller, Jacob E
2024-02-29 4:20 ` Jakub Kicinski
2024-02-29 20:09 ` Keller, Jacob E
2024-02-29 20:14 ` Jakub Kicinski [this message]
2024-02-29 8:29 ` Jiri Pirko
2024-02-29 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229121452.2272d01c@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.