All of lore.kernel.org
 help / color / mirror / Atom feed
From: cem@kernel.org <cem@kernel.org>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 1/6] riscv: Add test to probe SBI Extension
Date: Thu, 29 Feb 2024 13:42:07 +0100	[thread overview]
Message-ID: <20240229124246.309304-2-cem@kernel.org> (raw)
In-Reply-To: <20240229124246.309304-1-cem@kernel.org>

From: Carlos Maiolino <cem@kernel.org>

Factor out vendor id test to a new helper, and add a new test for probing the
SBI extension.
Compare the retrieved value against an environment variable, as the
implementation can return any non-zero value.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 riscv/sbi.c | 52 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 40 insertions(+), 12 deletions(-)

diff --git a/riscv/sbi.c b/riscv/sbi.c
index ffb07a25..9dc82ecb 100644
--- a/riscv/sbi.c
+++ b/riscv/sbi.c
@@ -14,28 +14,56 @@ static void help(void)
 	puts("An environ must be provided where expected values are given.\n");
 }
 
-int main(int argc, char **argv)
+static void check_base(void)
 {
 	struct sbiret ret;
 	long expected;
 
-	if (argc > 1 && !strcmp(argv[1], "-h")) {
-		help();
-		exit(0);
-	}
-
-	report_prefix_push("sbi");
+	report_prefix_push("base");
 
 	if (!getenv("MVENDORID")) {
 		report_skip("mvendorid: missing MVENDORID environment variable");
-		goto done;
+		return;
 	}
+
+	report_prefix_push("mvendorid");
 	expected = strtol(getenv("MVENDORID"), NULL, 0);
 
-	ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_MVENDORID, 0, 0, 0, 0, 0, 0);
-	report(!ret.error, "mvendorid: no error");
-	report(ret.value == expected, "mvendorid");
+	ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_GET_MVENDORID,
+			0, 0, 0, 0, 0, 0);
+
+	report(!ret.error, "no sbi.error");
+	report(ret.value == expected, "expected sbi.value");
+	report_prefix_pop();
+
+	if (!getenv("PROBE_EXT")) {
+		report_skip("probe_ext: missing PROBE_EXT environment variable");
+		return;
+	}
+
+	report_prefix_push("probe_ext");
+	expected = strtol(getenv("PROBE_EXT"), NULL, 0);
+
+	ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT,
+			SBI_EXT_BASE, 0, 0, 0, 0, 0);
+
+	report(!ret.error, "no sbi.error");
+	report(ret.value == expected, "expected sbi.value");
+	report_prefix_pop();
+
+	report_prefix_pop();
+}
+
+int main(int argc, char **argv)
+{
+
+	if (argc > 1 && !strcmp(argv[1], "-h")) {
+		help();
+		exit(0);
+	}
+
+	report_prefix_push("sbi");
+	check_base();
 
-done:
 	return report_summary();
 }
-- 
2.43.2



  reply	other threads:[~2024-02-29 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 12:42 [PATCH 0/6] Add riscv tests to cover the base extension specs cem
2024-02-29 12:42 ` cem [this message]
2024-03-01  8:25   ` [PATCH 1/6] riscv: Add test to probe SBI Extension Andrew Jones
2024-02-29 12:42 ` [PATCH 2/6] riscv: Factor out environment variable check cem
2024-03-01  8:28   ` Andrew Jones
2024-03-04 10:52     ` Carlos Maiolino
2024-02-29 12:42 ` [PATCH 3/6] riscv: Implement test for architecture ID register cem
2024-03-01  8:31   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 4/6] riscv: Enable gen_report() to print the wrong value in case of test failure cem
2024-03-01  8:43   ` Andrew Jones
2024-03-05  8:05     ` Carlos Maiolino
2024-03-05 12:16       ` Andrew Jones
2024-03-01  8:46   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 5/6] riscv: Test for specific SBI implementation ID cem
2024-03-01  8:45   ` Andrew Jones
2024-02-29 12:42 ` [PATCH 6/6] riscv: Test for a SBI implementation ID range cem
2024-03-01  8:52   ` Andrew Jones
2024-02-29 14:05 ` [PATCH 0/6] Add riscv tests to cover the base extension specs Andrew Jones
2024-02-29 14:12   ` Carlos Maiolino
2024-02-29 15:03     ` Andrew Jones
2024-02-29 15:31       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229124246.309304-2-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.