From mboxrd@z Thu Jan 1 00:00:00 1970 From: cem@kernel.org Date: Thu, 29 Feb 2024 13:42:10 +0100 Subject: [PATCH 4/6] riscv: Enable gen_report() to print the wrong value in case of test failure In-Reply-To: <20240229124246.309304-1-cem@kernel.org> References: <20240229124246.309304-1-cem@kernel.org> Message-ID: <20240229124246.309304-5-cem@kernel.org> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Carlos Maiolino If the test fails because the expected value doesn't match, it's useful to know what value was actually printed. Signed-off-by: Carlos Maiolino --- riscv/sbi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/riscv/sbi.c b/riscv/sbi.c index fa28d7c8..8ad8f375 100644 --- a/riscv/sbi.c +++ b/riscv/sbi.c @@ -28,7 +28,12 @@ static bool env_is_defined(const char *env) static void gen_report(struct sbiret *ret, long expected) { report(!ret->error, "no sbi.error"); - report(ret->value == expected, "expected sbi.value"); + + if (ret->value == expected) + report(true, "expected sbi.value"); + else + report(false, "expected sbi.value: %ld - Got: %ld", + expected, ret->value); } static void check_base(void) -- 2.43.2