All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Xing <kerneljasonxing@gmail.com>
To: edumazet@google.com, mhiramat@kernel.org,
	mathieu.desnoyers@efficios.com, rostedt@goodmis.org
Cc: netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	kerneljasonxing@gmail.com, Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next 0/2] add two missing addresses when using trace
Date: Fri,  1 Mar 2024 01:09:54 +0800	[thread overview]
Message-ID: <20240229170956.87290-1-kerneljasonxing@gmail.com> (raw)

From: Jason Xing <kernelxing@tencent.com>

When I reviewed other people's patch [1], I noticed that similar thing
also happens in tcp_event_skb class and tcp_event_sk_skb class. They
don't print those two addrs of skb/sk which already exist.

They are probably forgotten by the original authors, so this time I
finish the work. Also, adding more trace about the socket/skb addr can
help us sometime even though the chance is minor.

I don't consider it is a bug, thus I chose to target net-next tree.

[1]
Link: https://lore.kernel.org/netdev/CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com/

Jason Xing (2):
  tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
  tcp: add tracing of skbaddr in tcp_event_skb class

 include/trace/events/tcp.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.37.3


             reply	other threads:[~2024-02-29 17:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 17:09 Jason Xing [this message]
2024-02-29 17:09 ` [PATCH net-next 1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class Jason Xing
2024-03-04  8:24   ` Eric Dumazet
2024-03-04  8:31     ` Jason Xing
2024-02-29 17:09 ` [PATCH net-next 2/2] tcp: add tracing of skbaddr in tcp_event_skb class Jason Xing
2024-03-04  7:00 ` [PATCH net-next 0/2] add two missing addresses when using trace Jason Xing
2024-03-04  8:21   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229170956.87290-1-kerneljasonxing@gmail.com \
    --to=kerneljasonxing@gmail.com \
    --cc=edumazet@google.com \
    --cc=kernelxing@tencent.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.