From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/5] powerpc/64s: Use .machine power4 around dcbt
Date: Thu, 29 Feb 2024 11:20:25 -0600 [thread overview]
Message-ID: <20240229172025.GV19790@gate.crashing.org> (raw)
In-Reply-To: <20240229122521.762431-2-mpe@ellerman.id.au>
On Thu, Feb 29, 2024 at 11:25:18PM +1100, Michael Ellerman wrote:
> There are multiple decodings for the "dcbt" mnemonic, so the assembler
> has to pick one.
>
> That requires passing -many to the assembler, which is not recommended.
>
> Without -many the clang 14 / binutils 2.38 build fails with:
>
> arch/powerpc/kernel/exceptions-64s.S:2976: Error: junk at end of line: `0b01010'
> clang: error: assembler command failed with exit code 1 (use -v to see invocation)
>
> Fix it by adding .machine directives around the use of dcbt to specify
> which encoding is desired.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good, thanks!
Acked-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
next prev parent reply other threads:[~2024-02-29 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:25 [PATCH 1/5] powerpc/64s: Move dcbt/dcbtst sequence into a macro Michael Ellerman
2024-02-29 12:25 ` [PATCH 2/5] powerpc/64s: Use .machine power4 around dcbt Michael Ellerman
2024-02-29 17:20 ` Segher Boessenkool [this message]
2024-02-29 12:25 ` [PATCH 3/5] powerpc/fsl: Fix mfpmr build errors with newer binutils Michael Ellerman
2024-02-29 12:25 ` [PATCH 4/5] powerpc/fsl: Modernise mt/mfpmr Michael Ellerman
2024-02-29 17:23 ` Segher Boessenkool
2024-02-29 12:25 ` [PATCH 5/5] powerpc: Remove cpu-as-y completely Michael Ellerman
2024-02-29 17:26 ` Segher Boessenkool
2024-03-13 13:19 ` [PATCH 1/5] powerpc/64s: Move dcbt/dcbtst sequence into a macro Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229172025.GV19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.