From: "Michael Büsch" <m@bues.ch>
To: Rand Deeb <rand.sec96@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
deeb.rand@confident.ru, lvc-project@linuxtesting.org,
voskresenski.stanislav@confident.ru
Subject: Re: [PATCH] ssb: Fix potential NULL pointer dereference in ssb_device_uevent
Date: Thu, 29 Feb 2024 19:08:54 +0100 [thread overview]
Message-ID: <20240229190854.3717772c@barney> (raw)
In-Reply-To: <20240229093756.129324-1-rand.sec96@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Thu, 29 Feb 2024 12:37:56 +0300
Rand Deeb <rand.sec96@gmail.com> wrote:
> static int ssb_device_uevent(struct device *dev, struct kobj_uevent_env *env)
> {
> - struct ssb_device *ssb_dev = dev_to_ssb_dev(dev);
> + struct ssb_device *ssb_dev;
>
> if (!dev)
> return -ENODEV;
>
> + ssb_dev = dev_to_ssb_dev(dev);
> +
> return add_uevent_var(env,
> "MODALIAS=ssb:v%04Xid%04Xrev%02X",
> ssb_dev->id.vendor, ssb_dev->id.coreid,
Good catch.
Acked-by: Michael Büsch <m@bues.ch>
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-29 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 9:37 [PATCH] ssb: Fix potential NULL pointer dereference in ssb_device_uevent Rand Deeb
2024-02-29 13:40 ` Jonas Gorski
2024-02-29 18:08 ` Michael Büsch [this message]
2024-03-05 18:55 ` Kalle Valo
2024-03-06 11:25 ` [PATCH v2] " Rand Deeb
2024-03-06 11:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229190854.3717772c@barney \
--to=m@bues.ch \
--cc=deeb.rand@confident.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rand.sec96@gmail.com \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.