From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Subject: Re: [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs
Date: Fri, 1 Mar 2024 08:43:58 +0200 [thread overview]
Message-ID: <20240301064358.GL8454@black.fi.intel.com> (raw)
In-Reply-To: <20240229145303.3801332-1-andriy.shevchenko@linux.intel.com>
On Thu, Feb 29, 2024 at 04:51:37PM +0200, Andy Shevchenko wrote:
> Two out of three GPIO count APIs take device pointer. OF case clearly
> does not need it as it immediately switches to device node inside, and
> ACPI abstracts that to struct acpi_device pointer. Unify all these by
> making them to take struct fwnode_handle pointer. This, in particular,
> will allow to create fwnode_gpio_count() API if needed. The need of that
> was discussed here [1].
>
> Note, no functional changes intended.
>
> Link: https://lore.kernel.org/r/2ad735ed-963c-4e75-b83e-687ea2c0aef5@alliedtelesis.co.nz [1]
>
> In v2:
> - fixed typo (Chris)
> - added tag (Linus)
>
> Andy Shevchenko (2):
> gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter
> gpiolib-acpi: Make acpi_gpio_count() take firmware node as a parameter
For both,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2024-03-01 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:51 [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs Andy Shevchenko
2024-02-29 14:51 ` [PATCH v2 1/2] gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter Andy Shevchenko
2024-02-29 15:02 ` Andy Shevchenko
2024-02-29 14:51 ` [PATCH v2 2/2] gpiolib-acpi: Make acpi_gpio_count() " Andy Shevchenko
2024-03-01 6:43 ` Mika Westerberg [this message]
2024-03-01 8:09 ` [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301064358.GL8454@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.