From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] cgroup_dir_mk: set the umask to '0' before creating the subdir
Date: Fri, 1 Mar 2024 12:51:31 +0100 [thread overview]
Message-ID: <20240301115131.GC1661970@pevik> (raw)
In-Reply-To: <20240301102347.3035546-1-liwang@redhat.com>
Hi Li, Wei,
> This is to resolve the permission issue when creating
> a new subdir in the cgroup, in case of system's default
> umask is 0077, this will trigger issues for LTP case.
> cgroup_core01.c will report following error msg:
> cgroup_core01.c:50: TBROK: openat(21</sys/fs/cgroup/memory/ltp/test-3519/child_b>, 'tasks', 2, 0): EACCES (13)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Setting this on single place which *should* fix problems, but still not affect
whole LTP API looks good to me. BTW there were more tests which needed it,
e.g. testcases/kernel/syscalls/statx/statx07.c
https://patchwork.ozlabs.org/project/ltp/patch/20240222031018.12281-3-wegao@suse.com/
Therefore this solves just some problems.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-01 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 10:23 [LTP] [PATCH] cgroup_dir_mk: set the umask to '0' before creating the subdir Li Wang
2024-03-01 11:51 ` Petr Vorel [this message]
2024-03-03 10:33 ` Wei Gao via ltp
2024-03-03 9:46 ` Wei Gao via ltp
2024-03-03 12:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301115131.GC1661970@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.