From: Kees Cook <keescook@chromium.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message_state
Date: Fri, 1 Mar 2024 12:42:06 -0800 [thread overview]
Message-ID: <202403011242.C7C42CCCF@keescook> (raw)
In-Reply-To: <20240301-mainline-axi-spi-engine-small-cleanups-v1-1-241dfd2a79f7@baylibre.com>
On Fri, Mar 01, 2024 at 02:25:18PM -0600, David Lechner wrote:
> The program pointer p in struct spi_engine_message_state in the AXI SPI
> Engine controller driver was assigned but never read so it can be
> removed.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-03-01 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 20:25 [PATCH 0/3] spi: axi-spi-engine: small cleanups David Lechner
2024-03-01 20:25 ` [PATCH 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message_state David Lechner
2024-03-01 20:42 ` Kees Cook [this message]
2024-03-01 20:25 ` [PATCH 2/3] spi: axi-spi-engine: use __counted_by() attribute David Lechner
2024-03-01 20:41 ` Kees Cook
2024-03-01 20:25 ` [PATCH 3/3] spi: axi-spi-engine: use struct_size() macro David Lechner
2024-03-01 20:45 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403011242.C7C42CCCF@keescook \
--to=keescook@chromium.org \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.