[dhowells-fs:rxrpc-iothread 24/24] net/rxrpc/output.c:486 rxrpc_tstamp_data_packets() error: uninitialized symbol 'serial'.

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: David Howells <dhowells@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-iothread
head:   ca6f236e32ce19f9c0c477e133c58134e122134b
commit: ca6f236e32ce19f9c0c477e133c58134e122134b [24/24] rxrpc: Send jumbo DATA packets
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
config: x86_64-randconfig-161-20240301 (https://download.01.org/0day-ci/archive/20240301/202403012020.3164BhlP-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202403012020.3164BhlP-lkp@intel.com/

smatch warnings:
net/rxrpc/output.c:486 rxrpc_tstamp_data_packets() error: uninitialized symbol 'serial'.

vim +/serial +486 net/rxrpc/output.c

44125d5aaddadf David Howells 2024-01-26  465  
44125d5aaddadf David Howells 2024-01-26  466  /*
2cd274cfeb88fe David Howells 2024-01-31  467   * Set timeouts after transmitting a packet.
44125d5aaddadf David Howells 2024-01-26  468   */
ca6f236e32ce19 David Howells 2024-01-26  469  static void rxrpc_tstamp_data_packets(struct rxrpc_call *call, struct rxrpc_txbuf *txb, int n)
44125d5aaddadf David Howells 2024-01-26  470  {
ca6f236e32ce19 David Howells 2024-01-26  471  	rxrpc_serial_t serial;
2cd274cfeb88fe David Howells 2024-01-31  472  	ktime_t now = ktime_get_real();
2cd274cfeb88fe David Howells 2024-01-31  473  	bool ack_requested = txb->flags & RXRPC_REQUEST_ACK;
ca6f236e32ce19 David Howells 2024-01-26  474  	int i;
44125d5aaddadf David Howells 2024-01-26  475  
2cd274cfeb88fe David Howells 2024-01-31  476  	call->tx_last_sent = now;
ca6f236e32ce19 David Howells 2024-01-26  477  
ca6f236e32ce19 David Howells 2024-01-26  478  	for (i = 0; i < n; i++) {
2cd274cfeb88fe David Howells 2024-01-31  479  		txb->last_sent = now;
ca6f236e32ce19 David Howells 2024-01-26  480  		ack_requested |= txb->flags & RXRPC_REQUEST_ACK;
ca6f236e32ce19 David Howells 2024-01-26  481  		serial = txb->serial;
ca6f236e32ce19 David Howells 2024-01-26  482  		txb = list_next_entry(txb, call_link);
ca6f236e32ce19 David Howells 2024-01-26  483  	}
2cd274cfeb88fe David Howells 2024-01-31  484  
2cd274cfeb88fe David Howells 2024-01-31  485  	if (ack_requested) {
ca6f236e32ce19 David Howells 2024-01-26 @486  		rxrpc_begin_rtt_probe(call, serial, now, rxrpc_rtt_tx_data);
2cd274cfeb88fe David Howells 2024-01-31  487  
2cd274cfeb88fe David Howells 2024-01-31  488  		call->peer->rtt_last_req = now;
2cd274cfeb88fe David Howells 2024-01-31  489  		if (call->peer->rtt_count > 1) {
2cd274cfeb88fe David Howells 2024-01-31  490  			ktime_t delay = rxrpc_get_rto_backoff(call->peer, false);
2cd274cfeb88fe David Howells 2024-01-31  491  
2cd274cfeb88fe David Howells 2024-01-31  492  			call->ack_lost_at = ktime_add(now, delay);
2cd274cfeb88fe David Howells 2024-01-31  493  			trace_rxrpc_timer_set(call, delay, rxrpc_timer_trace_lost_ack);
2cd274cfeb88fe David Howells 2024-01-31  494  		}
2cd274cfeb88fe David Howells 2024-01-31  495  	}
2cd274cfeb88fe David Howells 2024-01-31  496  
2cd274cfeb88fe David Howells 2024-01-31  497  	if (!test_and_set_bit(RXRPC_CALL_BEGAN_RX_TIMER, &call->flags)) {
2cd274cfeb88fe David Howells 2024-01-31  498  		ktime_t delay = ms_to_ktime(READ_ONCE(call->next_rx_timo));
2cd274cfeb88fe David Howells 2024-01-31  499  
2cd274cfeb88fe David Howells 2024-01-31  500  		call->expect_rx_by = ktime_add(now, delay);
2cd274cfeb88fe David Howells 2024-01-31  501  		trace_rxrpc_timer_set(call, delay, rxrpc_timer_trace_expect_rx);
2cd274cfeb88fe David Howells 2024-01-31  502  	}
44125d5aaddadf David Howells 2024-01-26  503  
2cd274cfeb88fe David Howells 2024-01-31  504  	rxrpc_set_keepalive(call, now);
44125d5aaddadf David Howells 2024-01-26  505  }
44125d5aaddadf David Howells 2024-01-26  506  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki